Re: kernel32:tests:path.c Add test for GetShortPathNameW [try3]

[Alexandre Julliard]

Anatoly Lyutin  writes:
> - if ( GetThreadLocale() == CyrLCID )
> - {
> -
>    /* Create  directory with Cyrillic long name */
> -
>    helper_GetShortPathNameW( pathRL );
> -
> -
>    /* Create directory with Cyrillic short name */
> -
>    helper_GetShortPathNameW( pathRS );
> - }
> - else
> -
>    skip( "Not Cyrillic locale.Test skipped.\n" );

There's nothing specific about the Cyrillic locale in
GetShortPathName; the only thing that could possibly matter is the
file system encoding, but that's not the same thing. What are you
trying to test here?

kernel32:tests:path.c Add test for GetShortPathNameW [try3]

[Anatoly Lyutin]

Alexandre Julliard wrote:
> Anatoly Lyutin  writes:
> > - if ( GetThreadLocale() == CyrLCID )
> > - {
> > -
> >    /* Create  directory with Cyrillic long name */
> > -
> >    helper_GetShortPathNameW( pathRL );
> > -
> > -
> >    /* Create directory with Cyrillic short name */
> > -
> >    helper_GetShortPathNameW( pathRS );
> > - }
> > - else
> > -
> >    skip( "Not Cyrillic locale.Test skipped.\n" );
>
> There's nothing specific about the Cyrillic locale in
> GetShortPathName; the only thing that could possibly matter is the
> file system encoding, but that's not the same thing. What are you
> trying to test here?

This test only shows correct work GetShortPathNameW with latin and non 
Latin charsets. The Cyrillic locale is chosen only as locale with non 
Latin symbols.

I basically searched for a problem in program that uses 
GetShortPathNameA and OpenFile16. That is why I wrote test for 
GetShortPathNameW first some time ago.

kernel32:tests:path.c Add test for GetShortPathNameW [try3]

[Alexandre Julliard]

Anatoly Lyutin  writes:
> This test only shows correct work GetShortPathNameW with latin and non
> Latin charsets. The Cyrillic locale is chosen only as locale with non
> Latin symbols.

Since you are testing the Unicode function, why would non-Latin make
any difference?  Again, what behavior are you trying to test?

kernel32:tests:path.c Add test for GetShortPathNameW [try3]

[Anatoly Lyutin]

Alexandre Julliard wrote:
> Anatoly Lyutin  writes:
> > This test only shows correct work GetShortPathNameW with latin and non
> > Latin charsets. The Cyrillic locale is chosen only as locale with non
> > Latin symbols.
>
> Since you are testing the Unicode function, why would non-Latin make
> any difference?

Only that this code conversion will be correct. Although I understand 
that it is for Unicode does not  matter. It is only additional test.
> Again, what behavior are you trying to test?

That the program can create a file using a short name for directory. 
That the short name for directory is formed correct.

Am I wrong?

kernel32:tests:path.c Add test for GetShortPathNameW [try3]

[Alexandre Julliard]

Anatoly Lyutin  writes:
> Only that this code conversion will be correct. Although I understand
> that it is for Unicode does not  matter. It is only additional test.

Yes but it's useless. Please get rid of the Russian chars and try to
write a more meaningful test that works in all locales.

kernel32:tests:path.c Add test for GetShortPathNameW [try3]

[Anatoly Lyutin]

Alexandre Julliard wrote:
> Anatoly Lyutin  writes:
> > Only that this code conversion will be correct. Although I understand
> > that it is for Unicode does not  matter. It is only additional test.
>
> Yes but it's useless. Please get rid of the Russian chars and try to
> write a more meaningful test that works in all locales.

Ok. I resend a patch that contain only test for Latin symbols.