Hi,
Today someone asked me to look at some Wine problems when running a gaming app called "Steam". Because I wasn't using the latest version of the app, the program tried to update itself. During the update process the main program (steam.exe) needs to be replaced by a new version. To do this the old program exits and another executable is being launched. The new process tries to backup the old steam.exe to wine's temp drive to restore it in case something goes wrong. Here the real problem appears. After "moving/renaming" the file the update tool gives an error stating that steam.exe still exists.
After looking at the debug output I saw that to move the file the update tool is using MoveFileW. Normally nothing is wrong with this but according to MSDN (http://msdn.microsoft.com/library/default.asp?url=/library/en-us/fileio/base...) it can be used for about everything except for the following:
"The MoveFile function will move (rename) either a file or a directory (including its children) either in the same directory or across directories. The one caveat is that the MoveFile function will fail on directory moves when the destination is on a different volume."
The update tool is using something like this: MoveFileW(steam.exe, e:\steam.exe)
So it tries to move a file from c:\steam\steam.exe to e:\steam.exe which according to the MSDN docs is not possible. The same works fine on Win2k. After hacking MoveFileW to not check if the volumes are different it worked fine on Wine too.
What shall we do? Shall we implement the same bugs Windows is doing or shall e listen to the docs at MSDN? (I'm sure some tests need to be made)
Roderick Colenbrander
Hi Roderick, At 14.32 25/02/2003 +0100, Roderick Colenbrander wrote:
[...] "The MoveFile function will move (rename) either a file or a directory (including its children) either in the same directory or across directories. The one caveat is that the MoveFile function will fail on directory moves when the destination is on a different volume."
The update tool is using something like this: MoveFileW(steam.exe, e:\steam.exe)
If I read it right, MSDN says that you cannot move a *directory* between volumes, not a single file (like in this case). So, the check should be done only when the source path points to a directory.
Alberto
So it tries to move a file from c:\steam\steam.exe to e:\steam.exe which according to the MSDN docs is not possible. The same works fine on Win2k. After hacking MoveFileW to not check if the volumes are different it worked fine on Wine too.
What shall we do? Shall we implement the same bugs Windows is doing or shall e listen to the docs at MSDN? (I'm sure some tests need to be made)
Roderick Colenbrander
Wait a second. It seems I didn't read the MSDN info well enough. It seems directory copies across multiple volumes aren't allowed, but file copies are. (my fault).
Will submit a bugfix soon.
On Tuesday 25 February 2003 14:32, Roderick Colenbrander wrote:
Hi,
Today someone asked me to look at some Wine problems when running a gaming app called "Steam". Because I wasn't using the latest version of the app, the program tried to update itself. During the update process the main program (steam.exe) needs to be replaced by a new version. To do this the old program exits and another executable is being launched. The new process tries to backup the old steam.exe to wine's temp drive to restore it in case something goes wrong. Here the real problem appears. After "moving/renaming" the file the update tool gives an error stating that steam.exe still exists.
After looking at the debug output I saw that to move the file the update tool is using MoveFileW. Normally nothing is wrong with this but according to MSDN (http://msdn.microsoft.com/library/default.asp?url=/library/en-us/fileio/ba se/movefile.asp) it can be used for about everything except for the following:
"The MoveFile function will move (rename) either a file or a directory (including its children) either in the same directory or across directories. The one caveat is that the MoveFile function will fail on directory moves when the destination is on a different volume."
The update tool is using something like this: MoveFileW(steam.exe, e:\steam.exe)
So it tries to move a file from c:\steam\steam.exe to e:\steam.exe which according to the MSDN docs is not possible. The same works fine on Win2k. After hacking MoveFileW to not check if the volumes are different it worked fine on Wine too.
What shall we do? Shall we implement the same bugs Windows is doing or shall e listen to the docs at MSDN? (I'm sure some tests need to be made)
Roderick Colenbrander
"Roderick" == Roderick Colenbrander thunderbird2k@gmx.net writes:
Roderick> Wait a second. It seems I didn't read the MSDN info well Roderick> enough. It seems directory copies across multiple volumes Roderick> aren't allowed, but file copies are. (my fault).
Roderick> Will submit a bugfix soon.
Submitting a test case for dlls/kernel/test is appreciated.
Bye
-
Alberto Massari -
Roderick Colenbrander -
Uwe Bonnes