Our 'winspool.h' contains:
#include "windef.h" #include "winbase.h" #include "wingdi.h"
This means you can write a C file that just contains '#include <winspool.h>' and it will work. But that would fail on Windows because in the Windows sdk 'winspool.h' contains none of these #include directives.
I don't really like headers that require you to #include other headers first. So I like our winspool.h better than the Windows one. But should we 'fix' it anyway? To avoid people writing tests that compile in Wine but not on Windows for instance? ;-)
On January 5, 2003 05:27 pm, Francois Gouget wrote:
This means you can write a C file that just contains '#include <winspool.h>' and it will work. But that would fail on Windows because in the Windows sdk 'winspool.h' contains none of these #include directives.
I think we should not include more than the Windows headers. This way our sources will be compatible with other headers as well, such as w32api, or the MS ones (if and when we'll try to compile some of our stuff on Windows).
Francois Gouget fgouget@free.fr writes:
I don't really like headers that require you to #include other headers first. So I like our winspool.h better than the Windows one. But should we 'fix' it anyway? To avoid people writing tests that compile in Wine but not on Windows for instance? ;-)
Yes we should fix it, our headers should have the exact same dependency graph as the Windows ones.
-
Alexandre Julliard -
Dimitrie O. Paun -
Francois Gouget