[PATCH] kernel32: Add AttachConsole implementation.

[Jacek Caban]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41573
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=43910
Signed-off-by: Jacek Caban 
---
 dlls/kernel32/console.c       |  19 +++++-
 dlls/kernel32/tests/console.c | 131
+++++++++++++++++++++++++++++++++++++++---
 server/console.c              |  43 ++++++++++++++
 server/protocol.def           |  10 ++++
 4 files changed, 193 insertions(+), 10 deletions(-)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=40594

Your paranoid android.

=== debian9 (build) ===
../../wine/server/console.c:1560:39: error: dereferencing pointer to incomplete type ‘const struct attach_console_request’
../../wine/server/console.c:1566:14: error: dereferencing pointer to incomplete type ‘struct attach_console_reply’
Makefile:316: recipe for target 'console.o' failed
Makefile:8550: recipe for target 'server' failed
Task: The win32 build failed

[Jacek Caban]

On 08/09/2018 06:49 PM, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
>
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=40594
>
> Your paranoid android.
>
> === debian9 (build) ===
> ../../wine/server/console.c:1560:39: error: dereferencing pointer to incomplete type ‘const struct attach_console_request’
> ../../wine/server/console.c:1566:14: error: dereferencing pointer to incomplete type ‘struct attach_console_reply’
> Makefile:316: recipe for target 'console.o' failed
> Makefile:8550: recipe for target 'server' failed
> Task: The win32 build failed

It looks like Testbot can't handle patches requiring make_request.

Jacek

[Francois Gouget]

On Thu, 9 Aug 2018, Jacek Caban wrote:
[...]
> It looks like Testbot can't handle patches requiring make_request.

Yep. The TestBot does not know about make_request. My understanding is 
that make_request should be rerun whenever server/protocol.def is 
modified. Is that all?

The question is whether this dependency should be handled by the 
makefiles. If the answer is yes then the generated files should be 
removed from Git otherwise there will be timestamp problems, and I would 
let Alexandre tweak the makefiles.

If not and all that's required is detecting patches to 
server/protocol.def, then it's quite easy to add support for it to the 
TestBot.

[Alexandre Julliard]

Francois Gouget  writes:
> The question is whether this dependency should be handled by the 
> makefiles. If the answer is yes then the generated files should be 
> removed from Git otherwise there will be timestamp problems, and I would 
> let Alexandre tweak the makefiles.
>
> If not and all that's required is detecting patches to 
> server/protocol.def, then it's quite easy to add support for it to the 
> TestBot.

The testbot should be handling it.