Re: [1/4] dinput: Return error for unknown property.

[Vitaliy Margolen]

Sergey Khodych wrote:
> -
>        WARN("Unknown property %s\n", debugstr_guid(rguid));
> -
>        break;
> -
>        FIXME("Unknown property %s\n", debugstr_guid(rguid));
> -
>        return DIERR_UNSUPPORTED;

I'd like to see tests for this. Also lots of programs will break because 
they won't get some not significant property. No short - don't do this.

Vitaliy

[1/4] dinput: Return error for unknown property.

[Sergey Khodych]

> I'd like to see tests for this. Also lots of programs will break because 
> they won't get some not significant property. No short - don't do this.

But wine return a garbage value also for significant property. This 
value may cause undefined behavior of application. The patch will make 
errors more explicit.

[1/4] dinput: Return error for unknown property.

[Vitaliy Margolen]

Sergey Khodych wrote:
> > I'd like to see tests for this. Also lots of programs will break because 
> > they won't get some not significant property. No short - don't do this.
>
> But wine return a garbage value also for significant property. This 
> value may cause undefined behavior of application. The patch will make 
> errors more explicit.

On another hand - that's the way Wine been headed - break everything that's 
not implemented. So go ahead and put that error in.

Vitaliy.