Re: setupapi - ReactOS Merge 20050205

[Alexandre Julliard]

Steven Edwards  writes:
> +BOOL WINAPI DelayedMove(LPCWSTR lpExistingFileName, LPCWSTR lpNewFileName)
> +{
> - if (OsVersionInfo.dwPlatformId != VER_PLATFORM_WIN32_NT)
> - {
> -
>    SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> -
>    return FALSE;
> - }
> -
> - return MoveFileExW(lpExistingFileName, lpNewFileName,
> -
>                   MOVEFILE_REPLACE_EXISTING | MOVEFILE_DELAY_UNTIL_REBOOT);
>
> +}

You shouldn't do that kind of preventive version check, you should
always call the function and then deal with failures appropriately.

setupapi - ReactOS Merge 20050205

[Steven Edwards]

--- Alexandre Julliard  wrote:
> You shouldn't do that kind of preventive version check, you should
> always call the function and then deal with failures appropriately.

Sorry I am a little dense. If both functions are just no-ops on Win9x then the app should not be
calling them anyway right? or if they are then in that mode they would be expecting that return
value?

Thanks
Steven

__________________________________ 
Do you Yahoo!? 
The all-new My Yahoo! - Get yours free! 
http://my.yahoo.com

setupapi - ReactOS Merge 20050205

[Alexandre Julliard]

Steven Edwards  writes:
> --- Alexandre Julliard  wrote:
> > You shouldn't do that kind of preventive version check, you should
> > always call the function and then deal with failures appropriately.
>
> Sorry I am a little dense. If both functions are just no-ops on Win9x then the app should not be
> calling them anyway right? or if they are then in that mode they would be expecting that return
> value?

That's why the version checks are unnecessary. Apps that check the
version won't use these functions anyway, and apps that don't check
will just work. There's no point at all in adding extra checks to
deliberately break a function, unless of course an app really depends
on the broken behavior.

setupapi - ReactOS Merge 20050205

[Steven Edwards]

> That's why the version checks are unnecessary. Apps that check the
> version won't use these functions anyway, and apps that don't check
> will just work. There's no point at all in adding extra checks to
> deliberately break a function, unless of course an app really depends
> on the broken behavior.

OK. Here you go sans superfluous version check.

Thanks
Steven

Eric Kohl 
Implement DelayedMove and FileExists

__________________________________ 
Do you Yahoo!? 
Read only the mail you want - Yahoo! Mail SpamGuard. 
http://promotions.yahoo.com/new_mail