Re: [PATCH] mmdevapi: Fix pointer type cast

[Andrew Eikum]

On Sat, Dec 10, 2016 at 08:54:51AM +0300, Nikolay Sivov wrote:
> diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c
> index 221fb39..b189e8e 100644
> --- a/dlls/mmdevapi/devenum.c
> +++ b/dlls/mmdevapi/devenum.c
> @@ -613,7 +613,7 @@ static HRESULT WINAPI MMDevice_Activate(IMMDevice *iface, REFIID riid, DWORD cls
>          if (SUCCEEDED(hr))
>          {
>              IPersistPropertyBag *ppb;
> -
>        hr = IUnknown_QueryInterface((IUnknown*)*ppv, &IID_IPersistPropertyBag, (void*)&ppb);
> -
>        hr = IUnknown_QueryInterface((IUnknown*)*ppv, &IID_IPersistPropertyBag, (void **)&ppb);
>        if (SUCCEEDED(hr))
>        {
>            /* ::Load cannot assume the interface stays alive after the function returns,

Seems like this (and other similar cleanup patches) should be deferred
until after freeze, right?

Andrew

[PATCH] mmdevapi: Fix pointer type cast

[Nikolay Sivov]

On 12.12.2016 16:39, Andrew Eikum wrote:
> On Sat, Dec 10, 2016 at 08:54:51AM +0300, Nikolay Sivov wrote:
> > diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c
> > index 221fb39..b189e8e 100644
> > --- a/dlls/mmdevapi/devenum.c
> > +++ b/dlls/mmdevapi/devenum.c
> > @@ -613,7 +613,7 @@ static HRESULT WINAPI MMDevice_Activate(IMMDevice *iface, REFIID riid, DWORD cls
> >          if (SUCCEEDED(hr))
> >          {
> >              IPersistPropertyBag *ppb;
> > -
> >        hr = IUnknown_QueryInterface((IUnknown*)*ppv, &IID_IPersistPropertyBag, (void*)&ppb);
> > -
> >        hr = IUnknown_QueryInterface((IUnknown*)*ppv, &IID_IPersistPropertyBag, (void **)&ppb);
> >        if (SUCCEEDED(hr))
> >        {
> >            /* ::Load cannot assume the interface stays alive after the function returns,
>
> Seems like this (and other similar cleanup patches) should be deferred
> until after freeze, right?
>
> Andrew

Personally I don't see why, but I have no problem resending after it's over.

[PATCH] mmdevapi: Fix pointer type cast

[Alexandre Julliard]

Nikolay Sivov  writes:
> On 12.12.2016 16:39, Andrew Eikum wrote:
> > On Sat, Dec 10, 2016 at 08:54:51AM +0300, Nikolay Sivov wrote:
> > > diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c
> > > index 221fb39..b189e8e 100644
> > > --- a/dlls/mmdevapi/devenum.c
> > > +++ b/dlls/mmdevapi/devenum.c
> > > @@ -613,7 +613,7 @@ static HRESULT WINAPI MMDevice_Activate(IMMDevice *iface, REFIID riid, DWORD cls
> > >          if (SUCCEEDED(hr))
> > >          {
> > >              IPersistPropertyBag *ppb;
> > > -
> > >        hr = IUnknown_QueryInterface((IUnknown*)*ppv, &IID_IPersistPropertyBag, (void*)&ppb);
> > > -
> > >        hr = IUnknown_QueryInterface((IUnknown*)*ppv, &IID_IPersistPropertyBag, (void **)&ppb);
> > >        if (SUCCEEDED(hr))
> > >        {
> > >            /* ::Load cannot assume the interface stays alive after the function returns,
> >
> > Seems like this (and other similar cleanup patches) should be deferred
> > until after freeze, right?
> >
> > Andrew
>
> Personally I don't see why, but I have no problem resending after it's over.

While the patches are most likely harmless, during code freeze we want
to minimize code churn, and we want people to concentrate on fixing real
bugs, so that sort of thing will have to wait.