Signed-off-by: Francois Gouget fgouget@free.fr --- dlls/riched20/tests/editor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlls/riched20/tests/editor.c b/dlls/riched20/tests/editor.c index 3a6a072f1f8..ab74e0ef1ab 100644 --- a/dlls/riched20/tests/editor.c +++ b/dlls/riched20/tests/editor.c @@ -8995,8 +8995,8 @@ static void test_EM_SELECTIONTYPE(void) START_TEST( editor ) { BOOL ret; - /* Must explicitly LoadLibrary(). The test has no references to functions in - * RICHED20.DLL, so the linker doesn't actually link to it. */ + /* Must explicitly LoadLibrary(). The test has no reference to functions in + * RICHED20.DLL, so the linker does not actually link to it. */ hmoduleRichEdit = LoadLibraryA("riched20.dll"); ok(hmoduleRichEdit != NULL, "error: %d\n", (int) GetLastError()); is_lang_japanese = (PRIMARYLANGID(GetSystemDefaultLangID()) == LANG_JAPANESE);
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=94456
Your paranoid android.
=== w2008s64 (64 bit report) ===
riched20: editor.c:5469: Test failed: test paste: strcmp = 1, text='testing paste
On Fri, 23 Jul 2021, Marvin wrote: [...]
[...]
=== w2008s64 (64 bit report) ===
riched20: editor.c:5469: Test failed: test paste: strcmp = 1, text='testing paste
Not caused by this patch since it only modifies a comment.
But interestingly, so far I have only seen this failure on Windows 10, and not on this line either.
For instance:
Windows 10 1809 https://test.winehq.org/data/96030ce738aa20f85a5138ec7c231c19a086f019/win180... editor.c:5537: Test failed: test paste: strcmp = -1, actual = ''
Windows 10 2004 Hebrew https://test.winehq.org/data/fd7954974b9d94b4abe5b2ee8918f8ca063b51db/win200... editor.c:5537: Test failed: test paste: strcmp = -1, actual = 'paste'
Windows 10 2004 Korean https://test.winehq.org/data/542175ab10420953920779f3c64eb310dd3aa258/win200... editor.c:5608: Test failed: test paste: strcmp = -1, actual = ''
Does anyone know what's up with these copy/paste tests? https://test.winehq.org/data/patterns.html#riched20:editor