Re: msi: Print the string and not the pointer in a TRACE.

[Hans Leidekker]

On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote:
> @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, LPCSTR szFolder,
>      awstring str;
>      UINT r;
> - TRACE("%s %p %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf);
> - TRACE("%s %s %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf);

szPathBuf is an output buffer.

msi: Print the string and not the pointer in a TRACE.

[Michael Stefaniuc]

Hans Leidekker wrote:
> On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote:
> > @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, LPCSTR szFolder,
> >      awstring str;
> >      UINT r;
> > - TRACE("%s %p %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf);
> > - TRACE("%s %s %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf);
>
> szPathBuf is an output buffer.

Ok, then the format should stay as %p and the debugstr_a() should go.

bye
    michael

msi: Print the string and not the pointer in a TRACE.

[Hans Leidekker]

On Tue, 2011-09-20 at 10:51 +0200, Michael Stefaniuc wrote:
> Hans Leidekker wrote:
> > On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote:
> > > @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, LPCSTR szFolder,
> > >      awstring str;
> > >      UINT r;
> > > - TRACE("%s %p %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf);
> > > - TRACE("%s %s %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf);
> >
> > szPathBuf is an output buffer.
>
> Ok, then the format should stay as %p and the debugstr_a() should go.

Yes, note that Francois has already sent a patch.