Re: Resend: WineD3D: pixel format cleanup

[Ivan Gyurdiev]

On 6/21/06, Stefan Dösinger  wrote:
> This is a resend of the patch from a few days ago with some modifications
> requested by Alexandre:
>
> *getFormatDescEntry returns a pointer to a format structure, not an index
> in
> the array
> - Removed the format counter

Stefan, can you clarify what happened to the GL_SUPPORT check for compressed
formats?

Resend: WineD3D: pixel format cleanup

[Stefan Dösinger]

Am Mittwoch 21 Juni 2006 15:21 schrieb Ivan Gyurdiev:
> Stefan, can you clarify what happened to the GL_SUPPORT check for
> compressed formats?

The check wheter a pixelformat is actually supported will happen in 
IWineD3DImpl_CheckDeviceFormatand createsurface should call this function to 
verify wether a format is supported. Checking if a format is supported before 
returning the gl config doesn't really make sense. If the format isn't 
supported and we ask gl for a compressed texture we will get an error 
returned and broken graphics(because we ignore gl errors generally). If we 
pass 0 instead for the gl format and internal format we will have broken 
graphics too but I don't think gl returns an error then(although I'd have to 
check the man page for that)

IWineD3DImpl_CheckDeviceFormat needs a fixup too, like whitelisting formats 
instead of blacklisting them.

Stefan