Re: try5 [1/4](resend) kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice

[Paul Vriens]

Guy Albertelli wrote:
> Fixed memory leak and changed skip to win_skip in this patch.
> Add todo_wine as necessary so all tests pass.
>
> Changelog:
> - Enhance QueryDosDevice test for attempting to return all devices.
> - Add tests for GetVolumeInformationA testing the different root dir formats.
>
> dlls/kernel32/tests/volume.c |  138 ++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 134 insertions(+), 4 deletions(-)

One of the tests fails on all W2K, XP and W2K3 boxes (no Vista results yet):

http://test.winehq.org/data/tests/kernel32:volume.html

Could you have a look?

There is also a lot of trace/debugging information coming from these new 
tests. Is this needed?

try5 [1/4](resend) kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice

[Guy Albertelli]

On Wed, 2009-04-29 at 18:42 +0200, Paul Vriens wrote:
> Guy Albertelli wrote:
> > Fixed memory leak and changed skip to win_skip in this patch.
> > Add todo_wine as necessary so all tests pass.
> >
> > Changelog:
> > - Enhance QueryDosDevice test for attempting to return all devices.
> > - Add tests for GetVolumeInformationA testing the different root dir formats.
> >
> > dlls/kernel32/tests/volume.c |  138 ++++++++++++++++++++++++++++++++++++++++-
> >  1 files changed, 134 insertions(+), 4 deletions(-)
>
> One of the tests fails on all W2K, XP and W2K3 boxes (no Vista results yet):
>
> http://test.winehq.org/data/tests/kernel32:volume.html
>
> Could you have a look?
>
> There is also a lot of trace/debugging information coming from these new 
> tests. Is this needed?

Will find and fix.

Thanks Guy

try5 [1/4](resend) kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice

[Paul Vriens]

Guy Albertelli wrote:
> On Wed, 2009-04-29 at 18:42 +0200, Paul Vriens wrote:
> > Guy Albertelli wrote:
> > > Fixed memory leak and changed skip to win_skip in this patch.
> > > Add todo_wine as necessary so all tests pass.
> > >
> > > Changelog:
> > > - Enhance QueryDosDevice test for attempting to return all devices.
> > > - Add tests for GetVolumeInformationA testing the different root dir formats.
> > >
> > > dlls/kernel32/tests/volume.c |  138 ++++++++++++++++++++++++++++++++++++++++-
> > >  1 files changed, 134 insertions(+), 4 deletions(-)
> >
> > One of the tests fails on all W2K, XP and W2K3 boxes (no Vista results yet):
> >
> > http://test.winehq.org/data/tests/kernel32:volume.html
> >
> > Could you have a look?
> >
> > There is also a lot of trace/debugging information coming from these new 
> > tests. Is this needed?
>
> Will find and fix.
>
> Thanks Guy

Just saw your patch, thanks.

try5 [1/4](resend) kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice

[Paul Vriens]

Paul Vriens wrote:
> Guy Albertelli wrote:
> > Fixed memory leak and changed skip to win_skip in this patch.
> > Add todo_wine as necessary so all tests pass.
> >
> > Changelog:
> > - Enhance QueryDosDevice test for attempting to return all devices.
> > - Add tests for GetVolumeInformationA testing the different root dir
> > formats.
> >
> > dlls/kernel32/tests/volume.c |  138 
> > ++++++++++++++++++++++++++++++++++++++++-
> >  1 files changed, 134 insertions(+), 4 deletions(-)
>
> One of the tests fails on all W2K, XP and W2K3 boxes (no Vista results 
> yet):
>
> http://test.winehq.org/data/tests/kernel32:volume.html
>
> Could you have a look?
>
> There is also a lot of trace/debugging information coming from these new 
> tests. Is this needed?

So everything as of W2K has the same error:

volume.c:342: Test failed: GetVolumeInformationA failed, 
root=<something>, last error=123

On Win98 we also have some failures but for QueryDosDevice:

volume.c:46: Test failed: QueryDosDevice buffer too small
volume.c:52: Test failed: QueryDosDeviceA failed to return list, last 
error 87

Looks like Win98 doesn't like the NULL parameter passed to QueryDosDevice?

Win95 doesn't have QueryDosDevice and sets last error to 
ERROR_CALL_NOT_IMPLEMENTED.