Re: [wininet]add implementation of few more options - try5

[Dmitry Timoshkov]

"Vijay Kiran Kamuju"  wrote:
> as previous implementation had some bugs use this version and
> implements some suggestions
> more tests to come
> ChangeLog
>
> Added implementation for INTERNET_OPTION_VERSION
>  Added implementation for INTERNET_OPTION_USER_AGENT
>  Fixed behavior for INTERNET_OPTION_HTTP_VERSION
>  Added implementation for unsupported options
>  Added some minimalist testcases

You could send your patch billion times, but there is no point in that
if you don't fix the pointed out problems.

[wininet]add implementation of few more options - try5

[Vijay Kiran Kamuju]

Juan:

You told me to cleanup if the connection fails, i could not understand
how to clean up.
If you could suggest me an example to do a clean up, it would be gr8.
I just copied some stuff from tests of http.c
Please suggest me how to improve the tests, i have removed the ok and
the cruft for if(hurl == 0x0)

Dimitry:
I will try a zillion times, to make my patches get thru ;) :P

Thanks and Regards,
Vijay

PS:
-----
Could you please be online on irc to discuss this

On 11/10/05, Dmitry Timoshkov  wrote:
> "Vijay Kiran Kamuju"  wrote:
> > as previous implementation had some bugs use this version and
> > implements some suggestions
> > more tests to come
> > ChangeLog
> >
> > Added implementation for INTERNET_OPTION_VERSION
> >  Added implementation for INTERNET_OPTION_USER_AGENT
> >  Fixed behavior for INTERNET_OPTION_HTTP_VERSION
> >  Added implementation for unsupported options
> >  Added some minimalist testcases
>
> You could send your patch billion times, but there is no point in that
> if you don't fix the pointed out problems.
>
> --
> Dmitry.

[wininet]add implementation of few more options - try5

[Juan Lang]

Hi Vijay,
> You told me to cleanup if the connection fails, i could not understand
> how to clean up.

(snip)
> Please suggest me how to improve the tests, i have removed the ok and
> the cruft for if(hurl == 0x0)

That's all I wanted :)  Thanks for taking the time to improve your tests.
> Could you please be online on irc to discuss this

Been busy lately.  I like email for patch suggestions though, because
maybe wannabe wine hackers can learn from the feedback.  I still don't get
'em right the first time 'round.

--Juan

__________________________________ 
Yahoo! FareChase: Search multiple travel sites in one click.
http://farechase.yahoo.com

[wininet]add implementation of few more options - try5

[Alexandre Julliard]

Vijay Kiran Kamuju  writes:
> Dimitry:
> I will try a zillion times, to make my patches get thru ;) :P

The more you send it, the less likely it is to get through. When I see
the same patch more than 3 times I just stop looking at it, as it
clearly indicates that the patch is not ready to go in. You should
stop sending it, split it in smaller chunks, and take the time to get
it right before you resubmit.