Re: [PATCH 4/4] mshtml: Added support for target attribute in submit function implementation.

[Qian Hong]

Hi Jacek,

+
+    hres = get_frame_by_name(top_window, target, TRUE, &ret_window);
+    if(FAILED(hres) || !window) {
+        *use_new_window = TRUE;
+       return NULL;
+    }

Is there a typo here? Is "!window" suppose to be "!ret_window"?

Thanks for the work!

[PATCH 4/4] mshtml: Added support for target attribute in submit function implementation.

[Jacek Caban]

On 03/13/14 14:35, Qian Hong wrote:
> Hi Jacek,
> -
> - hres = get_frame_by_name(top_window, target, TRUE, &ret_window);
> - if(FAILED(hres) || !window) {
> -
>    *use_new_window = TRUE;
> -
>   return NULL;
> - }
>
> Is there a typo here? Is "!window" suppose to be "!ret_window"?
>
> Thanks for the work!

Good catch.

Thanks,
Jacek