kernel32/tests: GetVolumeInformationA X: succeeds iff drive's default dir is root. (try 2)

Hi,

what happened to this patch? It's still marked new.
Is the discovery too surprising?
(Maybe it's the wrong time to ask with AJ still on vacation)
Is it not robust enough (lacking testing with network drives)?

It explains bugs #20887 and #23355.
It may explain intermittent failures in test.winehq/kernel/volume.ok,
 as success depends on where the test was launched from.
> Tests pass on w95,w98,w2k,xp,7.

I forgot to add "without skipping the one relevant section",
 i.e. when started from another drive than C:

Of course I invite people here to also perform the test on native.

Regards,
 Jörg Höhle

[Vitaliy Margolen]

On 08/11/2010 05:03 AM, [e-mail] wrote:
> Hi,
>
> what happened to this patch? It's still marked new.
> Is the discovery too surprising?
> (Maybe it's the wrong time to ask with AJ still on vacation)

According to this: http://www.winehq.org/pipermail/wine-devel/2010-August/085802.html
you won't see any commits until Aug 16 at best.

Vitaliy.

Hi,

please consider that patch, submitted on the 3rd of August, for inclusion.
Tests pass on native w95,w98,w2k,xp,7.

Greg Geldorp went into the extra effort to instrument
the testbot machines (NT upto 7, not win9X)
http://www.winehq.org/pipermail/wine-devel/2010-August/085919.html
with a second drive to validate my new tests, avoiding the
volume.c:345: Tests skipped: Please re-run from another device than C:
of a normal testbot run, such that the GetVolumeInformation tests
are not skipped when started from drive E:
> In short: everything passes.

Thank you,
 Jörg Höhle