Re: [PATCH 1/3] wined3d: Relax depth blit requirements

[Henri Verbeet]

On 9 December 2011 12:54, Stefan Dösinger  wrote:
> This fixes bug 10636.

A proper commit message would be a good start.
> - BOOL                          in_scene;

A test to show that this is actually needed for d3d9 wouldn't hurt.
The condition in wined3d is there because it was already there when we
actually implemented depth blits, but it's probably a leftover from
your original ddraw code or something.

[PATCH 1/3] wined3d: Relax depth blit requirements

[Stefan Dösinger]

2011/12/9 Henri Verbeet
> On 9 December 2011 12:54, Stefan Dösinger  wrote:
> > This fixes bug 10636.
>
> A proper commit message would be a good start.
> > - BOOL                          in_scene;
>
> A test to show that this is actually needed for d3d9 wouldn't hurt.
> The condition in wined3d is there because it was already there when we
> actually implemented depth blits, but it's probably a leftover from
> your original ddraw code or something.

dlls/d3d9/tests/device.c, test_scene(), line 1491

[PATCH 1/3] wined3d: Relax depth blit requirements

[Henri Verbeet]

On 9 December 2011 13:45, Stefan Dösinger  wrote:
> dlls/d3d9/tests/device.c, test_scene(), line 1491

Ok.