Re: Dylan Smith : richedit: Added missing DestroyWindow in a test.

[James Hawkins]

On Tue, Jul 1, 2008 at 8:27 AM, Alexandre Julliard  wrote:
> Module: wine
> Branch: master
> Commit: 2a139746cc631f4ec291a89b4556af17266ce8c0
> URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2a139746cc631f4ec291a89b45...
>
> Author: Dylan Smith 
> Date:   Sat Jun 28 03:00:46 2008 -0400
>
> richedit: Added missing DestroyWindow in a test.

This commit is causing ~350 failures on all platforms.  Please send in
a fix or a revert patch.

Dylan Smith : richedit: Added missing DestroyWindow in a test.

[Dylan Smith]

On Tue, Jul 1, 2008 at 1:24 PM, James Hawkins  wrote:
> This commit is causing ~350 failures on all platforms.  Please send in
> a fix or a revert patch.

Oh, crap.  You are right, I must have only tested this on Windows with
further patches applied that fix this problem.  There are some
problems in these tests with sending keyboard events, but they don't
always seem to show themselves.  I am not sure what the conditions are
that result in these causing tests to fail, but I guess this someone
is one of them.

I guess I should revert this patch, and add change to another patch
which fixes the issue.

Dylan Smith : richedit: Added missing DestroyWindow in a test.

[Dylan Smith]

On Wed, Jul 2, 2008 at 12:52 AM, Dylan Smith  wrote:
> On Tue, Jul 1, 2008 at 1:24 PM, James Hawkins  wrote:
> > This commit is causing ~350 failures on all platforms.  Please send in
> > a fix or a revert patch.
>
> Oh, crap.  You are right, I must have only tested this on Windows with
> further patches applied that fix this problem.  There are some
> problems in these tests with sending keyboard events, but they don't
> always seem to show themselves.  I am not sure what the conditions are
> that result in these causing tests to fail, but I guess this someone
> is one of them.
>
> I guess I should revert this patch, and add change to another patch
> which fixes the issue.

Sorry for posting again, but I just noticed that I already sent the
patch that fixes the tests, and you suggested either _fix_ or revert
the patch.  Well, could you try applying the patch from
http://www.winehq.org/pipermail/wine-patches/2008-June/056829.html and
see if it fixes this problem?  I tested it in Windows XP, and in Wine,
and in Wine with valgrind.

Dylan Smith : richedit: Added missing DestroyWindow in a test.

[Alexandre Julliard]

"Dylan Smith"  writes:
> Sorry for posting again, but I just noticed that I already sent the
> patch that fixes the tests, and you suggested either _fix_ or revert
> the patch.  Well, could you try applying the patch from
> http://www.winehq.org/pipermail/wine-patches/2008-June/056829.html and
> see if it fixes this problem?  I tested it in Windows XP, and in Wine,
> and in Wine with valgrind.

The patch doesn't apply cleanly, please resend it.