Hi Zhenbo,
On 07/29/14 11:08, Zhenbo Li wrote:
To avoid affecting other tests, I squashed the tests for insertRow / deleteRow.
It would be interesting that the table not only contains given row, but also it is in the right place. For that I'd suggest to have test_table_rows_length, to test that the size changed, and another helper that would check if given row has expected id (or that a row with given id is in the right place).
Cheers, Jacek
2014-08-14 18:32 GMT+08:00 Jacek Caban jacek@codeweavers.com:
It would be interesting that the table not only contains given row, but also it is in the right place. For that I'd suggest to have test_table_rows_length, to test that the size changed, and another helper that would check if given row has expected id (or that a row with given id is in the right place).
Thanks. I'll add these two helpers. I still have this question: can I squash the tests?