Hi,
I have attached to http://bugs.winehq.org/show_bug.cgi?id=15915#c3 ("Cinepak reportedly not installed") the skeleton of a test that wine fails but win2k passes.
I could turn this into a format that git and wine-patches understands, if I knew the answer to these questions:
o Is it "right" to add compatibility tests that wine is known to fail now (people are already complaining that a wine build does not pass all tests), or are the tests considered more like regression aids and should be added only when they succeed for the first time?
o What directory to add this test specific to vfw32 (or rather iccvid) ? winmm seems to test sound only, although in principle, it could be there as well.
o Which files to change (beside Makefile.in and testlist.c) so that the patch builds and becomes fully integrated into the wine source tree if it were located in a new file, instead of e.g. being added to tests/mmio.c?
Thank you, Jörg Höhle
Am Freitag, den 12.12.2008, 17:10 +0100 schrieb Hoehle, Joerg-Cyril:
I have attached to http://bugs.winehq.org/show_bug.cgi?id=15915#c3 ("Cinepak reportedly not installed") the skeleton of a test that wine fails but win2k passes.
Nice work, thank you. Tests like this do help Wine development.
o Is it "right" to add compatibility tests that wine is known to fail now (people are already complaining that a wine build does not pass all tests), or are the tests considered more like regression aids and should be added only when they succeed for the first time?
It is definitely right to add such a test. But you have to mark it todo_wine. In that case, "make test" will expect that the test fails and complain if it does *not* fail.
o What directory to add this test specific to vfw32 (or rather iccvid) ? winmm seems to test sound only, although in principle, it could be there as well.
I would put it into msvfw32/tests. You would have to create it.
o Which files to change (beside Makefile.in and testlist.c) so that the patch builds and becomes fully integrated into the wine source tree if it were located in a new file, instead of e.g. being added to tests/mmio.c?
Just change Makefile.in, testlist.c is automatically generated. If you add a new tests dir, you need to run tools/make_makefiles in the top level directory of your wine sourcecode. If your wine sourcecode is a git repository, make_makefiles only considers Makefile.in files already added to the git index, so call git-add before make_makefiles. If you don't use git, make_makefiles scans all directories for Makefile.in to find about buildable directories.
Thank you, Jörg Höhle
You're welcome, Michael Karcher
-
Hoehle, Joerg-Cyril -
Michael Karcher