tests

[Ivan Leo Puoti]

I've run tests twice, once with winrash and once manually, on windows nt 4.0
The results are here
http://test.winehq.com/data/200501131000/#NT%204
interestingly some tests that fail or timeout when run from winrash, 
work when
run manually.
Is there a way this could be fixed, or should we at least somehow mark tests
that give different results when run with winrash or manually?

Ivan.

[Jakob Eriksson]

Ivan Leo Puoti wrote:
> I've run tests twice, once with winrash and once manually, on windows 
> nt 4.0
> The results are here
> http://test.winehq.com/data/200501131000/#NT%204
> interestingly some tests that fail or timeout when run from winrash, 
> work when
> run manually.
> Is there a way this could be fixed, or should we at least somehow mark 
> tests
> that give different results when run with winrash or manually?
>
> Ivan.

There already is a flag for that in the report, but it is not used by the
web scripts.

regards,
Jakob

[Ferenc Wagner]

Ivan Leo Puoti  writes:
> I've run tests twice, once with winrash and once manually, on windows nt 4.0
> http://test.winehq.com/data/200501131000/#NT%204
> interestingly some tests that fail or timeout when run from winrash,
> work when
> run manually.
> Is there a way this could be fixed, or should we at least somehow mark tests
> that give different results when run with winrash or manually?

Do you mean that the tagless report was generated by a
manual run while the one with the IvanLeo tag was run by
winrash?  That's strange, since the blue strip should only
be present when bRunningOnVisibleDesktop is true in the test
headers.  And it's true in both cases.  Here is the origin
of that flag (from winetest/main.c)

static int running_on_visible_desktop ()
{
    return (GetWindowLongA (GetDesktopWindow (), GWL_STYLE) & WS_VISIBLE != 0);
}

Seems like it doesn't work properly.  Can you perhaps do
some crosschecks?  I'll also look into this later today.

[Ivan Leo Puoti]

> Do you mean that the tagless report was generated by a
> manual run while the one with the IvanLeo tag was run by
> winrash?

Yes, those reports were both generated from the same winetest binary.
I'm not sure of what you mean by crosschecks, but I'll do whatever can help,
just let me know what I should do.

Ivan.

[Ferenc Wagner]

Ivan Leo Puoti  writes:
> > Do you mean that the tagless report was generated by a
> > manual run while the one with the IvanLeo tag was run by
> > winrash?
>
> Yes, those reports were both generated from the same
> winetest binary.  I'm not sure of what you mean by
> crosschecks, but I'll do whatever can help, just let me
> know what I should do.

Well, you could find out why the quoted code snippet doesn't
work on NT, and possibly suggest a better test...  It was
recommended by Dimitry, btw. (cc'd)

[Ivan Leo Puoti]

> Well, you could find out why the quoted code snippet doesn't
> work on NT, and possibly suggest a better test...  It was
> recommended by Dimitry, btw. (cc'd)

I don't think I'll have time to do that any time soon :-(

Ivan.