Hello Austin,
Austin English wrote:
There were no test results on winehq today. Seems everyone's exceeding 1.5. Guess some new tests today have a lot of output...
wouldn't it make more sense to have a global variable 'max_filesize' instead of duplicating the magic constants all over the place?
diff --git a/programs/winetest/send.c b/programs/winetest/send.c index 11c9f33..9fc4b81 100644 --- a/programs/winetest/send.c +++ b/programs/winetest/send.c @@ -155,11 +155,11 @@ send_file_direct (const char *name) goto abort1; } filesize = GetFileSize( file, NULL );
- if (filesize > 1.5*1024*1024) {
- if (filesize > 1.75*1024*1024) { report (R_WARNING,
"File too big (%.1f MB > 1.5 MB); submitting partial report.",
"File too big (%.1f MB > 1.75 MB); submitting partial report.", filesize/1024.0/1024);
filesize = (DWORD) 1.5*1024*1024;
filesize = (DWORD) 1.75*1024*1024;
}
report (R_STATUS, "Sending header");
@@ -298,11 +298,11 @@ send_file_wininet (const char *name) }
filesize = GetFileSize( file, NULL );
- if (filesize > 1.5*1024*1024) {
- if (filesize > 1.75*1024*1024) { report (R_WARNING,
"File too big (%.1f MB > 1.5 MB); submitting partial report.",
"File too big (%.1f MB > 1.75 MB); submitting partial report.", filesize/1024.0/1024);
filesize = 1.5*1024*1024;
filesize = 1.75*1024*1024;
}
report (R_STATUS, "Opening HTTP connection to " SERVER_NAME);
bye michael