Thomas Weidenmueller wrote:
I'm however not sure about the changes in include/wine/port.h and include/config.h so please adjust or correct them so it builds correctly.
If you don't build and test your patches against Wine, then don't submit patches.
If you're trying to fix Reactos, then why don't you just fix your own headers? Dmitry already pointed out that you can easily add some #define's or inline functions to achieve what you want. That seems like a better idea than submitting untested patches to wine-patches and hoping we're going to fix your problems for you.
Mike
Mike McCormack wrote:
If you don't build and test your patches against Wine, then don't submit patches.
To my understanding it should build, but I unfortunately don't know what each single build environment in the *nix world expects.
If you're trying to fix Reactos, then why don't you just fix your own headers? Dmitry already pointed out that you can easily add some #define's or inline functions to achieve what you want. That seems like a better idea than submitting untested patches to wine-patches and hoping we're going to fix your problems for you.
My attempt was to impove code sharing between both projects, and this is _exactly_ what Dmitry suggested. I'm not paid for doing this so if you don't even want to give it the slightest chance then I don't care at all, at least I would've helped out merging a not-101% perfect patch. Again, this doesn't fix reactos at all (not that it changed anything other than dependencies to libunicode), it rather fixes wine. If you trash it right now, I honestly don't care, then someone else can do it - or not...
Best Regards, Thomas
Thomas Weidenmueller wrote:
My attempt was to impove code sharing between both projects, and this is _exactly_ what Dmitry suggested.
My understanding was that Dmitry suggested you modify your headers, not ours.
I'm not paid for doing this so if you don't even want to give it the slightest chance then I don't care at all, at least I would've helped out merging a not-101% perfect patch. Again, this doesn't fix reactos at all (not that it changed anything other than dependencies to libunicode), it rather fixes wine. If you trash it right now, I honestly don't care, then someone else can do it - or not...
If you want to get your patches accepted, you need to test them, whether you're paid to do it or not. For example, where is the following defined?
+/* Define to 1 if you have the `strtoul' function. */ +#undef HAVE_STRTOUL
Mike
"Mike McCormack" mike@codeweavers.com wrote:
My attempt was to impove code sharing between both projects, and this is _exactly_ what Dmitry suggested.
My understanding was that Dmitry suggested you modify your headers, not ours.
Thomas and Filip Navara mailed me privately and I suggested to resend the patch without strlenW/wcslen stuff since it looks very reasonable. If Alexandre will not accept the latest version of the patch due to some cosmetic requirement I'll clean it up and resubmit on my own.
-
Dmitry Timoshkov -
Mike McCormack -
Thomas Weidenmueller