Hi Colin, your change http://source.winehq.org/git/wine.git/?a=commitdiff;h=c2c1a55f1c08f35ae02b81... seems to have triggered some valgrind warnings, http://kegel.com/wine/valgrind/logs/2008-07-31-07.46/vg-kernel32_codepage-di... e.g.
+ Use of uninitialised value of size 4 + at wcstombs_sbcs (wctomb.c:186) + by wine_cp_wcstombs (wctomb.c:457) + by WideCharToMultiByte (locale.c:1936) + by test_string_conversion (codepage.c:288) + by func_codepage (codepage.c:351) + by run_test (test.h:488) + by main (test.h:537) + Uninitialised value was created by a stack allocation + at test_string_conversion (codepage.c:216)
+ Use of uninitialised value of size 4 + at wcstombs_sbcs_slow (wctomb.c:246) + by wine_cp_wcstombs (wctomb.c:453) + by WideCharToMultiByte (locale.c:1936) + by test_string_conversion (codepage.c:288) + by func_codepage (codepage.c:352) + by run_test (test.h:488) + by main (test.h:537) + Uninitialised value was created by a stack allocation + at test_string_conversion (codepage.c:216)
Could you have a look?
Dan Kegel wrote:
your change [...] seems to have triggered some valgrind warnings,
Thanks for providing the valgrind output!
Indeed, I was passing a wrong length to a WideCharToMultiByte call, which led to the use of uninitialized stack memory. Fixed here: http://www.winehq.org/pipermail/wine-patches/2008-July/058951.html
Best regards,
Colin
-
Colin Finck -
Dan Kegel