-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi,
Looks good to me. I have asked Henri to have a look. Jacek says they're OK too. I also verified the patches build OK. Thanks again for your work and patience! I'd say give Henri a workday or two to check them against the SDK headers and send the remaining 3 once the first 3 patches are in.
There's one obstacle I ran into:
Am 2015-02-13 um 14:06 schrieb Martell Malone:
- Copyright 2010 Rico Schüller
- Copyright 2013 Austin English
- Copyright 2015 Martell Malone
Fun stuff. There's something about the ü in Rico Schüller's name that breaks git am:
fatal: cannot convert from y to UTF-8
But Jacek says downloading from http://source.winehq.org/patches/data/109106 and applying works, so it's probably nothing you have to worry about.
Cheers, Stefan
On 02/13/2015 02:44 PM, Stefan Dösinger wrote:
Hi,
Looks good to me. I have asked Henri to have a look. Jacek says they're OK too. I also verified the patches build OK. Thanks again for your work and patience! I'd say give Henri a workday or two to check them against the SDK headers and send the remaining 3 once the first 3 patches are in.
There's one obstacle I ran into:
Am 2015-02-13 um 14:06 schrieb Martell Malone:
- Copyright 2010 Rico Schüller
- Copyright 2013 Austin English
- Copyright 2015 Martell Malone
Fun stuff. There's something about the ü in Rico Schüller's name that breaks git am:
fatal: cannot convert from y to UTF-8
The encoding is wrong in the email: Content-Type: text/plain; charset=y Content-Transfer-Encoding: 8bit
Setting the charset to utf-8 makes it work with git am.
bye michael
But Jacek says downloading from http://source.winehq.org/patches/data/109106 and applying works, so it's probably nothing you have to worry about.
Only because the rest is stripped away and just the pure patch is there.
bye michael
fatal: cannot convert from y to UTF-8
When I done the git send email it asked did I want to use UTF-8 which I said "y" to. Maybe it is an issue with gmail re-encoding it somehow. I will have to get a real email address at some point :)
On Fri, Feb 13, 2015 at 1:54 PM, Michael Stefaniuc mstefani@redhat.com wrote:
On 02/13/2015 02:44 PM, Stefan Dösinger wrote:
Hi,
Looks good to me. I have asked Henri to have a look. Jacek says they're OK too. I also verified the patches build OK. Thanks again for your work and patience! I'd say give Henri a workday or two to check them against the SDK headers and send the remaining 3 once the first 3 patches are in.
There's one obstacle I ran into:
Am 2015-02-13 um 14:06 schrieb Martell Malone:
- Copyright 2010 Rico Schüller
- Copyright 2013 Austin English
- Copyright 2015 Martell Malone
Fun stuff. There's something about the ü in Rico Schüller's name that breaks git am:
fatal: cannot convert from y to UTF-8
The encoding is wrong in the email: Content-Type: text/plain; charset=y Content-Transfer-Encoding: 8bit
Setting the charset to utf-8 makes it work with git am.
bye michael
But Jacek says downloading from http://source.winehq.org/patches/data/109106 and applying works, so it's probably nothing you have to worry about.
Only because the rest is stripped away and just the pure patch is there.
bye michael
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-02-13 um 15:11 schrieb Martell Malone:
When I done the git send email it asked did I want to use UTF-8 which I said "y" to.
Yeah, I think that's what happened. The prompt did not ask you a yes or no question. You could e.g. have put ISO8859-8 there. To use the suggested default just press enter.
You could consider filing a git bug about a user interface gotcha that could be fixed :-) .
Someone has asked this in the past it seems http://www.spinics.net/lists/git/msg245469.html http://comments.gmane.org/gmane.comp.version-control.git/263349
It is a git bug as you said. y yes etc should all result in the default. Anyway we will wait for henri's input on the 3 patches :)
On Fri, Feb 13, 2015 at 3:55 PM, Stefan Dösinger stefandoesinger@gmail.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-02-13 um 15:11 schrieb Martell Malone:
When I done the git send email it asked did I want to use UTF-8 which I said "y" to.
Yeah, I think that's what happened. The prompt did not ask you a yes or no question. You could e.g. have put ISO8859-8 there. To use the suggested default just press enter.
You could consider filing a git bug about a user interface gotcha that could be fixed :-) . -----BEGIN PGP SIGNATURE----- Version: GnuPG v2
iQIcBAEBAgAGBQJU3h6JAAoJEN0/YqbEcdMwb7kP/iCW6Vso2p4GU4yMZb2jsAvH ARiHPN9E3FhwzBTNaXQixeXPcPxb30t6t5ReKqXk86dw0m95cK5spnvyJOnfiJks 9eh02dKTwmEqO9UsmGbzGD0BqoCqNkXy2vOa9DJiBBl5g7q2RmWGUfIbDhJsh4CB MdQBXloz5w1QRrYhKRUigwxxXFJLzGUVmZ74dGJJeqgVIKGLuhqZNIxUVa3QiqAw S4RxQBpNnP5f1cPPHiGLNOsgBtdibcZrRcYn9fgJ8ekehsfXh7qraM/SDPD5Agzo rGJZ9tni3EM/A7Ct06y6XVtPgBbW8xkbkL9+p2Zc4nz96NviChHwNnz8NikhWF8y viP8wiI9ZTZGR9kxwQOjPfgEr3hnJylA2/Bv0zSOPiOXpuQczSkp8Dzr/sIWmdl8 RWtwELQejhLzYPWZzg8ZWRugVqztIscTEqTld8yaQxx8wPsG5P40EzpNW8flIln3 GuhKDztNh/7cG/M42cGyC7RAXzg4XEZ9OCpZ2pUrue1Sr5UaQzmpew/n2LyZ1R0y lCR6QWyKTPZ1hqlxLCxTsxyMAZG7RzN3VTG+Iy+6SkLM2Jxh/Yc3YMkwRZ8hufhM lWRzrh/qsH/B3VdaZCqYzJuta+mPofCX30TAHMjYqarVl8osQSSF4ZHD0DZx7JRM PQZfZ7e/UhE5T1yGkoVC =OiaT -----END PGP SIGNATURE-----
ping.
Is there any hold up on this or is it good to merge?
On Fri, Feb 13, 2015 at 7:18 PM, Martell Malone martellmalone@gmail.com wrote:
Someone has asked this in the past it seems http://www.spinics.net/lists/git/msg245469.html http://comments.gmane.org/gmane.comp.version-control.git/263349
It is a git bug as you said. y yes etc should all result in the default. Anyway we will wait for henri's input on the 3 patches :)
On Fri, Feb 13, 2015 at 3:55 PM, Stefan Dösinger < stefandoesinger@gmail.com> wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-02-13 um 15:11 schrieb Martell Malone:
When I done the git send email it asked did I want to use UTF-8 which I said "y" to.
Yeah, I think that's what happened. The prompt did not ask you a yes or no question. You could e.g. have put ISO8859-8 there. To use the suggested default just press enter.
You could consider filing a git bug about a user interface gotcha that could be fixed :-) . -----BEGIN PGP SIGNATURE----- Version: GnuPG v2
iQIcBAEBAgAGBQJU3h6JAAoJEN0/YqbEcdMwb7kP/iCW6Vso2p4GU4yMZb2jsAvH ARiHPN9E3FhwzBTNaXQixeXPcPxb30t6t5ReKqXk86dw0m95cK5spnvyJOnfiJks 9eh02dKTwmEqO9UsmGbzGD0BqoCqNkXy2vOa9DJiBBl5g7q2RmWGUfIbDhJsh4CB MdQBXloz5w1QRrYhKRUigwxxXFJLzGUVmZ74dGJJeqgVIKGLuhqZNIxUVa3QiqAw S4RxQBpNnP5f1cPPHiGLNOsgBtdibcZrRcYn9fgJ8ekehsfXh7qraM/SDPD5Agzo rGJZ9tni3EM/A7Ct06y6XVtPgBbW8xkbkL9+p2Zc4nz96NviChHwNnz8NikhWF8y viP8wiI9ZTZGR9kxwQOjPfgEr3hnJylA2/Bv0zSOPiOXpuQczSkp8Dzr/sIWmdl8 RWtwELQejhLzYPWZzg8ZWRugVqztIscTEqTld8yaQxx8wPsG5P40EzpNW8flIln3 GuhKDztNh/7cG/M42cGyC7RAXzg4XEZ9OCpZ2pUrue1Sr5UaQzmpew/n2LyZ1R0y lCR6QWyKTPZ1hqlxLCxTsxyMAZG7RzN3VTG+Iy+6SkLM2Jxh/Yc3YMkwRZ8hufhM lWRzrh/qsH/B3VdaZCqYzJuta+mPofCX30TAHMjYqarVl8osQSSF4ZHD0DZx7JRM PQZfZ7e/UhE5T1yGkoVC =OiaT -----END PGP SIGNATURE-----
-
Martell Malone -
Michael Stefaniuc -
Stefan Dösinger