Re: msi: Write-strings warnings fix

[Mike McCormack]

Andrew Talbot wrote:
> MSI{Get|Set}FeatureState(), MSI{Get|Set}ComponentState() and
> MSI{Get|Set}Property() have appropriate const string arguments in the SDK.

Which version of the Windows SDK is that?
> -UINT WINAPI MsiGetFeatureStateA(MSIHANDLE hInstall, LPSTR szFeature,
> +UINT WINAPI MsiGetFeatureStateA(MSIHANDLE hInstall, LPCSTR szFeature,
>                    INSTALLSTATE *piInstalled, INSTALLSTATE *piAction)

According to my version of the Windows SDK, these changes are wrong.

Mike

msi: Write-strings warnings fix

[Dmitry Timoshkov]

"Mike McCormack"  wrote:
> Andrew Talbot wrote:
> > MSI{Get|Set}FeatureState(), MSI{Get|Set}ComponentState() and
> > MSI{Get|Set}Property() have appropriate const string arguments in the SDK.
>
> Which version of the Windows SDK is that?
> > -UINT WINAPI MsiGetFeatureStateA(MSIHANDLE hInstall, LPSTR szFeature,
> > +UINT WINAPI MsiGetFeatureStateA(MSIHANDLE hInstall, LPCSTR szFeature,
> >                    INSTALLSTATE *piInstalled, INSTALLSTATE *piAction)
>
> According to my version of the Windows SDK, these changes are wrong.

My copy of Windows Server 2003 SP1 SDK confirms Andrew's findings.

msi: Write-strings warnings fix

[Andrew Talbot]

Mike McCormack wrote:
> Which version of the Windows SDK is that?
> > -UINT WINAPI MsiGetFeatureStateA(MSIHANDLE hInstall, LPSTR szFeature,
> > +UINT WINAPI MsiGetFeatureStateA(MSIHANDLE hInstall, LPCSTR szFeature,
> >                    INSTALLSTATE *piInstalled, INSTALLSTATE *piAction)
>
> According to my version of the Windows SDK, these changes are wrong.

I look the functions up on http://windowssdk.msdn.microsoft.com/.
Specifically, I used the data at
http://windowssdk.msdn.microsoft.com/en-us/library/ms702868.aspx for these
database functions.

-- Andy.