[PATCH] server: Use all group attributes in create_token.

[Vijay Kiran Kamuju]

From: Sebastian Lackner

From: Sebastian Lackner 
Signed-off-by: Vijay Kiran Kamuju 
---
 server/token.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/server/token.c b/server/token.c
index e0f28c6da6..550018cb17 100644
--- a/server/token.c
+++ b/server/token.c
@@ -584,13 +584,13 @@ static struct token *create_token( unsigned primary, const SID *user,
                 return NULL;
             }
             memcpy( &group->sid, groups[i].Sid, security_sid_len( groups[i].Sid ));
-            group->enabled = TRUE;
-            group->def = TRUE;
-            group->logon = (groups[i].Attributes & SE_GROUP_LOGON_ID) != 0;
             group->mandatory = (groups[i].Attributes & SE_GROUP_MANDATORY) != 0;
-            group->owner = (groups[i].Attributes & SE_GROUP_OWNER) != 0;
-            group->resource = FALSE;
-            group->deny_only = FALSE;
+            group->def       = (groups[i].Attributes & SE_GROUP_ENABLED_BY_DEFAULT) != 0;
+            group->enabled   = (groups[i].Attributes & SE_GROUP_ENABLED) != 0;
+            group->owner     = (groups[i].Attributes & SE_GROUP_OWNER) != 0;
+            group->deny_only = (groups[i].Attributes & SE_GROUP_USE_FOR_DENY_ONLY) != 0;
+            group->logon     = (groups[i].Attributes & SE_GROUP_LOGON_ID) != 0;
+            group->resource  = (groups[i].Attributes & SE_GROUP_RESOURCE) != 0;
             list_add_tail( &token->groups, &group->entry );
             /* Use first owner capable group as owner and primary group */
             if (!token->primary_group && group->owner)
@@ -1504,8 +1504,8 @@ DECL_HANDLER(get_token_groups)
                     if (group->enabled) *attr_ptr |= SE_GROUP_ENABLED;
                     if (group->owner) *attr_ptr |= SE_GROUP_OWNER;
                     if (group->deny_only) *attr_ptr |= SE_GROUP_USE_FOR_DENY_ONLY;
-                    if (group->resource) *attr_ptr |= SE_GROUP_RESOURCE;
                     if (group->logon) *attr_ptr |= SE_GROUP_LOGON_ID;
+                    if (group->resource) *attr_ptr |= SE_GROUP_RESOURCE;

memcpy(sid_ptr, &group->sid, security_sid_len( &group->sid ));

[Alexandre Julliard]

Vijay Kiran Kamuju  writes:
> @@ -584,13 +584,13 @@ static struct token *create_token( unsigned primary, const SID *user,
>                  return NULL;
>              }
>              memcpy( &group->sid, groups[i].Sid, security_sid_len( groups[i].Sid ));
> -
>        group->enabled = TRUE;
> -
>        group->def = TRUE;
> -
>        group->logon = (groups[i].Attributes & SE_GROUP_LOGON_ID) != 0;
>        group->mandatory = (groups[i].Attributes & SE_GROUP_MANDATORY) != 0;
> -
>        group->owner = (groups[i].Attributes & SE_GROUP_OWNER) != 0;
> -
>        group->resource = FALSE;
> -
>        group->deny_only = FALSE;
> -
>        group->def       = (groups[i].Attributes & SE_GROUP_ENABLED_BY_DEFAULT) != 0;
> -
>        group->enabled   = (groups[i].Attributes & SE_GROUP_ENABLED) != 0;
> -
>        group->owner     = (groups[i].Attributes & SE_GROUP_OWNER) != 0;
> -
>        group->deny_only = (groups[i].Attributes & SE_GROUP_USE_FOR_DENY_ONLY) != 0;
> -
>        group->logon     = (groups[i].Attributes & SE_GROUP_LOGON_ID) != 0;
> -
>        group->resource  = (groups[i].Attributes & SE_GROUP_RESOURCE) != 0;

I'd suggest storing the attributes bitmask directly instead.