Re: feedback? wined3d: Implement r5g6b5 to x8r8g8b8 function

[Henri Verbeet]

2008/12/27 Stefan Dösinger :
> > anything wrong with the patch
> > wined3d: Implement r5g6b5 to x8r8g8b8 function
> > David
>
> Probably alexandre wanted an ok from me. Can you resend the patch?

No, the patch was flawed. The author knows about this, and posted an
improved patch to bugzilla (bug 18011). The improved patch is mostly
ok, but doesn't round correctly, and could be made a bit faster by
using a lookup table instead of recalculating everything all the time.

feedback? wined3d: Implement r5g6b5 to x8r8g8b8 function

[paulo lesgaz]

In the same idea, what's wrong with the patch:
wined3d: Convert between A8R8G8B8 and X8R8G8B8http://www.winehq.org/pipermail/wine-patches/attachments/20080928/ae239205/a...

It fixes une FIXME in medieval total wars (Henri asked what is fixed by this patch ;) )

David

--- En date de : Ven 26.12.08, Henri Verbeet  a écrit :
De: Henri Verbeet 
Objet: Re: feedback? wined3d: Implement r5g6b5 to x8r8g8b8 function
À: "Stefan Dösinger" 
Cc: [e-mail], "wine" 
Date: Vendredi 26 Décembre 2008, 15h27

2008/12/27 Stefan Dösinger :
> > anything wrong with the patch
> > wined3d: Implement r5g6b5 to x8r8g8b8 function
> > David
>
> Probably alexandre wanted an ok from me. Can you resend the patch?

No, the patch was flawed. The author knows about this, and posted an
improved patch to bugzilla (bug 18011). The improved patch is mostly
ok, but doesn't round correctly, and could be made a bit faster by
using a lookup table instead of recalculating everything all the time.