-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2013-10-15 16:57, schrieb Lasse Rasinen:
- locked_rect->Pitch = map_desc.row_pitch; -
locked_rect->pBits = map_desc.data; + if (SUCCEEDED(hr)) { + locked_rect->Pitch = map_desc.row_pitch; + locked_rect->pBits = map_desc.data; + } else { + locked_rect->Pitch = 0; + locked_rect->pBits = NULL; + }
You can handle this in wined3d/surface.c, wined3d_surface_map. Also, please follow the code style of the existing code. Curly brackets go in their own line.
- locked_rect.pBits = (BYTE *)0xdeadbeef; + hr =
IDirect3DSurface9_LockRect(surface, &locked_rect, NULL, 0); + ok(!SUCCEEDED(hr) && locked_rect.pBits == NULL, "Failed to clear pBits (%p)\n", + locked_rect.pBits);
For the sake of completeness, please also test locked_rect.Pitch and port the test to d3d8. Ddraw already has a test in dsurface.c.
-
Stefan Dösinger