msvcrt printf test failed on NT4,win95

[Thomas Heckel]

Hi Alexander,

I was wondering why your patch b205fd8108eca2fd29705875e53ed852f56a6b6d
"Proberly skip if functions are not available" made test errors on NT4
and Win95 test instead of a skip while it works on newer windows
platforms as expected.

Could this be the case because GetModuleHandle and these failing
platforms are not widechar compatible? So maybe it needs using
GetModuleHandleA?

kind regards
Thomas

[Paul Vriens]

On 06/07/2010 09:04 PM, Thomas Heckel wrote:
> Hi Alexander,
>
> I was wondering why your patch b205fd8108eca2fd29705875e53ed852f56a6b6d
> "Proberly skip if functions are not available" made test errors on NT4
> and Win95 test instead of a skip while it works on newer windows
> platforms as expected.

The problem only looks to be present when run through/via winetest.exe. 
The testbot doesn't show any issues when only the single test is run:

http://testbot.winehq.org/JobDetails.pl?Key=2505

[Alexander Scott-Johns]

Thomas,

On 7 June 2010 20:04, Thomas Heckel  wrote:
> Hi Alexander,
>
> I was wondering why your patch b205fd8108eca2fd29705875e53ed852f56a6b6d
> "Proberly skip if functions are not available" made test errors on NT4
> and Win95 test instead of a skip while it works on newer windows
> platforms as expected.

I have no idea.

I can't see the real difference between tests/printf.c and (say)
tests/locale.c: both use win_skip, but printf.c fails and locale.c
works. Maybe it's the _CRT_NON_CONFORMING_SWPRINTFS define?
> Could this be the case because GetModuleHandle and these failing
> platforms are not widechar compatible? So maybe it needs using
> GetModuleHandleA?

No -- GetModuleHandle expands to GetModuleHandleA here. And I think
nt4 is a Unicode platform anyway.
> kind regards
> Thomas

Best regards,
Alex Scott-Johns

[Alexander Scott-Johns]

On 8 June 2010 00:56, Alexander Scott-Johns
 wrote:
> Thomas,
>
> On 7 June 2010 20:04, Thomas Heckel  wrote:
> > Hi Alexander,
> >
> > I was wondering why your patch b205fd8108eca2fd29705875e53ed852f56a6b6d
> > "Proberly skip if functions are not available" made test errors on NT4
> > and Win95 test instead of a skip while it works on newer windows
> > platforms as expected.
>
> I have no idea.
>
> I can't see the real difference between tests/printf.c and (say)
> tests/locale.c: both use win_skip, but printf.c fails and locale.c
> works. Maybe it's the _CRT_NON_CONFORMING_SWPRINTFS define?

All,

Could someone test the attached patch on Win95 or NT4, please? I want
to see if it makes the tests fail.

Best regards,
Alex Scott-Johns

PS: make crosstest doesn't work for me:

~/wine-git/dlls/msvcrt/tests$ make crosstest
i586-mingw32msvc-gcc -c -I. -I. -I../../../include -I../../../include
-I../../../include/msvcrt -I./.. -DWINE_STRICT_PROTOTYPES
-DWINE_CROSSTEST -I/home/user/include -g -O0 -o locale.cross.o
locale.c
../../../tools/winegcc/winegcc -b i586-mingw32msvc
-B../../../tools/winebuild --sysroot=../../.. --lib-suffix=.cross.a
cpp.cross.o data.cross.o dir.cross.o environ.cross.o file.cross.o
headers.cross.o heap.cross.o locale.cross.o misc.cross.o
printf.cross.o scanf.cross.o signal.cross.o string.cross.o
time.cross.o testlist.cross.o -o msvcrt_crosstest.exe -lkernel32
/usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/bin/ld:
cannot find -lwinecrt0
collect2: ld returned 1 exit status
winegcc: i586-mingw32msvc-gcc failed
make: *** [msvcrt_crosstest.exe] Error 2
~/wine-git/dlls/msvcrt/tests$