--- Alexandre Julliard julliard@winehq.org wrote:
Actually, judging from the pointer values I get on my XP box the buffers seem to be 64 chars long.
Okay, changing patch to match.
Still, I'm not sure why Mozilla feels the need to overwrite them, that doesn't seem right.
No, it doesn't, although their comments explain the motivation: on some versions of Windows NT, the value is incorrectly set for some time zones. Nonetheless the code is doing the wrong thing: it's converting an entire string, e.g. "GMT Standard Time", rather than the time zone portion alone ("GMT").
--Juan
__________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/
Perhaps they are thinking along the lines of the whole string being for example "GMT -06:00 Central Time" ? In which case they wouldnt want to convert just the GMT as it would product the wrong result. Just an outsider's opinion ;-)
Dustin
Juan Lang wrote:
--- Alexandre Julliard julliard@winehq.org wrote:
Actually, judging from the pointer values I get on my XP box the buffers seem to be 64 chars long.
Okay, changing patch to match.
Still, I'm not sure why Mozilla feels the need to overwrite them, that doesn't seem right.
No, it doesn't, although their comments explain the motivation: on some versions of Windows NT, the value is incorrectly set for some time zones. Nonetheless the code is doing the wrong thing: it's converting an entire string, e.g. "GMT Standard Time", rather than the time zone portion alone ("GMT").
--Juan
-
Dustin Navea -
Juan Lang