Re: user32/tests: Add additional test for window station name.

[Sebastian Lackner]

On 25.04.2016 23:25, Sebastian Lackner wrote:
> Signed-off-by: Sebastian Lackner
>
> dlls/user32/tests/winstation.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/dlls/user32/tests/winstation.c b/dlls/user32/tests/winstation.c
> index e49420b..94be4c9 100644
> --- a/dlls/user32/tests/winstation.c
> +++ b/dlls/user32/tests/winstation.c
> @@ -114,6 +114,8 @@ static void test_handles(void)
>      DWORD id, flags, le;
>      ATOM atom;
>      char buffer[20];
> -
>
> DWORD size;
> -
>
> BOOL ret;
>
> /* win stations */
>
> @@ -215,6 +217,12 @@ static void test_handles(void)
>      w2 = CreateWindowStationA( "", 0, WINSTA_ALL_ACCESS, NULL );
>      ok( w2 != 0, "create station failed err %u\n", GetLastError() );
> - memset( buffer, 0, sizeof(buffer) );
> - ret = GetUserObjectInformationA( w2, UOI_NAME, buffer, sizeof(buffer), &size );
> - ok( ret, "GetUserObjectInformationA failed with error %u\n", GetLastError() );
> - todo_wine ok( !memcmp(buffer, "Service-0x0-", 12), "unexpected window station name '%s'\n", buffer );
> - todo_wine ok( buffer[strlen(buffer) - 1] == '$', "unexpected window station name '%s'\n", buffer );
> - SetLastError( 0xdeadbeef );
>    w3 = OpenWindowStationA( "", TRUE, WINSTA_ALL_ACCESS );
>    todo_wine

Before I resend, may I ask why this patch is pending? If its because of the hardcoded "0x0",
I can change that of course. The main point is to show that window stations without a name
get assigned one by the operating system. Applications depend on this when they "manually"
implement window station inheritance (query name and later pass it to CreateProcess).

Regards,
Sebastian

user32/tests: Add additional test for window station name.

[Alexandre Julliard]

Sebastian Lackner  writes:
> Before I resend, may I ask why this patch is pending? If its because of the hardcoded "0x0",
> I can change that of course. The main point is to show that window stations without a name
> get assigned one by the operating system. Applications depend on this when they "manually"
> implement window station inheritance (query name and later pass it to CreateProcess).

Sorry, I wanted to look more into this behavior, but haven't found the
time yet. But the test is fine, I should have applied it.