Re: gdiplus: Use symbolic name of the font style.

[Nikolay Sivov]

On 4/23/2012 17:31, Dmitry Timoshkov wrote:
> dlls/gdiplus/font.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/gdiplus/font.c b/dlls/gdiplus/font.c
> index 169e28f..8157b0a 100644
> --- a/dlls/gdiplus/font.c
> +++ b/dlls/gdiplus/font.c
> @@ -767,7 +767,7 @@ GpStatus WINGDIPAPI GdipGetLineSpacing(GDIPCONST GpFontFamily *family,
>   static INT CALLBACK font_has_style_proc(const LOGFONTW *elf,
>                               const TEXTMETRICW *ntm, DWORD type, LPARAM lParam)
>   {
> - INT fontstyle=0;
> -
>
> INT fontstyle = FontStyleRegular;
>
> if (!ntm) return 1;

Maybe it's better to make it 'enum FontStyle' after all.

gdiplus: Use symbolic name of the font style.

[Dmitry Timoshkov]

Nikolay Sivov  wrote:
> > - INT fontstyle=0;
> > -
> >
> > INT fontstyle = FontStyleRegular;
> >
> > if (!ntm) return 1;
>
> Maybe it's better to make it 'enum FontStyle' after all.

Current version is fine IMO, but feel free to send a patch :)