Re: OLEAUT32: implement OleLoadPictureFile(Ex) and add tests

[Detlef Riekenberg]

On Mi, 2008-11-12 at 23:40 -0800, Jeremy Drake wrote:

I have no Idea about that area, but the unicode API is
not implemented on win9x
(GetTempFileNameW, CreateFileW, DeleteFileW)
> if(!pOleLoadPictureFile || !pOleLoadPictureFileEx)

Are there systems in the Wild that have
OleLoadPictureFile, but are missing OleLoadPictureFile?
In that case, you should use 2 seperate tests.
> skip("Skipping OleLoadPictureFile tests\n");

Think, what you would see in the log before your text:
"filename.c:__LINE__: Tests skipped:"
"Skipping" is redundant and "tests" also.

The usual way would be:
 skip("OleLoadPictureFile not found\n");

When you want to make sure, that we never skip in Wine here,
then use win_skip instead.

OLEAUT32: implement OleLoadPictureFile(Ex) and add tests

[Detlef Riekenberg]

On Fr, 2008-11-14 at 21:17 +0100, Detlef Riekenberg wrote:
> On Mi, 2008-11-12 at 23:40 -0800, Jeremy Drake wrote:
> > if(!pOleLoadPictureFile || !pOleLoadPictureFileEx)
>
> Are there systems in the Wild that have
> OleLoadPictureFile, but are missing OleLoadPictureFile?
> In that case, you should use 2 seperate tests.
> > skip("Skipping OleLoadPictureFile tests\n");
>
> Think, what you would see in the log before your text:
> "filename.c:__LINE__: Tests skipped:"
> "Skipping" is redundant and "tests" also.
>
> The usual way would be:
>  skip("OleLoadPictureFile not found\n");
>
> When you want to make sure, that we never skip in Wine here,
> then use win_skip instead.

Forget that.
I just read the Mail about the disassembly usage.