[PATCH 00/17] Final patches of the audio converter MFT + the color converter MFT.

[Derek Lesho]

I know this is a lot of patches to send at once, but I'm hoping it's reasonable given
1) how similar patches 7-17 are to the audio converter patches.
2) how patches 1-2 were already signed off on, but didn't get applied due to a copyright notice messing up the merge
The reason I didn't split this into two patchsets is that the color converter also relies on gst_buffer_from_mf_sample, provided by patch 3.

With all these plus the two I sent earlier this week, media foundation video in Unreal Engine games works.

Derek Lesho (17):
  winegstreamer: Implement ::SetInputType for audio conversion
    transform.
  winegstreamer: Implement ::SetOutputType for audio conversion
    transform.
  winegstreamer: Implement ::Process(Input/Output) for audio conversion
    transform.
  winegstreamer: Implement ::Get(Input/Output)StreamInfo for audio
    conversion transform.
  winegstreamer: Implement Get*Attributes functions for audio converter
    transform.
  winegstreamer: Implement Get(Input/Output)CurrentType functions for
    audio converter transform.
  winegstreamer: Introduce color conversion transform.
  winegstreamer: Register the color conversion transform.
  winegstreamer: Implement ::GetInputAvailableType for color conversion
    transform.
  winegstreamer: Implement ::SetInputType for color conversion
    transform.
  winegstreamer: Implement ::GetOutputAvailableType for color conversion
    transform.
  winegstreamer: Implement ::SetOutputType for color conversion
    transform.
  winegstreamer: Implement ::Process(Input/Output) for color conversion
    transform.
  winegstreamer: Implement ::ProcessMessage for color conversion MFT.
  winegstreamer: Implement ::Get(Input/Output)StreamInfo for color
    conversion transform.
  winegstreamer: Implement Get*Attributes functions for color converter
    transform.
  winegstreamer: Implement Get(Input/Output)CurrentType functions for
    color converter transform.

dlls/winegstreamer/Makefile.in               |   1 +
 dlls/winegstreamer/audioconvert.c            | 437 ++++++++++-
 dlls/winegstreamer/colorconvert.c            | 778 +++++++++++++++++++
 dlls/winegstreamer/gst_private.h             |   2 +
 dlls/winegstreamer/mfplat.c                  | 106 ++-
 dlls/winegstreamer/winegstreamer_classes.idl |   6 +
 6 files changed, 1309 insertions(+), 21 deletions(-)
 create mode 100644 dlls/winegstreamer/colorconvert.c

[PATCH 01/17] winegstreamer: Implement ::SetInputType for audio conversion transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/audioconvert.c | 77 ++++++++++++++++++++++++++++++-
 1 file changed, 75 insertions(+), 2 deletions(-)

diff --git a/dlls/winegstreamer/audioconvert.c b/dlls/winegstreamer/audioconvert.c
index 9499920347f..8bfd28b1ef2 100644
--- a/dlls/winegstreamer/audioconvert.c
+++ b/dlls/winegstreamer/audioconvert.c
@@ -18,6 +18,7 @@
  */

#include "config.h"
+#include <gst/gst.h>

#include "gst_private.h"

@@ -36,6 +37,8 @@ struct audio_converter
 {
     IMFTransform IMFTransform_iface;
     LONG refcount;
+    IMFMediaType *input_type;
+    CRITICAL_SECTION cs;
 };

static struct audio_converter *impl_audio_converter_from_IMFTransform(IMFTransform *iface)
@@ -79,6 +82,8 @@ static ULONG WINAPI audio_converter_Release(IMFTransform *iface)

if (!refcount)
     {
+        transform->cs.DebugInfo->Spare[0] = 0;
+        DeleteCriticalSection(&transform->cs);
         heap_free(transform);
     }

@@ -270,9 +275,74 @@ fail:

static HRESULT WINAPI audio_converter_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *type, DWORD flags)
 {
-    FIXME("%p, %u, %p, %#x.\n", iface, id, type, flags);
+    GstCaps *input_caps;
+    HRESULT hr;

-    return E_NOTIMPL;
+    struct audio_converter *converter = impl_audio_converter_from_IMFTransform(iface);
+
+    TRACE("%p, %u, %p, %#x.\n", iface, id, type, flags);
+
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    if (type)
+    {
+        GUID major_type, subtype;
+        DWORD unused;
+
+        if (FAILED(IMFMediaType_GetGUID(type, &MF_MT_MAJOR_TYPE, &major_type)))
+            return MF_E_INVALIDTYPE;
+        if (FAILED(IMFMediaType_GetGUID(type, &MF_MT_SUBTYPE, &subtype)))
+            return MF_E_INVALIDTYPE;
+        if (FAILED(IMFMediaType_GetUINT32(type, &MF_MT_AUDIO_SAMPLES_PER_SECOND, &unused)))
+            return MF_E_INVALIDTYPE;
+        if (FAILED(IMFMediaType_GetUINT32(type, &MF_MT_AUDIO_NUM_CHANNELS, &unused)))
+            return MF_E_INVALIDTYPE;
+        if (IsEqualGUID(&subtype, &MFAudioFormat_PCM) && FAILED(IMFMediaType_GetUINT32(type, &MF_MT_AUDIO_BITS_PER_SAMPLE, &unused)))
+            return MF_E_INVALIDTYPE;
+
+        if (!(IsEqualGUID(&major_type, &MFMediaType_Audio)))
+            return MF_E_INVALIDTYPE;
+
+        if (!IsEqualGUID(&subtype, &MFAudioFormat_PCM) && !IsEqualGUID(&subtype, &MFAudioFormat_Float))
+            return MF_E_INVALIDTYPE;
+
+        if (!(input_caps = caps_from_mf_media_type(type)))
+            return MF_E_INVALIDTYPE;
+
+        gst_caps_unref(input_caps);
+    }
+
+    if (flags & MFT_SET_TYPE_TEST_ONLY)
+        return S_OK;
+
+    EnterCriticalSection(&converter->cs);
+
+    hr = S_OK;
+
+    if (type)
+    {
+        if (!converter->input_type)
+            hr = MFCreateMediaType(&converter->input_type);
+
+        if (SUCCEEDED(hr))
+            hr = IMFMediaType_CopyAllItems(type, (IMFAttributes *) converter->input_type);
+
+        if (FAILED(hr))
+        {
+            IMFMediaType_Release(converter->input_type);
+            converter->input_type = NULL;
+        }
+    }
+    else if (converter->input_type)
+    {
+        IMFMediaType_Release(converter->input_type);
+        converter->input_type = NULL;
+    }
+
+    LeaveCriticalSection(&converter->cs);
+
+    return hr;
 }

static HRESULT WINAPI audio_converter_SetOutputType(IMFTransform *iface, DWORD id, IMFMediaType *type, DWORD flags)
@@ -395,6 +465,9 @@ HRESULT audio_converter_create(REFIID riid, void **ret)
     object->IMFTransform_iface.lpVtbl = &audio_converter_vtbl;
     object->refcount = 1;

+    InitializeCriticalSection(&object->cs);
+    object->cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": audio_converter_lock");
+
     *ret = &object->IMFTransform_iface;
     return S_OK;
 }

[PATCH 01/17] winegstreamer: Implement ::SetInputType for audio conversion transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83064

Your paranoid android.

=== debiant (build log) ===

Task: Patch failed to apply

=== debiant (build log) ===

Task: Patch failed to apply

[PATCH 01/17] winegstreamer: Implement ::SetInputType for audio conversion transform.

[Zebediah Figura (she/her)]

Signed-off-by: Zebediah Figura

---

That said, I am only really qualified to review these patches for
general errors, and for usage of GStreamer; it strikes me as a good idea
for the Media Foundation maintainers to also review them, to ensure the
functions are doing what they are supposed to.

[PATCH 02/17] winegstreamer: Implement ::SetOutputType for audio conversion transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/audioconvert.c | 73 ++++++++++++++++++++++++++++++-
 1 file changed, 71 insertions(+), 2 deletions(-)

diff --git a/dlls/winegstreamer/audioconvert.c b/dlls/winegstreamer/audioconvert.c
index 8bfd28b1ef2..7fb0dee99f6 100644
--- a/dlls/winegstreamer/audioconvert.c
+++ b/dlls/winegstreamer/audioconvert.c
@@ -38,6 +38,7 @@ struct audio_converter
     IMFTransform IMFTransform_iface;
     LONG refcount;
     IMFMediaType *input_type;
+    IMFMediaType *output_type;
     CRITICAL_SECTION cs;
 };

@@ -347,9 +348,77 @@ static HRESULT WINAPI audio_converter_SetInputType(IMFTransform *iface, DWORD id

static HRESULT WINAPI audio_converter_SetOutputType(IMFTransform *iface, DWORD id, IMFMediaType *type, DWORD flags)
 {
-    FIXME("%p, %u, %p, %#x.\n", iface, id, type, flags);
+    struct audio_converter *converter = impl_audio_converter_from_IMFTransform(iface);
+    GUID major_type, subtype;
+    GstCaps *output_caps;
+    DWORD unused;
+    HRESULT hr;

-    return E_NOTIMPL;
+    TRACE("%p, %u, %p, %#x.\n", iface, id, type, flags);
+
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    if (!converter->input_type)
+        return MF_E_TRANSFORM_TYPE_NOT_SET;
+
+    if (type)
+    {
+        /* validate the type */
+
+        if (FAILED(IMFMediaType_GetGUID(type, &MF_MT_MAJOR_TYPE, &major_type)))
+            return MF_E_INVALIDTYPE;
+        if (FAILED(IMFMediaType_GetGUID(type, &MF_MT_SUBTYPE, &subtype)))
+            return MF_E_INVALIDTYPE;
+        if (FAILED(IMFMediaType_GetUINT32(type, &MF_MT_AUDIO_NUM_CHANNELS, &unused)))
+            return MF_E_INVALIDTYPE;
+        if (IsEqualGUID(&subtype, &MFAudioFormat_PCM) && FAILED(IMFMediaType_GetUINT32(type, &MF_MT_AUDIO_BITS_PER_SAMPLE, &unused)))
+            return MF_E_INVALIDTYPE;
+        if (FAILED(IMFMediaType_GetUINT32(type, &MF_MT_AUDIO_SAMPLES_PER_SECOND, &unused)))
+            return MF_E_INVALIDTYPE;
+
+        if (!(IsEqualGUID(&major_type, &MFMediaType_Audio)))
+            return MF_E_INVALIDTYPE;
+
+        if (!IsEqualGUID(&subtype, &MFAudioFormat_PCM) && !IsEqualGUID(&subtype, &MFAudioFormat_Float))
+            return MF_E_INVALIDTYPE;
+
+        if (!(output_caps = caps_from_mf_media_type(type)))
+            return MF_E_INVALIDTYPE;
+
+        gst_caps_unref(output_caps);
+    }
+
+    if (flags & MFT_SET_TYPE_TEST_ONLY)
+        return S_OK;
+
+    EnterCriticalSection(&converter->cs);
+
+    hr = S_OK;
+
+    if (type)
+    {
+        if (!converter->output_type)
+            hr = MFCreateMediaType(&converter->output_type);
+
+        if (SUCCEEDED(hr))
+            hr = IMFMediaType_CopyAllItems(type, (IMFAttributes *) converter->output_type);
+
+        if (FAILED(hr))
+        {
+            IMFMediaType_Release(converter->output_type);
+            converter->output_type = NULL;
+        }
+    }
+    else if (converter->output_type)
+    {
+        IMFMediaType_Release(converter->output_type);
+        converter->output_type = NULL;
+    }
+
+    LeaveCriticalSection(&converter->cs);
+
+    return hr;
 }

static HRESULT WINAPI audio_converter_GetInputCurrentType(IMFTransform *iface, DWORD id, IMFMediaType **type)

[PATCH 02/17] winegstreamer: Implement ::SetOutputType for audio conversion transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83065

Your paranoid android.

=== debiant (build log) ===

Task: Patch failed to apply

=== debiant (build log) ===

Task: Patch failed to apply

[PATCH 02/17] winegstreamer: Implement ::SetOutputType for audio conversion transform.

[Zebediah Figura (she/her)]

Signed-off-by: Zebediah Figura

[PATCH 03/17] winegstreamer: Implement ::Process(Input/Output) for audio conversion transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
v1(v6):
  - Move unused hr to later patch.
  - Fix extra parentheses.
  - Place converter declaration more consistently.
---
 dlls/winegstreamer/audioconvert.c | 175 +++++++++++++++++++++++++++++-
 dlls/winegstreamer/gst_private.h  |   1 +
 dlls/winegstreamer/mfplat.c       |  69 ++++++++++++
 3 files changed, 239 insertions(+), 6 deletions(-)

diff --git a/dlls/winegstreamer/audioconvert.c b/dlls/winegstreamer/audioconvert.c
index 7fb0dee99f6..631c57d6d55 100644
--- a/dlls/winegstreamer/audioconvert.c
+++ b/dlls/winegstreamer/audioconvert.c
@@ -40,6 +40,8 @@ struct audio_converter
     IMFMediaType *input_type;
     IMFMediaType *output_type;
     CRITICAL_SECTION cs;
+    BOOL inflight;
+    GstElement *container, *appsrc, *audioconvert, *resampler, *appsink;
 };

static struct audio_converter *impl_audio_converter_from_IMFTransform(IMFTransform *iface)
@@ -85,6 +87,7 @@ static ULONG WINAPI audio_converter_Release(IMFTransform *iface)
     {
         transform->cs.DebugInfo->Spare[0] = 0;
         DeleteCriticalSection(&transform->cs);
+        gst_object_unref(transform->container);
         heap_free(transform);
     }

@@ -311,7 +314,8 @@ static HRESULT WINAPI audio_converter_SetInputType(IMFTransform *iface, DWORD id
         if (!(input_caps = caps_from_mf_media_type(type)))
             return MF_E_INVALIDTYPE;

-        gst_caps_unref(input_caps);
+        if (flags & MFT_SET_TYPE_TEST_ONLY)
+            gst_caps_unref(input_caps);
     }

if (flags & MFT_SET_TYPE_TEST_ONLY)
@@ -320,6 +324,7 @@ static HRESULT WINAPI audio_converter_SetInputType(IMFTransform *iface, DWORD id
     EnterCriticalSection(&converter->cs);

hr = S_OK;
+    gst_element_set_state(converter->container, GST_STATE_READY);

if (type)
     {
@@ -329,6 +334,9 @@ static HRESULT WINAPI audio_converter_SetInputType(IMFTransform *iface, DWORD id
         if (SUCCEEDED(hr))
             hr = IMFMediaType_CopyAllItems(type, (IMFAttributes *) converter->input_type);

+        g_object_set(converter->appsrc, "caps", input_caps, NULL);
+        gst_caps_unref(input_caps);
+
         if (FAILED(hr))
         {
             IMFMediaType_Release(converter->input_type);
@@ -341,6 +349,9 @@ static HRESULT WINAPI audio_converter_SetInputType(IMFTransform *iface, DWORD id
         converter->input_type = NULL;
     }

+    if (converter->input_type && converter->output_type)
+        gst_element_set_state(converter->container, GST_STATE_PLAYING);
+
     LeaveCriticalSection(&converter->cs);

return hr;
@@ -386,7 +397,8 @@ static HRESULT WINAPI audio_converter_SetOutputType(IMFTransform *iface, DWORD i
         if (!(output_caps = caps_from_mf_media_type(type)))
             return MF_E_INVALIDTYPE;

-        gst_caps_unref(output_caps);
+        if (flags & MFT_SET_TYPE_TEST_ONLY)
+            gst_caps_unref(output_caps);
     }

if (flags & MFT_SET_TYPE_TEST_ONLY)
@@ -395,6 +407,7 @@ static HRESULT WINAPI audio_converter_SetOutputType(IMFTransform *iface, DWORD i
     EnterCriticalSection(&converter->cs);

hr = S_OK;
+    gst_element_set_state(converter->container, GST_STATE_READY);

if (type)
     {
@@ -404,6 +417,9 @@ static HRESULT WINAPI audio_converter_SetOutputType(IMFTransform *iface, DWORD i
         if (SUCCEEDED(hr))
             hr = IMFMediaType_CopyAllItems(type, (IMFAttributes *) converter->output_type);

+        g_object_set(converter->appsink, "caps", output_caps, NULL);
+        gst_caps_unref(output_caps);
+
         if (FAILED(hr))
         {
             IMFMediaType_Release(converter->output_type);
@@ -416,6 +432,9 @@ static HRESULT WINAPI audio_converter_SetOutputType(IMFTransform *iface, DWORD i
         converter->output_type = NULL;
     }

+    if (converter->input_type && converter->output_type)
+        gst_element_set_state(converter->container, GST_STATE_PLAYING);
+
     LeaveCriticalSection(&converter->cs);

return hr;
@@ -479,17 +498,102 @@ static HRESULT WINAPI audio_converter_ProcessMessage(IMFTransform *iface, MFT_ME

static HRESULT WINAPI audio_converter_ProcessInput(IMFTransform *iface, DWORD id, IMFSample *sample, DWORD flags)
 {
-    FIXME("%p, %u, %p, %#x.\n", iface, id, sample, flags);
+    GstBuffer *gst_buffer;
+    int ret;

-    return E_NOTIMPL;
+    struct audio_converter *converter = impl_audio_converter_from_IMFTransform(iface);
+
+    TRACE("%p, %u, %p, %#x.\n", iface, id, sample, flags);
+
+    if (flags)
+        WARN("Unsupported flags %#x\n", flags);
+
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    EnterCriticalSection(&converter->cs);
+
+    if (!converter->input_type || !converter->output_type)
+    {
+        LeaveCriticalSection(&converter->cs);
+        return MF_E_TRANSFORM_TYPE_NOT_SET;
+    }
+
+    if (converter->inflight)
+    {
+        LeaveCriticalSection(&converter->cs);
+        return MF_E_NOTACCEPTING;
+    }
+
+    if (!(gst_buffer = gst_buffer_from_mf_sample(sample)))
+    {
+        LeaveCriticalSection(&converter->cs);
+        return E_FAIL;
+    }
+
+    g_signal_emit_by_name(converter->appsrc, "push-buffer", gst_buffer, &ret);
+    gst_buffer_unref(gst_buffer);
+    if (ret != GST_FLOW_OK)
+    {
+        ERR("Couldn't push buffer ret = %d (%s)\n", ret, gst_flow_get_name(ret));
+        LeaveCriticalSection(&converter->cs);
+        return E_FAIL;
+    }
+
+    converter->inflight = TRUE;
+    LeaveCriticalSection(&converter->cs);
+
+    return S_OK;
 }

static HRESULT WINAPI audio_converter_ProcessOutput(IMFTransform *iface, DWORD flags, DWORD count,
         MFT_OUTPUT_DATA_BUFFER *samples, DWORD *status)
 {
-    FIXME("%p, %#x, %u, %p, %p.\n", iface, flags, count, samples, status);
+    GstSample *sample;

-    return E_NOTIMPL;
+    struct audio_converter *converter = impl_audio_converter_from_IMFTransform(iface);
+
+    TRACE("%p, %#x, %u, %p, %p.\n", iface, flags, count, samples, status);
+
+    if (flags)
+        WARN("Unsupported flags %#x\n", flags);
+
+    if (!count)
+        return S_OK;
+
+    if (count != 1)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    if (samples[0].dwStreamID != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    EnterCriticalSection(&converter->cs);
+
+    if (!converter->input_type || !converter->output_type)
+    {
+        LeaveCriticalSection(&converter->cs);
+        return MF_E_TRANSFORM_TYPE_NOT_SET;
+    }
+
+    if (!converter->inflight)
+    {
+        LeaveCriticalSection(&converter->cs);
+        return MF_E_TRANSFORM_NEED_MORE_INPUT;
+    }
+
+    g_signal_emit_by_name(converter->appsink, "pull-sample", &sample);
+
+    converter->inflight =  FALSE;
+
+    samples[0].pSample = mf_sample_from_gst_buffer(gst_sample_get_buffer(sample));
+    gst_sample_unref(sample);
+    samples[0].dwStatus = S_OK;
+    samples[0].pEvents = NULL;
+    *status = 0;
+
+    LeaveCriticalSection(&converter->cs);
+
+    return S_OK;
 }

static const IMFTransformVtbl audio_converter_vtbl =
@@ -537,6 +641,65 @@ HRESULT audio_converter_create(REFIID riid, void **ret)
     InitializeCriticalSection(&object->cs);
     object->cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": audio_converter_lock");

+    object->container = gst_bin_new(NULL);
+
+    if (!(object->appsrc = gst_element_factory_make("appsrc", NULL)))
+    {
+        ERR("Failed to create appsrc, are %u-bit Gstreamer "base" plugins installed?\n",
+                8 * (int)sizeof(void *));
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return E_FAIL;
+    }
+    gst_bin_add(GST_BIN(object->container), object->appsrc);
+
+    if (!(object->audioconvert = gst_element_factory_make("audioconvert", NULL)))
+    {
+        ERR("Failed to create audioconvert, are %u-bit Gstreamer "base" plugins installed?\n",
+                8 * (int)sizeof(void *));
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return E_FAIL;
+    }
+    gst_bin_add(GST_BIN(object->container), object->audioconvert);
+
+    if (!(object->resampler = gst_element_factory_make("audioresample", NULL)))
+    {
+        ERR("Failed to create audioresample, are %u-bit Gstreamer "base" plugins installed?\n",
+                8 * (int)sizeof(void *));
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return E_FAIL;
+    }
+    gst_bin_add(GST_BIN(object->container), object->resampler);
+
+    if (!(object->appsink = gst_element_factory_make("appsink", NULL)))
+    {
+        ERR("Failed to create appsink, are %u-bit Gstreamer "base" plugins installed?\n",
+                8 * (int)sizeof(void *));
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return E_FAIL;
+    }
+    gst_bin_add(GST_BIN(object->container), object->appsink);
+
+    if (!gst_element_link(object->appsrc, object->audioconvert))
+    {
+        ERR("Failed to link appsrc to audioconvert\n");
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return E_FAIL;
+    }
+
+    if (!gst_element_link(object->audioconvert, object->resampler))
+    {
+        ERR("Failed to link audioconvert to resampler\n");
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return E_FAIL;
+    }
+
+    if (!gst_element_link(object->resampler, object->appsink))
+    {
+        ERR("Failed to link resampler to appsink\n");
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return E_FAIL;
+    }
+
     *ret = &object->IMFTransform_iface;
     return S_OK;
 }
diff --git a/dlls/winegstreamer/gst_private.h b/dlls/winegstreamer/gst_private.h
index 9518f721504..14b6a011ac2 100644
--- a/dlls/winegstreamer/gst_private.h
+++ b/dlls/winegstreamer/gst_private.h
@@ -82,6 +82,7 @@ HRESULT winegstreamer_stream_handler_create(REFIID riid, void **obj) DECLSPEC_HI
 IMFMediaType *mf_media_type_from_caps(const GstCaps *caps) DECLSPEC_HIDDEN;
 GstCaps *caps_from_mf_media_type(IMFMediaType *type) DECLSPEC_HIDDEN;
 IMFSample *mf_sample_from_gst_buffer(GstBuffer *in) DECLSPEC_HIDDEN;
+GstBuffer *gst_buffer_from_mf_sample(IMFSample *in) DECLSPEC_HIDDEN;

HRESULT winegstreamer_stream_handler_create(REFIID riid, void **obj) DECLSPEC_HIDDEN;

diff --git a/dlls/winegstreamer/mfplat.c b/dlls/winegstreamer/mfplat.c
index f300988fc5c..883084b2d89 100644
--- a/dlls/winegstreamer/mfplat.c
+++ b/dlls/winegstreamer/mfplat.c
@@ -865,3 +865,72 @@ done:

return out;
 }
+
+GstBuffer* gst_buffer_from_mf_sample(IMFSample *mf_sample)
+{
+    GstBuffer *out = gst_buffer_new();
+    IMFMediaBuffer *mf_buffer = NULL;
+    LONGLONG duration, time;
+    DWORD buffer_count;
+    unsigned int i;
+    HRESULT hr;
+
+    if (FAILED(hr = IMFSample_GetSampleDuration(mf_sample, &duration)))
+        goto fail;
+
+    if (FAILED(hr = IMFSample_GetSampleTime(mf_sample, &time)))
+        goto fail;
+
+    GST_BUFFER_DURATION(out) = duration;
+    GST_BUFFER_PTS(out) = time * 100;
+
+    if (FAILED(hr = IMFSample_GetBufferCount(mf_sample, &buffer_count)))
+        goto fail;
+
+    for (i = 0; i < buffer_count; i++)
+    {
+        DWORD buffer_size;
+        GstMapInfo map_info;
+        GstMemory *memory;
+        BYTE *buf_data;
+
+        if (FAILED(hr = IMFSample_GetBufferByIndex(mf_sample, i, &mf_buffer)))
+            goto fail;
+
+        if (FAILED(hr = IMFMediaBuffer_GetCurrentLength(mf_buffer, &buffer_size)))
+            goto fail;
+
+        memory = gst_allocator_alloc(NULL, buffer_size, NULL);
+        gst_memory_resize(memory, 0, buffer_size);
+
+        if (!(gst_memory_map(memory, &map_info, GST_MAP_WRITE)))
+        {
+            hr = E_FAIL;
+            goto fail;
+        }
+
+        if (FAILED(hr = IMFMediaBuffer_Lock(mf_buffer, &buf_data, NULL, NULL)))
+            goto fail;
+
+        memcpy(map_info.data, buf_data, buffer_size);
+
+        if (FAILED(hr = IMFMediaBuffer_Unlock(mf_buffer)))
+            goto fail;
+
+        gst_memory_unmap(memory, &map_info);
+
+        gst_buffer_append_memory(out, memory);
+
+        IMFMediaBuffer_Release(mf_buffer);
+        mf_buffer = NULL;
+    }
+
+    return out;
+
+fail:
+    ERR("Failed to copy IMFSample to GstBuffer, hr = %#x\n", hr);
+    if (mf_buffer)
+        IMFMediaBuffer_Release(mf_buffer);
+    gst_buffer_unref(out);
+    return NULL;
+}

[PATCH 03/17] winegstreamer: Implement ::Process(Input/Output) for audio conversion transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83066

Your paranoid android.

=== debiant (build log) ===

Task: Patch failed to apply

=== debiant (build log) ===

Task: Patch failed to apply

[PATCH 03/17] winegstreamer: Implement ::Process(Input/Output) for audio conversion transform.

[Zebediah Figura (she/her)]

On 12/3/20 3:55 PM, Derek Lesho wrote:
> Signed-off-by: Derek Lesho
>
> v1(v6):
> - Move unused hr to later patch.
> - Fix extra parentheses.
> - Place converter declaration more consistently.
>
> dlls/winegstreamer/audioconvert.c | 175 +++++++++++++++++++++++++++++-
>  dlls/winegstreamer/gst_private.h  |   1 +
>  dlls/winegstreamer/mfplat.c       |  69 ++++++++++++
>  3 files changed, 239 insertions(+), 6 deletions(-)
>
> diff --git a/dlls/winegstreamer/audioconvert.c b/dlls/winegstreamer/audioconvert.c
> index 7fb0dee99f6..631c57d6d55 100644
> --- a/dlls/winegstreamer/audioconvert.c
> +++ b/dlls/winegstreamer/audioconvert.c
> @@ -40,6 +40,8 @@ struct audio_converter
>      IMFMediaType *input_type;
>      IMFMediaType *output_type;
>      CRITICAL_SECTION cs;
> - BOOL inflight;
> - GstElement *container, *appsrc, *audioconvert, *resampler, *appsink;

Both "resampler" and "audioconvert" can be local variables, I think.
> };
>
> static struct audio_converter *impl_audio_converter_from_IMFTransform(IMFTransform *iface)
> @@ -85,6 +87,7 @@ static ULONG WINAPI audio_converter_Release(IMFTransform *iface)
>      {
>          transform->cs.DebugInfo->Spare[0] = 0;
>          DeleteCriticalSection(&transform->cs);
> -
>    gst_object_unref(transform->container);
>    heap_free(transform);
> }
>
> @@ -311,7 +314,8 @@ static HRESULT WINAPI audio_converter_SetInputType(IMFTransform *iface, DWORD id
>          if (!(input_caps = caps_from_mf_media_type(type)))
>              return MF_E_INVALIDTYPE;
> -
>    gst_caps_unref(input_caps);
> -
>    if (flags & MFT_SET_TYPE_TEST_ONLY)
> -
>        gst_caps_unref(input_caps);
>
> }
>
> if (flags & MFT_SET_TYPE_TEST_ONLY)
>
> @@ -320,6 +324,7 @@ static HRESULT WINAPI audio_converter_SetInputType(IMFTransform *iface, DWORD id
>      EnterCriticalSection(&converter->cs);
>  hr = S_OK;
> - gst_element_set_state(converter->container, GST_STATE_READY);

Presumably you also want to reset "inflight" here...
>  if (type)
>  {
>
> @@ -329,6 +334,9 @@ static HRESULT WINAPI audio_converter_SetInputType(IMFTransform *iface, DWORD id
>          if (SUCCEEDED(hr))
>              hr = IMFMediaType_CopyAllItems(type, (IMFAttributes *) converter->input_type);
> -
>    g_object_set(converter->appsrc, "caps", input_caps, NULL);
> -
>    gst_caps_unref(input_caps);
> -
>    if (FAILED(hr))
>    {
>        IMFMediaType_Release(converter->input_type);
>
> @@ -341,6 +349,9 @@ static HRESULT WINAPI audio_converter_SetInputType(IMFTransform *iface, DWORD id
>          converter->input_type = NULL;
>      }
> -
>
> if (converter->input_type && converter->output_type)
> -
>    gst_element_set_state(converter->container, GST_STATE_PLAYING);
> -
>
> LeaveCriticalSection(&converter->cs);
>
> return hr;
>
> @@ -386,7 +397,8 @@ static HRESULT WINAPI audio_converter_SetOutputType(IMFTransform *iface, DWORD i
>          if (!(output_caps = caps_from_mf_media_type(type)))
>              return MF_E_INVALIDTYPE;
> -
>    gst_caps_unref(output_caps);
> -
>    if (flags & MFT_SET_TYPE_TEST_ONLY)
> -
>        gst_caps_unref(output_caps);

This is something of a style nitpick, but having variables that are
conditionally valid like this is often better avoided. Reorganizing the
function to be something more like

if (CLEAR)
{
    if (TEST_ONLY)
        return;
    EnterCriticalSection();
    // clear
    LeaveCriticalSection();
    return;
}

// validate
// convert to caps
if (TEST_ONLY)
    return;
EnterCriticalSection();
// clear
LeaveCriticalSection();

might be more idiomatic.
>  }
>
>  if (flags & MFT_SET_TYPE_TEST_ONLY)
>
> @@ -395,6 +407,7 @@ static HRESULT WINAPI audio_converter_SetOutputType(IMFTransform *iface, DWORD i
>      EnterCriticalSection(&converter->cs);
>  hr = S_OK;
> - gst_element_set_state(converter->container, GST_STATE_READY);

...and here.
>  if (type)
>  {
>
> @@ -404,6 +417,9 @@ static HRESULT WINAPI audio_converter_SetOutputType(IMFTransform *iface, DWORD i
>          if (SUCCEEDED(hr))
>              hr = IMFMediaType_CopyAllItems(type, (IMFAttributes *) converter->output_type);
> -
>    g_object_set(converter->appsink, "caps", output_caps, NULL);
> -
>    gst_caps_unref(output_caps);
> -
>    if (FAILED(hr))
>    {
>        IMFMediaType_Release(converter->output_type);
>
> @@ -416,6 +432,9 @@ static HRESULT WINAPI audio_converter_SetOutputType(IMFTransform *iface, DWORD i
>          converter->output_type = NULL;
>      }
> -
>
> if (converter->input_type && converter->output_type)
> -
>    gst_element_set_state(converter->container, GST_STATE_PLAYING);
> -
>
> LeaveCriticalSection(&converter->cs);
>
> return hr;
>
> @@ -479,17 +498,102 @@ static HRESULT WINAPI audio_converter_ProcessMessage(IMFTransform *iface, MFT_ME
>
> static HRESULT WINAPI audio_converter_ProcessInput(IMFTransform *iface, DWORD id, IMFSample *sample, DWORD flags)
>  {
> - FIXME("%p, %u, %p, %#x.\n", iface, id, sample, flags);
> - GstBuffer *gst_buffer;
> - int ret;
> - return E_NOTIMPL;
> - struct audio_converter *converter = impl_audio_converter_from_IMFTransform(iface);
> -
> - TRACE("%p, %u, %p, %#x.\n", iface, id, sample, flags);
> -
> - if (flags)
> -
>    WARN("Unsupported flags %#x\n", flags);
> -
> - if (id != 0)
> -
>    return MF_E_INVALIDSTREAMNUMBER;
> -
> - EnterCriticalSection(&converter->cs);
> -
> - if (!converter->input_type || !converter->output_type)
> - {
> -
>    LeaveCriticalSection(&converter->cs);
> -
>    return MF_E_TRANSFORM_TYPE_NOT_SET;
> - }
> -
> - if (converter->inflight)
> - {
> -
>    LeaveCriticalSection(&converter->cs);
> -
>    return MF_E_NOTACCEPTING;
> - }
> -
> - if (!(gst_buffer = gst_buffer_from_mf_sample(sample)))
> - {
> -
>    LeaveCriticalSection(&converter->cs);
> -
>    return E_FAIL;
> - }
> -
> - g_signal_emit_by_name(converter->appsrc, "push-buffer", gst_buffer, &ret);
> - gst_buffer_unref(gst_buffer);
> - if (ret != GST_FLOW_OK)
> - {
> -
>    ERR("Couldn't push buffer ret = %d (%s)\n", ret, gst_flow_get_name(ret));

Is there a point in tracing the numeric value as well?
> -
>    LeaveCriticalSection(&converter->cs);
> -
>    return E_FAIL;
> - }
> -
> - converter->inflight = TRUE;
> - LeaveCriticalSection(&converter->cs);
> -
> - return S_OK;
>
> }
>
> static HRESULT WINAPI audio_converter_ProcessOutput(IMFTransform *iface, DWORD flags, DWORD count,
>          MFT_OUTPUT_DATA_BUFFER *samples, DWORD *status)
>  {
> - FIXME("%p, %#x, %u, %p, %p.\n", iface, flags, count, samples, status);
> - GstSample *sample;
> - return E_NOTIMPL;
> - struct audio_converter *converter = impl_audio_converter_from_IMFTransform(iface);
> -
> - TRACE("%p, %#x, %u, %p, %p.\n", iface, flags, count, samples, status);
> -
> - if (flags)
> -
>    WARN("Unsupported flags %#x\n", flags);
> -
> - if (!count)
> -
>    return S_OK;
> -
> - if (count != 1)
> -
>    return MF_E_INVALIDSTREAMNUMBER;
> -
> - if (samples[0].dwStreamID != 0)
> -
>    return MF_E_INVALIDSTREAMNUMBER;
> -
> - EnterCriticalSection(&converter->cs);
> -
> - if (!converter->input_type || !converter->output_type)
> - {
> -
>    LeaveCriticalSection(&converter->cs);
> -
>    return MF_E_TRANSFORM_TYPE_NOT_SET;
> - }
> -
> - if (!converter->inflight)
> - {
> -
>    LeaveCriticalSection(&converter->cs);
> -
>    return MF_E_TRANSFORM_NEED_MORE_INPUT;
> - }
> -
> - g_signal_emit_by_name(converter->appsink, "pull-sample", &sample);

I'm not fully familiar with mfplat, but this call may block, and it
doesn't look like ProcessOutput() is supposed to. You probably want
"try-pull-sample" instead.
> -
> - converter->inflight =  FALSE;

Nitpick, but this looks like a spacing error.
> -
> - samples[0].pSample = mf_sample_from_gst_buffer(gst_sample_get_buffer(sample));
> - gst_sample_unref(sample);
> - samples[0].dwStatus = S_OK;
> - samples[0].pEvents = NULL;
> - *status = 0;
> -
> - LeaveCriticalSection(&converter->cs);
> -
> - return S_OK;
>
> }
>
> static const IMFTransformVtbl audio_converter_vtbl =
> @@ -537,6 +641,65 @@ HRESULT audio_converter_create(REFIID riid, void **ret)
>      InitializeCriticalSection(&object->cs);
>      object->cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": audio_converter_lock");
> - object->container = gst_bin_new(NULL);
> -
> - if (!(object->appsrc = gst_element_factory_make("appsrc", NULL)))
> - {
> -
>    ERR("Failed to create appsrc, are %u-bit Gstreamer \"base\" plugins installed?\n",
> -
>            8 * (int)sizeof(void *));
> -
>    IMFTransform_Release(&object->IMFTransform_iface);
> -
>    return E_FAIL;
> - }
> - gst_bin_add(GST_BIN(object->container), object->appsrc);
> -
> - if (!(object->audioconvert = gst_element_factory_make("audioconvert", NULL)))
> - {
> -
>    ERR("Failed to create audioconvert, are %u-bit Gstreamer \"base\" plugins installed?\n",
> -
>            8 * (int)sizeof(void *));
> -
>    IMFTransform_Release(&object->IMFTransform_iface);
> -
>    return E_FAIL;
> - }
> - gst_bin_add(GST_BIN(object->container), object->audioconvert);
> -
> - if (!(object->resampler = gst_element_factory_make("audioresample", NULL)))
> - {
> -
>    ERR("Failed to create audioresample, are %u-bit Gstreamer \"base\" plugins installed?\n",
> -
>            8 * (int)sizeof(void *));
> -
>    IMFTransform_Release(&object->IMFTransform_iface);
> -
>    return E_FAIL;
> - }
> - gst_bin_add(GST_BIN(object->container), object->resampler);
> -
> - if (!(object->appsink = gst_element_factory_make("appsink", NULL)))
> - {
> -
>    ERR("Failed to create appsink, are %u-bit Gstreamer \"base\" plugins installed?\n",
> -
>            8 * (int)sizeof(void *));
> -
>    IMFTransform_Release(&object->IMFTransform_iface);
> -
>    return E_FAIL;
> - }
> - gst_bin_add(GST_BIN(object->container), object->appsink);
> -
> - if (!gst_element_link(object->appsrc, object->audioconvert))
> - {
> -
>    ERR("Failed to link appsrc to audioconvert\n");
> -
>    IMFTransform_Release(&object->IMFTransform_iface);
> -
>    return E_FAIL;
> - }
> -
> - if (!gst_element_link(object->audioconvert, object->resampler))
> - {
> -
>    ERR("Failed to link audioconvert to resampler\n");
> -
>    IMFTransform_Release(&object->IMFTransform_iface);
> -
>    return E_FAIL;
> - }
> -
> - if (!gst_element_link(object->resampler, object->appsink))
> - {
> -
>    ERR("Failed to link resampler to appsink\n");
> -
>    IMFTransform_Release(&object->IMFTransform_iface);
> -
>    return E_FAIL;
> - }
> - *ret = &object->IMFTransform_iface;
>    return S_OK;
>
> }
> diff --git a/dlls/winegstreamer/gst_private.h b/dlls/winegstreamer/gst_private.h
> index 9518f721504..14b6a011ac2 100644
> --- a/dlls/winegstreamer/gst_private.h
> +++ b/dlls/winegstreamer/gst_private.h
> @@ -82,6 +82,7 @@ HRESULT winegstreamer_stream_handler_create(REFIID riid, void **obj) DECLSPEC_HI
>  IMFMediaType *mf_media_type_from_caps(const GstCaps *caps) DECLSPEC_HIDDEN;
>  GstCaps *caps_from_mf_media_type(IMFMediaType *type) DECLSPEC_HIDDEN;
>  IMFSample *mf_sample_from_gst_buffer(GstBuffer *in) DECLSPEC_HIDDEN;
> +GstBuffer *gst_buffer_from_mf_sample(IMFSample *in) DECLSPEC_HIDDEN;
>
> HRESULT winegstreamer_stream_handler_create(REFIID riid, void **obj) DECLSPEC_HIDDEN;
>
> diff --git a/dlls/winegstreamer/mfplat.c b/dlls/winegstreamer/mfplat.c
> index f300988fc5c..883084b2d89 100644
> --- a/dlls/winegstreamer/mfplat.c
> +++ b/dlls/winegstreamer/mfplat.c
> @@ -865,3 +865,72 @@ done:
>  return out;
>
> }
> -
>
> +GstBuffer* gst_buffer_from_mf_sample(IMFSample *mf_sample)

Please use consistent spacing around pointers.
> +{
> - GstBuffer *out = gst_buffer_new();
> - IMFMediaBuffer *mf_buffer = NULL;
> - LONGLONG duration, time;
> - DWORD buffer_count;
> - unsigned int i;
> - HRESULT hr;
> -
> - if (FAILED(hr = IMFSample_GetSampleDuration(mf_sample, &duration)))
> -
>    goto fail;
> -
> - if (FAILED(hr = IMFSample_GetSampleTime(mf_sample, &time)))
> -
>    goto fail;
> -
> - GST_BUFFER_DURATION(out) = duration;
> - GST_BUFFER_PTS(out) = time * 100;
> -
> - if (FAILED(hr = IMFSample_GetBufferCount(mf_sample, &buffer_count)))
> -
>    goto fail;
> -
> - for (i = 0; i < buffer_count; i++)
> - {
> -
>    DWORD buffer_size;
> -
>    GstMapInfo map_info;
> -
>    GstMemory *memory;
> -
>    BYTE *buf_data;
> -
> -
>    if (FAILED(hr = IMFSample_GetBufferByIndex(mf_sample, i, &mf_buffer)))
> -
>        goto fail;
> -
> -
>    if (FAILED(hr = IMFMediaBuffer_GetCurrentLength(mf_buffer, &buffer_size)))
> -
>        goto fail;
> -
> -
>    memory = gst_allocator_alloc(NULL, buffer_size, NULL);
> -
>    gst_memory_resize(memory, 0, buffer_size);
> -
> -
>    if (!(gst_memory_map(memory, &map_info, GST_MAP_WRITE)))

These parentheses are somewhat redundant...
> -
>    {
> -
>        hr = E_FAIL;
> -
>        goto fail;
> -
>    }
> -
> -
>    if (FAILED(hr = IMFMediaBuffer_Lock(mf_buffer, &buf_data, NULL, NULL)))
> -
>        goto fail;
> -
> -
>    memcpy(map_info.data, buf_data, buffer_size);
> -
> -
>    if (FAILED(hr = IMFMediaBuffer_Unlock(mf_buffer)))
> -
>        goto fail;
> -
> -
>    gst_memory_unmap(memory, &map_info);
> -
> -
>    gst_buffer_append_memory(out, memory);
> -
> -
>    IMFMediaBuffer_Release(mf_buffer);
> -
>    mf_buffer = NULL;
> - }
> -
> - return out;
> -
>
> +fail:
> - ERR("Failed to copy IMFSample to GstBuffer, hr = %#x\n", hr);
> - if (mf_buffer)
> -
>    IMFMediaBuffer_Release(mf_buffer);
> - gst_buffer_unref(out);
> - return NULL;
>
> +}

[PATCH 03/17] winegstreamer: Implement ::Process(Input/Output) for audio conversion transform.

[Derek Lesho]

On 12/3/20 10:26 PM, Zebediah Figura (she/her) wrote:
> > - g_signal_emit_by_name(converter->appsink, "pull-sample", &sample);
>
> I'm not fully familiar with mfplat, but this call may block, and it
> doesn't look like ProcessOutput() is supposed to. You probably want
> "try-pull-sample" instead.

Actually, with sync MFTs, ::ProcessOutput is blocking until a sample is 
yielded or an error occurs.  In MFT writing guides from Microsoft I've 
seen, ::ProcessInput just buts the data in a buffer, and ::ProcessOutput 
actually invokes the functionality of the transform.  This should match 
that behavior pretty closely.

[PATCH 04/17] winegstreamer: Implement ::Get(Input/Output)StreamInfo for audio conversion transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
v1(v6): Made naming and style of the two functions consistent.
---
 dlls/winegstreamer/audioconvert.c | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/dlls/winegstreamer/audioconvert.c b/dlls/winegstreamer/audioconvert.c
index 631c57d6d55..d204d9582ba 100644
--- a/dlls/winegstreamer/audioconvert.c
+++ b/dlls/winegstreamer/audioconvert.c
@@ -123,16 +123,31 @@ static HRESULT WINAPI audio_converter_GetStreamIDs(IMFTransform *iface, DWORD in

static HRESULT WINAPI audio_converter_GetInputStreamInfo(IMFTransform *iface, DWORD id, MFT_INPUT_STREAM_INFO *info)
 {
-    FIXME("%p %u %p.\n", iface, id, info);
+    TRACE("%p %u %p.\n", iface, id, info);

-    return E_NOTIMPL;
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    info->dwFlags = MFT_INPUT_STREAM_WHOLE_SAMPLES | MFT_INPUT_STREAM_DOES_NOT_ADDREF;
+    info->cbMaxLookahead = 0;
+    info->cbAlignment = 0;
+    info->hnsMaxLatency = 0;
+
+    return S_OK;
 }

static HRESULT WINAPI audio_converter_GetOutputStreamInfo(IMFTransform *iface, DWORD id, MFT_OUTPUT_STREAM_INFO *info)
 {
-    FIXME("%p %u %p.\n", iface, id, info);
+    TRACE("%p %u %p.\n", iface, id, info);

-    return E_NOTIMPL;
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    info->dwFlags = MFT_OUTPUT_STREAM_PROVIDES_SAMPLES;
+    info->cbSize = 0;
+    info->cbAlignment = 0;
+
+    return S_OK;
 }

static HRESULT WINAPI audio_converter_GetAttributes(IMFTransform *iface, IMFAttributes **attributes)

[PATCH 04/17] winegstreamer: Implement ::Get(Input/Output)StreamInfo for audio conversion transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83067

Your paranoid android.

=== debiant (build log) ===

Task: Patch failed to apply

=== debiant (build log) ===

Task: Patch failed to apply

[PATCH 04/17] winegstreamer: Implement ::Get(Input/Output)StreamInfo for audio conversion transform.

[Zebediah Figura (she/her)]

On 12/3/20 3:55 PM, Derek Lesho wrote:
> Signed-off-by: Derek Lesho
> v1(v6): Made naming and style of the two functions consistent.
>
> dlls/winegstreamer/audioconvert.c | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/dlls/winegstreamer/audioconvert.c b/dlls/winegstreamer/audioconvert.c
> index 631c57d6d55..d204d9582ba 100644
> --- a/dlls/winegstreamer/audioconvert.c
> +++ b/dlls/winegstreamer/audioconvert.c
> @@ -123,16 +123,31 @@ static HRESULT WINAPI audio_converter_GetStreamIDs(IMFTransform *iface, DWORD in
>
> static HRESULT WINAPI audio_converter_GetInputStreamInfo(IMFTransform *iface, DWORD id, MFT_INPUT_STREAM_INFO *info)
>  {
> - FIXME("%p %u %p.\n", iface, id, info);
> - TRACE("%p %u %p.\n", iface, id, info);
> - return E_NOTIMPL;
> - if (id != 0)
> -
>    return MF_E_INVALIDSTREAMNUMBER;
> -
> - info->dwFlags = MFT_INPUT_STREAM_WHOLE_SAMPLES | MFT_INPUT_STREAM_DOES_NOT_ADDREF;
> - info->cbMaxLookahead = 0;
> - info->cbAlignment = 0;
> - info->hnsMaxLatency = 0;
> -

"info->cbSize" isn't set here; is that intentional?
> - return S_OK;
>
> }
>
> static HRESULT WINAPI audio_converter_GetOutputStreamInfo(IMFTransform *iface, DWORD id, MFT_OUTPUT_STREAM_INFO *info)
>  {
> - FIXME("%p %u %p.\n", iface, id, info);
> - TRACE("%p %u %p.\n", iface, id, info);
> - return E_NOTIMPL;
> - if (id != 0)
> -
>    return MF_E_INVALIDSTREAMNUMBER;
> -
> - info->dwFlags = MFT_OUTPUT_STREAM_PROVIDES_SAMPLES;

Is it intentional to provide WHOLE_SAMPLES in GetInputStreamInfo() but
not (the equivalent flag) here?
> - info->cbSize = 0;
> - info->cbAlignment = 0;
> -
> - return S_OK;
>
> }
>
> static HRESULT WINAPI audio_converter_GetAttributes(IMFTransform *iface, IMFAttributes **attributes)

[PATCH 05/17] winegstreamer: Implement Get*Attributes functions for audio converter transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/audioconvert.c | 37 +++++++++++++++++++++++++++----
 1 file changed, 33 insertions(+), 4 deletions(-)

diff --git a/dlls/winegstreamer/audioconvert.c b/dlls/winegstreamer/audioconvert.c
index d204d9582ba..556aba44fc9 100644
--- a/dlls/winegstreamer/audioconvert.c
+++ b/dlls/winegstreamer/audioconvert.c
@@ -37,6 +37,8 @@ struct audio_converter
 {
     IMFTransform IMFTransform_iface;
     LONG refcount;
+    IMFAttributes *attributes;
+    IMFAttributes *output_attributes;
     IMFMediaType *input_type;
     IMFMediaType *output_type;
     CRITICAL_SECTION cs;
@@ -87,6 +89,10 @@ static ULONG WINAPI audio_converter_Release(IMFTransform *iface)
     {
         transform->cs.DebugInfo->Spare[0] = 0;
         DeleteCriticalSection(&transform->cs);
+        if (transform->attributes)
+            IMFAttributes_Release(transform->attributes);
+        if (transform->output_attributes)
+            IMFAttributes_Release(transform->output_attributes);
         gst_object_unref(transform->container);
         heap_free(transform);
     }
@@ -152,9 +158,14 @@ static HRESULT WINAPI audio_converter_GetOutputStreamInfo(IMFTransform *iface, D

static HRESULT WINAPI audio_converter_GetAttributes(IMFTransform *iface, IMFAttributes **attributes)
 {
-    FIXME("%p, %p.\n", iface, attributes);
+    struct audio_converter *converter = impl_audio_converter_from_IMFTransform(iface);

-    return E_NOTIMPL;
+    TRACE("%p, %p.\n", iface, attributes);
+
+    *attributes = converter->attributes;
+    IMFAttributes_AddRef(*attributes);
+
+    return S_OK;
 }

static HRESULT WINAPI audio_converter_GetInputStreamAttributes(IMFTransform *iface, DWORD id,
@@ -168,9 +179,14 @@ static HRESULT WINAPI audio_converter_GetInputStreamAttributes(IMFTransform *ifa
 static HRESULT WINAPI audio_converter_GetOutputStreamAttributes(IMFTransform *iface, DWORD id,
         IMFAttributes **attributes)
 {
-    FIXME("%p, %u, %p.\n", iface, id, attributes);
+    struct audio_converter *converter = impl_audio_converter_from_IMFTransform(iface);

-    return E_NOTIMPL;
+    TRACE("%p, %u, %p.\n", iface, id, attributes);
+
+    *attributes = converter->output_attributes;
+    IMFAttributes_AddRef(*attributes);
+
+    return S_OK;
 }

static HRESULT WINAPI audio_converter_DeleteInputStream(IMFTransform *iface, DWORD id)
@@ -644,6 +660,7 @@ static const IMFTransformVtbl audio_converter_vtbl =
 HRESULT audio_converter_create(REFIID riid, void **ret)
 {
     struct audio_converter *object;
+    HRESULT hr;

TRACE("%s %p\n", debugstr_guid(riid), ret);

@@ -656,6 +673,18 @@ HRESULT audio_converter_create(REFIID riid, void **ret)
     InitializeCriticalSection(&object->cs);
     object->cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": audio_converter_lock");

+    if (FAILED(hr = MFCreateAttributes(&object->attributes, 0)))
+    {
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return hr;
+    }
+
+    if (FAILED(hr = MFCreateAttributes(&object->output_attributes, 0)))
+    {
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return hr;
+    }
+
     object->container = gst_bin_new(NULL);

if (!(object->appsrc = gst_element_factory_make("appsrc", NULL)))

[PATCH 05/17] winegstreamer: Implement Get*Attributes functions for audio converter transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83068

Your paranoid android.

=== debiant (build log) ===

Task: Patch failed to apply

=== debiant (build log) ===

Task: Patch failed to apply

[PATCH 05/17] winegstreamer: Implement Get*Attributes functions for audio converter transform.

[Zebediah Figura (she/her)]

On 12/3/20 3:55 PM, Derek Lesho wrote:
> Signed-off-by: Derek Lesho
>
> dlls/winegstreamer/audioconvert.c | 37 +++++++++++++++++++++++++++----
>  1 file changed, 33 insertions(+), 4 deletions(-)

The patch subject is mildly misleading, since you don't implement all
such functions...
> diff --git a/dlls/winegstreamer/audioconvert.c b/dlls/winegstreamer/audioconvert.c
> index d204d9582ba..556aba44fc9 100644
> --- a/dlls/winegstreamer/audioconvert.c
> +++ b/dlls/winegstreamer/audioconvert.c
> @@ -37,6 +37,8 @@ struct audio_converter
>  {
>      IMFTransform IMFTransform_iface;
>      LONG refcount;
> - IMFAttributes *attributes;
> - IMFAttributes *output_attributes;
> IMFMediaType *input_type;
> IMFMediaType *output_type;
> CRITICAL_SECTION cs;
>
> @@ -87,6 +89,10 @@ static ULONG WINAPI audio_converter_Release(IMFTransform *iface)
>      {
>          transform->cs.DebugInfo->Spare[0] = 0;
>          DeleteCriticalSection(&transform->cs);
> -
>    if (transform->attributes)
> -
>        IMFAttributes_Release(transform->attributes);
> -
>    if (transform->output_attributes)
> -
>        IMFAttributes_Release(transform->output_attributes);
>    gst_object_unref(transform->container);
>    heap_free(transform);
> }
>
> @@ -152,9 +158,14 @@ static HRESULT WINAPI audio_converter_GetOutputStreamInfo(IMFTransform *iface, D
>
> static HRESULT WINAPI audio_converter_GetAttributes(IMFTransform *iface, IMFAttributes **attributes)
>  {
> - FIXME("%p, %p.\n", iface, attributes);
> - struct audio_converter *converter = impl_audio_converter_from_IMFTransform(iface);
> - return E_NOTIMPL;
> - TRACE("%p, %p.\n", iface, attributes);
> -
> - *attributes = converter->attributes;
> - IMFAttributes_AddRef(*attributes);
> -
> - return S_OK;
>
> }
>
> static HRESULT WINAPI audio_converter_GetInputStreamAttributes(IMFTransform *iface, DWORD id,
> @@ -168,9 +179,14 @@ static HRESULT WINAPI audio_converter_GetInputStreamAttributes(IMFTransform *ifa
>  static HRESULT WINAPI audio_converter_GetOutputStreamAttributes(IMFTransform *iface, DWORD id,
>          IMFAttributes **attributes)
>  {
> - FIXME("%p, %u, %p.\n", iface, id, attributes);
> - struct audio_converter *converter = impl_audio_converter_from_IMFTransform(iface);
> - return E_NOTIMPL;
> - TRACE("%p, %u, %p.\n", iface, id, attributes);
> -
> - *attributes = converter->output_attributes;
> - IMFAttributes_AddRef(*attributes);
> -
> - return S_OK;
>
> }
>
> static HRESULT WINAPI audio_converter_DeleteInputStream(IMFTransform *iface, DWORD id)
> @@ -644,6 +660,7 @@ static const IMFTransformVtbl audio_converter_vtbl =
>  HRESULT audio_converter_create(REFIID riid, void **ret)
>  {
>      struct audio_converter *object;
> -
>
> HRESULT hr;
>
> TRACE("%s %p\n", debugstr_guid(riid), ret);
>
> @@ -656,6 +673,18 @@ HRESULT audio_converter_create(REFIID riid, void **ret)
>      InitializeCriticalSection(&object->cs);
>      object->cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": audio_converter_lock");
> -
>
> if (FAILED(hr = MFCreateAttributes(&object->attributes, 0)))
> -
>
> {
> -
>    IMFTransform_Release(&object->IMFTransform_iface);
> -
>    return hr;
> -
>
> }
> -
> -
>
> if (FAILED(hr = MFCreateAttributes(&object->output_attributes, 0)))
> -
>
> {
> -
>    IMFTransform_Release(&object->IMFTransform_iface);
> -
>    return hr;
> -
>
> }
> -
>
> object->container = gst_bin_new(NULL);
>
> if (!(object->appsrc = gst_element_factory_make("appsrc", NULL)))

[PATCH 06/17] winegstreamer: Implement Get(Input/Output)CurrentType functions for audio converter transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
v1(v6):
  - Fix commit message.
  - Fixed leak of media type in error path.
---
 dlls/winegstreamer/audioconvert.c | 56 ++++++++++++++++++++++++++++---
 1 file changed, 52 insertions(+), 4 deletions(-)

diff --git a/dlls/winegstreamer/audioconvert.c b/dlls/winegstreamer/audioconvert.c
index 556aba44fc9..e709c43ed5c 100644
--- a/dlls/winegstreamer/audioconvert.c
+++ b/dlls/winegstreamer/audioconvert.c
@@ -473,16 +473,64 @@ static HRESULT WINAPI audio_converter_SetOutputType(IMFTransform *iface, DWORD i

static HRESULT WINAPI audio_converter_GetInputCurrentType(IMFTransform *iface, DWORD id, IMFMediaType **type)
 {
-    FIXME("%p, %u, %p.\n", iface, id, type);
+    struct audio_converter *converter = impl_audio_converter_from_IMFTransform(iface);
+    IMFMediaType *ret;
+    HRESULT hr;

-    return E_NOTIMPL;
+    TRACE("%p, %u, %p.\n", converter, id, type);
+
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    if (FAILED(hr = MFCreateMediaType(&ret)))
+        return hr;
+
+    EnterCriticalSection(&converter->cs);
+
+    if (converter->input_type)
+        hr = IMFMediaType_CopyAllItems(converter->input_type, (IMFAttributes *)ret);
+    else
+        hr = MF_E_TRANSFORM_TYPE_NOT_SET;
+
+    LeaveCriticalSection(&converter->cs);
+
+    if (SUCCEEDED(hr))
+        *type = ret;
+    else
+        IMFMediaType_Release(ret);
+
+    return hr;
 }

static HRESULT WINAPI audio_converter_GetOutputCurrentType(IMFTransform *iface, DWORD id, IMFMediaType **type)
 {
-    FIXME("%p, %u, %p.\n", iface, id, type);
+    struct audio_converter *converter = impl_audio_converter_from_IMFTransform(iface);
+    IMFMediaType *ret;
+    HRESULT hr;

-    return E_NOTIMPL;
+    TRACE("%p, %u, %p.\n", converter, id, type);
+
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    if (FAILED(hr = MFCreateMediaType(&ret)))
+        return hr;
+
+    EnterCriticalSection(&converter->cs);
+
+    if (converter->output_type)
+        hr = IMFMediaType_CopyAllItems(converter->output_type, (IMFAttributes *)ret);
+    else
+        hr = MF_E_TRANSFORM_TYPE_NOT_SET;
+
+    LeaveCriticalSection(&converter->cs);
+
+    if (SUCCEEDED(hr))
+        *type = ret;
+    else
+        IMFMediaType_Release(ret);
+
+    return hr;
 }

static HRESULT WINAPI audio_converter_GetInputStatus(IMFTransform *iface, DWORD id, DWORD *flags)

[PATCH 06/17] winegstreamer: Implement Get(Input/Output)CurrentType functions for audio converter transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83069

Your paranoid android.

=== debiant (build log) ===

Task: Patch failed to apply

=== debiant (build log) ===

Task: Patch failed to apply

[PATCH 06/17] winegstreamer: Implement Get(Input/Output)CurrentType functions for audio converter transform.

[Zebediah Figura (she/her)]

Signed-off-by: Zebediah Figura

[PATCH 07/17] winegstreamer: Introduce color conversion transform.

[Derek Lesho]

Serves as a wrapper of videoconvert, and roughly fills the roll of Windows' CColorConverterDMO.

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/Makefile.in               |   1 +
 dlls/winegstreamer/colorconvert.c            | 302 +++++++++++++++++++
 dlls/winegstreamer/gst_private.h             |   1 +
 dlls/winegstreamer/mfplat.c                  |   3 +
 dlls/winegstreamer/winegstreamer_classes.idl |   6 +
 5 files changed, 313 insertions(+)
 create mode 100644 dlls/winegstreamer/colorconvert.c

diff --git a/dlls/winegstreamer/Makefile.in b/dlls/winegstreamer/Makefile.in
index 0b3229160b9..5395d6fd501 100644
--- a/dlls/winegstreamer/Makefile.in
+++ b/dlls/winegstreamer/Makefile.in
@@ -7,6 +7,7 @@ PARENTSRC = ../strmbase

C_SRCS = \
    audioconvert.c \
+	colorconvert.c \
    filter.c \
    gst_cbs.c \
    gstdemux.c \
diff --git a/dlls/winegstreamer/colorconvert.c b/dlls/winegstreamer/colorconvert.c
new file mode 100644
index 00000000000..8d0823fc0dc
--- /dev/null
+++ b/dlls/winegstreamer/colorconvert.c
@@ -0,0 +1,302 @@
+/* GStreamer Color Converter
+ *
+ * Copyright 2020 Derek Lesho
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
+ */
+
+#include "config.h"
+
+#include "gst_private.h"
+
+#include "mfapi.h"
+#include "mferror.h"
+#include "mfidl.h"
+
+#include "wine/debug.h"
+#include "wine/heap.h"
+
+WINE_DEFAULT_DEBUG_CHANNEL(mfplat);
+
+struct color_converter
+{
+    IMFTransform IMFTransform_iface;
+    LONG refcount;
+};
+
+static struct color_converter *impl_color_converter_from_IMFTransform(IMFTransform *iface)
+{
+    return CONTAINING_RECORD(iface, struct color_converter, IMFTransform_iface);
+}
+
+static HRESULT WINAPI color_converter_QueryInterface(IMFTransform *iface, REFIID riid, void **obj)
+{
+    TRACE("%p, %s, %p.\n", iface, debugstr_guid(riid), obj);
+
+    if (IsEqualIID(riid, &IID_IMFTransform) ||
+            IsEqualIID(riid, &IID_IUnknown))
+    {
+        *obj = iface;
+        IMFTransform_AddRef(iface);
+        return S_OK;
+    }
+
+    WARN("Unsupported %s.\n", debugstr_guid(riid));
+    *obj = NULL;
+    return E_NOINTERFACE;
+}
+
+static ULONG WINAPI color_converter_AddRef(IMFTransform *iface)
+{
+    struct color_converter *transform = impl_color_converter_from_IMFTransform(iface);
+    ULONG refcount = InterlockedIncrement(&transform->refcount);
+
+    TRACE("%p, refcount %u.\n", iface, refcount);
+
+    return refcount;
+}
+
+static ULONG WINAPI color_converter_Release(IMFTransform *iface)
+{
+    struct color_converter *transform = impl_color_converter_from_IMFTransform(iface);
+    ULONG refcount = InterlockedDecrement(&transform->refcount);
+
+    TRACE("%p, refcount %u.\n", iface, refcount);
+
+    if (!refcount)
+    {
+        heap_free(transform);
+    }
+
+    return refcount;
+}
+
+static HRESULT WINAPI color_converter_GetStreamLimits(IMFTransform *iface, DWORD *input_minimum, DWORD *input_maximum,
+        DWORD *output_minimum, DWORD *output_maximum)
+{
+    TRACE("%p, %p, %p, %p, %p.\n", iface, input_minimum, input_maximum, output_minimum, output_maximum);
+
+    *input_minimum = *input_maximum = *output_minimum = *output_maximum = 1;
+
+    return S_OK;
+}
+
+static HRESULT WINAPI color_converter_GetStreamCount(IMFTransform *iface, DWORD *inputs, DWORD *outputs)
+{
+    TRACE("%p, %p, %p.\n", iface, inputs, outputs);
+
+    *inputs = *outputs = 1;
+
+    return S_OK;
+}
+
+static HRESULT WINAPI color_converter_GetStreamIDs(IMFTransform *iface, DWORD input_size, DWORD *inputs,
+        DWORD output_size, DWORD *outputs)
+{
+    TRACE("%p %u %p %u %p.\n", iface, input_size, inputs, output_size, outputs);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_GetInputStreamInfo(IMFTransform *iface, DWORD id, MFT_INPUT_STREAM_INFO *info)
+{
+    FIXME("%p %u %p.\n", iface, id, info);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_GetOutputStreamInfo(IMFTransform *iface, DWORD id, MFT_OUTPUT_STREAM_INFO *info)
+{
+    FIXME("%p %u %p.\n", iface, id, info);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_GetAttributes(IMFTransform *iface, IMFAttributes **attributes)
+{
+    FIXME("%p, %p.\n", iface, attributes);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_GetInputStreamAttributes(IMFTransform *iface, DWORD id,
+        IMFAttributes **attributes)
+{
+    FIXME("%p, %u, %p.\n", iface, id, attributes);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_GetOutputStreamAttributes(IMFTransform *iface, DWORD id,
+        IMFAttributes **attributes)
+{
+    FIXME("%p, %u, %p.\n", iface, id, attributes);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_DeleteInputStream(IMFTransform *iface, DWORD id)
+{
+    TRACE("%p, %u.\n", iface, id);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_AddInputStreams(IMFTransform *iface, DWORD streams, DWORD *ids)
+{
+    TRACE("%p, %u, %p.\n", iface, streams, ids);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_GetInputAvailableType(IMFTransform *iface, DWORD id, DWORD index,
+        IMFMediaType **type)
+{
+    FIXME("%p, %u, %u, %p.\n", iface, id, index, type);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_GetOutputAvailableType(IMFTransform *iface, DWORD id, DWORD index,
+        IMFMediaType **type)
+{
+    FIXME("%p, %u, %u, %p.\n", iface, id, index, type);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *type, DWORD flags)
+{
+    FIXME("%p, %u, %p, %#x.\n", iface, id, type, flags);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_SetOutputType(IMFTransform *iface, DWORD id, IMFMediaType *type, DWORD flags)
+{
+    FIXME("%p, %u, %p, %#x.\n", iface, id, type, flags);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_GetInputCurrentType(IMFTransform *iface, DWORD id, IMFMediaType **type)
+{
+    FIXME("%p, %u, %p.\n", iface, id, type);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_GetOutputCurrentType(IMFTransform *iface, DWORD id, IMFMediaType **type)
+{
+    FIXME("%p, %u, %p.\n", iface, id, type);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_GetInputStatus(IMFTransform *iface, DWORD id, DWORD *flags)
+{
+    FIXME("%p, %u, %p.\n", iface, id, flags);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_GetOutputStatus(IMFTransform *iface, DWORD *flags)
+{
+    FIXME("%p, %p.\n", iface, flags);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_SetOutputBounds(IMFTransform *iface, LONGLONG lower, LONGLONG upper)
+{
+    FIXME("%p, %s, %s.\n", iface, wine_dbgstr_longlong(lower), wine_dbgstr_longlong(upper));
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_ProcessEvent(IMFTransform *iface, DWORD id, IMFMediaEvent *event)
+{
+    TRACE("%p, %u, %p.\n", iface, id, event);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_ProcessMessage(IMFTransform *iface, MFT_MESSAGE_TYPE message, ULONG_PTR param)
+{
+    FIXME("%p, %u %lu.\n", iface, message, param);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_ProcessInput(IMFTransform *iface, DWORD id, IMFSample *sample, DWORD flags)
+{
+    FIXME("%p, %u, %p, %#x.\n", iface, id, sample, flags);
+
+    return E_NOTIMPL;
+}
+
+static HRESULT WINAPI color_converter_ProcessOutput(IMFTransform *iface, DWORD flags, DWORD count,
+        MFT_OUTPUT_DATA_BUFFER *samples, DWORD *status)
+{
+    FIXME("%p, %#x, %u, %p, %p.\n", iface, flags, count, samples, status);
+
+    return E_NOTIMPL;
+}
+
+static const IMFTransformVtbl color_converter_vtbl =
+{
+    color_converter_QueryInterface,
+    color_converter_AddRef,
+    color_converter_Release,
+    color_converter_GetStreamLimits,
+    color_converter_GetStreamCount,
+    color_converter_GetStreamIDs,
+    color_converter_GetInputStreamInfo,
+    color_converter_GetOutputStreamInfo,
+    color_converter_GetAttributes,
+    color_converter_GetInputStreamAttributes,
+    color_converter_GetOutputStreamAttributes,
+    color_converter_DeleteInputStream,
+    color_converter_AddInputStreams,
+    color_converter_GetInputAvailableType,
+    color_converter_GetOutputAvailableType,
+    color_converter_SetInputType,
+    color_converter_SetOutputType,
+    color_converter_GetInputCurrentType,
+    color_converter_GetOutputCurrentType,
+    color_converter_GetInputStatus,
+    color_converter_GetOutputStatus,
+    color_converter_SetOutputBounds,
+    color_converter_ProcessEvent,
+    color_converter_ProcessMessage,
+    color_converter_ProcessInput,
+    color_converter_ProcessOutput,
+};
+
+HRESULT color_converter_create(REFIID riid, void **ret)
+{
+    struct color_converter *object;
+
+    TRACE("%s %p\n", debugstr_guid(riid), ret);
+
+    if (!(object = heap_alloc_zero(sizeof(*object))))
+        return E_OUTOFMEMORY;
+
+    object->IMFTransform_iface.lpVtbl = &color_converter_vtbl;
+    object->refcount = 1;
+
+    *ret = &object->IMFTransform_iface;
+    return S_OK;
+}
diff --git a/dlls/winegstreamer/gst_private.h b/dlls/winegstreamer/gst_private.h
index 14b6a011ac2..075e0ce1f0f 100644
--- a/dlls/winegstreamer/gst_private.h
+++ b/dlls/winegstreamer/gst_private.h
@@ -87,5 +87,6 @@ GstBuffer *gst_buffer_from_mf_sample(IMFSample *in) DECLSPEC_HIDDEN;
 HRESULT winegstreamer_stream_handler_create(REFIID riid, void **obj) DECLSPEC_HIDDEN;

HRESULT audio_converter_create(REFIID riid, void **ret) DECLSPEC_HIDDEN;
+HRESULT color_converter_create(REFIID riid, void **ret) DECLSPEC_HIDDEN;

#endif /* __GST_PRIVATE_INCLUDED__ */
diff --git a/dlls/winegstreamer/mfplat.c b/dlls/winegstreamer/mfplat.c
index 883084b2d89..288b79997cd 100644
--- a/dlls/winegstreamer/mfplat.c
+++ b/dlls/winegstreamer/mfplat.c
@@ -407,6 +407,8 @@ static const GUID CLSID_GStreamerByteStreamHandler = {0x317df618, 0x5e5a, 0x468a

static const GUID CLSID_WINEAudioConverter = {0x6a170414,0xaad9,0x4693,{0xb8,0x06,0x3a,0x0c,0x47,0xc5,0x70,0xd6}};

+static GUID CLSID_WINEColorConverter = {0x2be8b27f,0xcd60,0x4b8a,{0x95,0xae,0xd1,0x74,0xcc,0x5c,0xba,0xa7}};
+
 static const struct class_object
 {
     const GUID *clsid;
@@ -417,6 +419,7 @@ class_objects[] =
     { &CLSID_VideoProcessorMFT, &video_processor_create },
     { &CLSID_GStreamerByteStreamHandler, &winegstreamer_stream_handler_create },
     { &CLSID_WINEAudioConverter, &audio_converter_create },
+    { &CLSID_WINEColorConverter, &color_converter_create },
 };

HRESULT mfplat_get_class_object(REFCLSID rclsid, REFIID riid, void **obj)
diff --git a/dlls/winegstreamer/winegstreamer_classes.idl b/dlls/winegstreamer/winegstreamer_classes.idl
index cf1fc69f38a..47c10a09cf0 100644
--- a/dlls/winegstreamer/winegstreamer_classes.idl
+++ b/dlls/winegstreamer/winegstreamer_classes.idl
@@ -67,3 +67,9 @@ coclass GStreamerByteStreamHandler {}
     uuid(6a170414-aad9-4693-b806-3a0c47c570d6)
 ]
 coclass WINEAudioConverter { }
+
+[
+    threading(both),
+    uuid(2be8b27f-cd60-4b8a-95ae-d174cc5cbaa7)
+]
+coclass WINEColorConverter { }

[PATCH 07/17] winegstreamer: Introduce color conversion transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83070

Your paranoid android.

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
Task: Patch failed to apply

[PATCH 07/17] winegstreamer: Introduce color conversion transform.

[Zebediah Figura (she/her)]

On 12/3/20 3:55 PM, Derek Lesho wrote:
> Serves as a wrapper of videoconvert, and roughly fills the roll of Windows' CColorConverterDMO.

Why can't this be CColorConvertDMO?
> Signed-off-by: Derek Lesho
>
> dlls/winegstreamer/Makefile.in               |   1 +
>  dlls/winegstreamer/colorconvert.c            | 302 +++++++++++++++++++
>  dlls/winegstreamer/gst_private.h             |   1 +
>  dlls/winegstreamer/mfplat.c                  |   3 +
>  dlls/winegstreamer/winegstreamer_classes.idl |   6 +
>  5 files changed, 313 insertions(+)
>  create mode 100644 dlls/winegstreamer/colorconvert.c
>
> diff --git a/dlls/winegstreamer/Makefile.in b/dlls/winegstreamer/Makefile.in
> index 0b3229160b9..5395d6fd501 100644
> --- a/dlls/winegstreamer/Makefile.in
> +++ b/dlls/winegstreamer/Makefile.in
> @@ -7,6 +7,7 @@ PARENTSRC = ../strmbase
>
> C_SRCS = \
>    audioconvert.c \
> - colorconvert.c \
> filter.c \
> gst_cbs.c \
> gstdemux.c \
>
> diff --git a/dlls/winegstreamer/colorconvert.c b/dlls/winegstreamer/colorconvert.c
> new file mode 100644
> index 00000000000..8d0823fc0dc
> --- /dev/null
> +++ b/dlls/winegstreamer/colorconvert.c
> @@ -0,0 +1,302 @@
> +/* GStreamer Color Converter
> -
> -
> -
> - Copyright 2020 Derek Lesho
> -
> -
> -
> - This library is free software; you can redistribute it and/or
> -
> - modify it under the terms of the GNU Lesser General Public
> -
> - License as published by the Free Software Foundation; either
> -
> - version 2.1 of the License, or (at your option) any later version.
> -
> -
> -
> - This library is distributed in the hope that it will be useful,
> -
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> -
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -
> - Lesser General Public License for more details.
> -
> -
> -
> - You should have received a copy of the GNU Lesser General Public
> -
> - License along with this library; if not, write to the Free Software
> -
> - Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
> - */
> -
>
> +#include "config.h"
> -
>
> +#include "gst_private.h"
> -
>
> +#include "mfapi.h"
> +#include "mferror.h"
> +#include "mfidl.h"
> -
>
> +#include "wine/debug.h"
> +#include "wine/heap.h"
> -
>
> +WINE_DEFAULT_DEBUG_CHANNEL(mfplat);
> -
>
> +struct color_converter
> +{
> - IMFTransform IMFTransform_iface;
> - LONG refcount;
>
> +};
> -
>
> +static struct color_converter *impl_color_converter_from_IMFTransform(IMFTransform *iface)
> +{
> - return CONTAINING_RECORD(iface, struct color_converter, IMFTransform_iface);
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_QueryInterface(IMFTransform *iface, REFIID riid, void **obj)
> +{
> - TRACE("%p, %s, %p.\n", iface, debugstr_guid(riid), obj);
> -
> - if (IsEqualIID(riid, &IID_IMFTransform) ||
> -
>        IsEqualIID(riid, &IID_IUnknown))
> - {
> -
>    *obj = iface;
> -
>    IMFTransform_AddRef(iface);
> -
>    return S_OK;
> - }
> -
> - WARN("Unsupported %s.\n", debugstr_guid(riid));
> - *obj = NULL;
> - return E_NOINTERFACE;
>
> +}
> -
>
> +static ULONG WINAPI color_converter_AddRef(IMFTransform *iface)
> +{
> - struct color_converter *transform = impl_color_converter_from_IMFTransform(iface);
> - ULONG refcount = InterlockedIncrement(&transform->refcount);
> -
> - TRACE("%p, refcount %u.\n", iface, refcount);
> -
> - return refcount;
>
> +}
> -
>
> +static ULONG WINAPI color_converter_Release(IMFTransform *iface)
> +{
> - struct color_converter *transform = impl_color_converter_from_IMFTransform(iface);
> - ULONG refcount = InterlockedDecrement(&transform->refcount);
> -
> - TRACE("%p, refcount %u.\n", iface, refcount);
> -
> - if (!refcount)
> - {
> -
>    heap_free(transform);
> - }
> -
> - return refcount;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetStreamLimits(IMFTransform *iface, DWORD *input_minimum, DWORD *input_maximum,
> -
>    DWORD *output_minimum, DWORD *output_maximum)
>
> +{
> - TRACE("%p, %p, %p, %p, %p.\n", iface, input_minimum, input_maximum, output_minimum, output_maximum);
> -
> - *input_minimum = *input_maximum = *output_minimum = *output_maximum = 1;
> -
> - return S_OK;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetStreamCount(IMFTransform *iface, DWORD *inputs, DWORD *outputs)
> +{
> - TRACE("%p, %p, %p.\n", iface, inputs, outputs);
> -
> - *inputs = *outputs = 1;
> -
> - return S_OK;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetStreamIDs(IMFTransform *iface, DWORD input_size, DWORD *inputs,
> -
>    DWORD output_size, DWORD *outputs)
>
> +{
> - TRACE("%p %u %p %u %p.\n", iface, input_size, inputs, output_size, outputs);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetInputStreamInfo(IMFTransform *iface, DWORD id, MFT_INPUT_STREAM_INFO *info)
> +{
> - FIXME("%p %u %p.\n", iface, id, info);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetOutputStreamInfo(IMFTransform *iface, DWORD id, MFT_OUTPUT_STREAM_INFO *info)
> +{
> - FIXME("%p %u %p.\n", iface, id, info);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetAttributes(IMFTransform *iface, IMFAttributes **attributes)
> +{
> - FIXME("%p, %p.\n", iface, attributes);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetInputStreamAttributes(IMFTransform *iface, DWORD id,
> -
>    IMFAttributes **attributes)
>
> +{
> - FIXME("%p, %u, %p.\n", iface, id, attributes);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetOutputStreamAttributes(IMFTransform *iface, DWORD id,
> -
>    IMFAttributes **attributes)
>
> +{
> - FIXME("%p, %u, %p.\n", iface, id, attributes);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_DeleteInputStream(IMFTransform *iface, DWORD id)
> +{
> - TRACE("%p, %u.\n", iface, id);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_AddInputStreams(IMFTransform *iface, DWORD streams, DWORD *ids)
> +{
> - TRACE("%p, %u, %p.\n", iface, streams, ids);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetInputAvailableType(IMFTransform *iface, DWORD id, DWORD index,
> -
>    IMFMediaType **type)
>
> +{
> - FIXME("%p, %u, %u, %p.\n", iface, id, index, type);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetOutputAvailableType(IMFTransform *iface, DWORD id, DWORD index,
> -
>    IMFMediaType **type)
>
> +{
> - FIXME("%p, %u, %u, %p.\n", iface, id, index, type);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *type, DWORD flags)
> +{
> - FIXME("%p, %u, %p, %#x.\n", iface, id, type, flags);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_SetOutputType(IMFTransform *iface, DWORD id, IMFMediaType *type, DWORD flags)
> +{
> - FIXME("%p, %u, %p, %#x.\n", iface, id, type, flags);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetInputCurrentType(IMFTransform *iface, DWORD id, IMFMediaType **type)
> +{
> - FIXME("%p, %u, %p.\n", iface, id, type);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetOutputCurrentType(IMFTransform *iface, DWORD id, IMFMediaType **type)
> +{
> - FIXME("%p, %u, %p.\n", iface, id, type);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetInputStatus(IMFTransform *iface, DWORD id, DWORD *flags)
> +{
> - FIXME("%p, %u, %p.\n", iface, id, flags);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_GetOutputStatus(IMFTransform *iface, DWORD *flags)
> +{
> - FIXME("%p, %p.\n", iface, flags);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_SetOutputBounds(IMFTransform *iface, LONGLONG lower, LONGLONG upper)
> +{
> - FIXME("%p, %s, %s.\n", iface, wine_dbgstr_longlong(lower), wine_dbgstr_longlong(upper));
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_ProcessEvent(IMFTransform *iface, DWORD id, IMFMediaEvent *event)
> +{
> - TRACE("%p, %u, %p.\n", iface, id, event);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_ProcessMessage(IMFTransform *iface, MFT_MESSAGE_TYPE message, ULONG_PTR param)
> +{
> - FIXME("%p, %u %lu.\n", iface, message, param);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_ProcessInput(IMFTransform *iface, DWORD id, IMFSample *sample, DWORD flags)
> +{
> - FIXME("%p, %u, %p, %#x.\n", iface, id, sample, flags);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static HRESULT WINAPI color_converter_ProcessOutput(IMFTransform *iface, DWORD flags, DWORD count,
> -
>    MFT_OUTPUT_DATA_BUFFER *samples, DWORD *status)
>
> +{
> - FIXME("%p, %#x, %u, %p, %p.\n", iface, flags, count, samples, status);
> -
> - return E_NOTIMPL;
>
> +}
> -
>
> +static const IMFTransformVtbl color_converter_vtbl =
> +{
> - color_converter_QueryInterface,
> - color_converter_AddRef,
> - color_converter_Release,
> - color_converter_GetStreamLimits,
> - color_converter_GetStreamCount,
> - color_converter_GetStreamIDs,
> - color_converter_GetInputStreamInfo,
> - color_converter_GetOutputStreamInfo,
> - color_converter_GetAttributes,
> - color_converter_GetInputStreamAttributes,
> - color_converter_GetOutputStreamAttributes,
> - color_converter_DeleteInputStream,
> - color_converter_AddInputStreams,
> - color_converter_GetInputAvailableType,
> - color_converter_GetOutputAvailableType,
> - color_converter_SetInputType,
> - color_converter_SetOutputType,
> - color_converter_GetInputCurrentType,
> - color_converter_GetOutputCurrentType,
> - color_converter_GetInputStatus,
> - color_converter_GetOutputStatus,
> - color_converter_SetOutputBounds,
> - color_converter_ProcessEvent,
> - color_converter_ProcessMessage,
> - color_converter_ProcessInput,
> - color_converter_ProcessOutput,
>
> +};
> -
>
> +HRESULT color_converter_create(REFIID riid, void **ret)
> +{
> - struct color_converter *object;
> -
> - TRACE("%s %p\n", debugstr_guid(riid), ret);
> -
> - if (!(object = heap_alloc_zero(sizeof(*object))))
> -
>    return E_OUTOFMEMORY;
> -
> - object->IMFTransform_iface.lpVtbl = &color_converter_vtbl;
> - object->refcount = 1;
> -
> - *ret = &object->IMFTransform_iface;
> - return S_OK;
>
> +}
> diff --git a/dlls/winegstreamer/gst_private.h b/dlls/winegstreamer/gst_private.h
> index 14b6a011ac2..075e0ce1f0f 100644
> --- a/dlls/winegstreamer/gst_private.h
> +++ b/dlls/winegstreamer/gst_private.h
> @@ -87,5 +87,6 @@ GstBuffer *gst_buffer_from_mf_sample(IMFSample *in) DECLSPEC_HIDDEN;
>  HRESULT winegstreamer_stream_handler_create(REFIID riid, void **obj) DECLSPEC_HIDDEN;
>
> HRESULT audio_converter_create(REFIID riid, void **ret) DECLSPEC_HIDDEN;
> +HRESULT color_converter_create(REFIID riid, void **ret) DECLSPEC_HIDDEN;
>
> #endif /* __GST_PRIVATE_INCLUDED__ */
> diff --git a/dlls/winegstreamer/mfplat.c b/dlls/winegstreamer/mfplat.c
> index 883084b2d89..288b79997cd 100644
> --- a/dlls/winegstreamer/mfplat.c
> +++ b/dlls/winegstreamer/mfplat.c
> @@ -407,6 +407,8 @@ static const GUID CLSID_GStreamerByteStreamHandler = {0x317df618, 0x5e5a, 0x468a
>
> static const GUID CLSID_WINEAudioConverter = {0x6a170414,0xaad9,0x4693,{0xb8,0x06,0x3a,0x0c,0x47,0xc5,0x70,0xd6}};
>
> +static GUID CLSID_WINEColorConverter = {0x2be8b27f,0xcd60,0x4b8a,{0x95,0xae,0xd1,0x74,0xcc,0x5c,0xba,0xa7}};
> -

This can be const...
> static const struct class_object
>  {
>      const GUID *clsid;
> @@ -417,6 +419,7 @@ class_objects[] =
>      { &CLSID_VideoProcessorMFT, &video_processor_create },
>      { &CLSID_GStreamerByteStreamHandler, &winegstreamer_stream_handler_create },
>      { &CLSID_WINEAudioConverter, &audio_converter_create },
> - { &CLSID_WINEColorConverter, &color_converter_create },
>
> };
>
> HRESULT mfplat_get_class_object(REFCLSID rclsid, REFIID riid, void **obj)
> diff --git a/dlls/winegstreamer/winegstreamer_classes.idl b/dlls/winegstreamer/winegstreamer_classes.idl
> index cf1fc69f38a..47c10a09cf0 100644
> --- a/dlls/winegstreamer/winegstreamer_classes.idl
> +++ b/dlls/winegstreamer/winegstreamer_classes.idl
> @@ -67,3 +67,9 @@ coclass GStreamerByteStreamHandler {}
>      uuid(6a170414-aad9-4693-b806-3a0c47c570d6)
>  ]
>  coclass WINEAudioConverter { }
> -
>
> +[
> - threading(both),
> - uuid(2be8b27f-cd60-4b8a-95ae-d174cc5cbaa7)
>
> +]
> +coclass WINEColorConverter { }

[PATCH 07/17] winegstreamer: Introduce color conversion transform.

[Derek Lesho]

On 12/3/20 10:40 PM, Zebediah Figura (she/her) wrote:
> On 12/3/20 3:55 PM, Derek Lesho wrote:
> > Serves as a wrapper of videoconvert, and roughly fills the roll of Windows' CColorConverterDMO.
>
> Why can't this be CColorConvertDMO?

Nothing specific, I don't think there's any fundamental differences here 
to what a CColorConvertDMO implementation would like.  While I haven't 
tested any applications that manually use CColorConvertDMO, I don't 
think we'd run into any problems with incompatibility if/when they come up.

[PATCH 08/17] winegstreamer: Register the color conversion transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/mfplat.c | 34 +++++++++++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/dlls/winegstreamer/mfplat.c b/dlls/winegstreamer/mfplat.c
index 288b79997cd..1b19c43d991 100644
--- a/dlls/winegstreamer/mfplat.c
+++ b/dlls/winegstreamer/mfplat.c
@@ -455,6 +455,26 @@ static const GUID *audio_converter_supported_types[] =
     &MFAudioFormat_Float,
 };

+static WCHAR color_converterW[] = {'C','o','l','o','r',' ','C','o','n','v','e','r','t','e','r',0};
+const GUID *color_converter_supported_types[] =
+{
+    &MFVideoFormat_RGB24,
+    &MFVideoFormat_RGB32,
+    &MFVideoFormat_RGB555,
+    &MFVideoFormat_RGB8,
+    &MFVideoFormat_AYUV,
+    &MFVideoFormat_I420,
+    &MFVideoFormat_IYUV,
+    &MFVideoFormat_NV11,
+    &MFVideoFormat_NV12,
+    &MFVideoFormat_UYVY,
+    &MFVideoFormat_v216,
+    &MFVideoFormat_v410,
+    &MFVideoFormat_YUY2,
+    &MFVideoFormat_YVYU,
+    &MFVideoFormat_YVYU,
+};
+
 static const struct mft
 {
     const GUID *clsid;
@@ -482,13 +502,25 @@ mfts[] =
         audio_converter_supported_types,
         NULL
     },
+    {
+        &CLSID_WINEColorConverter,
+        &MFT_CATEGORY_VIDEO_EFFECT,
+        color_converterW,
+        MFT_ENUM_FLAG_SYNCMFT,
+        &MFMediaType_Video,
+        ARRAY_SIZE(color_converter_supported_types),
+        color_converter_supported_types,
+        ARRAY_SIZE(color_converter_supported_types),
+        color_converter_supported_types,
+        NULL
+    },
 };

HRESULT mfplat_DllRegisterServer(void)
 {
     unsigned int i, j;
     HRESULT hr;
-    MFT_REGISTER_TYPE_INFO input_types[2], output_types[2];
+    MFT_REGISTER_TYPE_INFO input_types[15], output_types[15];

for (i = 0; i < ARRAY_SIZE(mfts); i++)
     {

[PATCH 08/17] winegstreamer: Register the color conversion transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83071

Your paranoid android.

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

[PATCH 09/17] winegstreamer: Implement ::GetInputAvailableType for color conversion transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/colorconvert.c | 48 +++++++++++++++++++++++++++++--
 1 file changed, 46 insertions(+), 2 deletions(-)

diff --git a/dlls/winegstreamer/colorconvert.c b/dlls/winegstreamer/colorconvert.c
index 8d0823fc0dc..9a1d2880234 100644
--- a/dlls/winegstreamer/colorconvert.c
+++ b/dlls/winegstreamer/colorconvert.c
@@ -30,6 +30,24 @@

WINE_DEFAULT_DEBUG_CHANNEL(mfplat);

+static const GUID *raw_types[] = {
+    &MFVideoFormat_RGB24,
+    &MFVideoFormat_RGB32,
+    &MFVideoFormat_RGB555,
+    &MFVideoFormat_RGB8,
+    &MFVideoFormat_AYUV,
+    &MFVideoFormat_I420,
+    &MFVideoFormat_IYUV,
+    &MFVideoFormat_NV11,
+    &MFVideoFormat_NV12,
+    &MFVideoFormat_UYVY,
+    &MFVideoFormat_v216,
+    &MFVideoFormat_v410,
+    &MFVideoFormat_YUY2,
+    &MFVideoFormat_YVYU,
+    &MFVideoFormat_YVYU,
+};
+
 struct color_converter
 {
     IMFTransform IMFTransform_iface;
@@ -164,9 +182,35 @@ static HRESULT WINAPI color_converter_AddInputStreams(IMFTransform *iface, DWORD
 static HRESULT WINAPI color_converter_GetInputAvailableType(IMFTransform *iface, DWORD id, DWORD index,
         IMFMediaType **type)
 {
-    FIXME("%p, %u, %u, %p.\n", iface, id, index, type);
+    IMFMediaType *ret;
+    HRESULT hr;

-    return E_NOTIMPL;
+    TRACE("%p, %u, %u, %p.\n", iface, id, index, type);
+
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    if (index >= ARRAY_SIZE(raw_types))
+        return MF_E_NO_MORE_TYPES;
+
+    if (FAILED(hr = MFCreateMediaType(&ret)))
+        return hr;
+
+    if (FAILED(hr = IMFMediaType_SetGUID(ret, &MF_MT_MAJOR_TYPE, &MFMediaType_Video)))
+    {
+        IMFMediaType_Release(ret);
+        return hr;
+    }
+
+    if (FAILED(hr = IMFMediaType_SetGUID(ret, &MF_MT_SUBTYPE, raw_types[index])))
+    {
+        IMFMediaType_Release(ret);
+        return hr;
+    }
+
+    *type = ret;
+
+    return S_OK;
 }

static HRESULT WINAPI color_converter_GetOutputAvailableType(IMFTransform *iface, DWORD id, DWORD index,

[PATCH 09/17] winegstreamer: Implement ::GetInputAvailableType for color conversion transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83072

Your paranoid android.

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

[PATCH 10/17] winegstreamer: Implement ::SetInputType for color conversion transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/colorconvert.c | 76 ++++++++++++++++++++++++++++++-
 1 file changed, 74 insertions(+), 2 deletions(-)

diff --git a/dlls/winegstreamer/colorconvert.c b/dlls/winegstreamer/colorconvert.c
index 9a1d2880234..5dd48188147 100644
--- a/dlls/winegstreamer/colorconvert.c
+++ b/dlls/winegstreamer/colorconvert.c
@@ -52,6 +52,8 @@ struct color_converter
 {
     IMFTransform IMFTransform_iface;
     LONG refcount;
+    IMFMediaType *input_type;
+    CRITICAL_SECTION cs;
 };

static struct color_converter *impl_color_converter_from_IMFTransform(IMFTransform *iface)
@@ -95,6 +97,8 @@ static ULONG WINAPI color_converter_Release(IMFTransform *iface)

if (!refcount)
     {
+        transform->cs.DebugInfo->Spare[0] = 0;
+        DeleteCriticalSection(&transform->cs);
         heap_free(transform);
     }

@@ -223,9 +227,74 @@ static HRESULT WINAPI color_converter_GetOutputAvailableType(IMFTransform *iface

static HRESULT WINAPI color_converter_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *type, DWORD flags)
 {
-    FIXME("%p, %u, %p, %#x.\n", iface, id, type, flags);
+    GstCaps *input_caps;
+    unsigned int i;
+    HRESULT hr;

-    return E_NOTIMPL;
+    struct color_converter *converter = impl_color_converter_from_IMFTransform(iface);
+
+    TRACE("%p, %u, %p, %#x.\n", iface, id, type, flags);
+
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    if (type)
+    {
+        GUID major_type, subtype;
+
+        if (FAILED(IMFMediaType_GetGUID(type, &MF_MT_MAJOR_TYPE, &major_type)))
+            return MF_E_INVALIDTYPE;
+        if (FAILED(IMFMediaType_GetGUID(type, &MF_MT_SUBTYPE, &subtype)))
+            return MF_E_INVALIDTYPE;
+
+        if (!(IsEqualGUID(&major_type, &MFMediaType_Video)))
+            return MF_E_INVALIDTYPE;
+
+        for (i = 0; i < ARRAY_SIZE(raw_types); i++)
+        {
+            if (IsEqualGUID(&subtype, raw_types[i]))
+                break;
+        }
+
+        if (i == ARRAY_SIZE(raw_types))
+            return MF_E_INVALIDTYPE;
+
+        if (!(input_caps = caps_from_mf_media_type(type)))
+            return MF_E_INVALIDTYPE;
+
+        gst_caps_unref(input_caps);
+    }
+
+    if (flags & MFT_SET_TYPE_TEST_ONLY)
+        return S_OK;
+
+    EnterCriticalSection(&converter->cs);
+
+    hr = S_OK;
+
+    if (type)
+    {
+        if (!converter->input_type)
+            hr = MFCreateMediaType(&converter->input_type);
+
+        if (SUCCEEDED(hr))
+            hr = IMFMediaType_CopyAllItems(type, (IMFAttributes *) converter->input_type);
+
+        if (FAILED(hr))
+        {
+            IMFMediaType_Release(converter->input_type);
+            converter->input_type = NULL;
+        }
+    }
+    else
+    {
+        IMFMediaType_Release(converter->input_type);
+        converter->input_type = NULL;
+    }
+
+    LeaveCriticalSection(&converter->cs);
+
+    return hr;
 }

static HRESULT WINAPI color_converter_SetOutputType(IMFTransform *iface, DWORD id, IMFMediaType *type, DWORD flags)
@@ -341,6 +410,9 @@ HRESULT color_converter_create(REFIID riid, void **ret)
     object->IMFTransform_iface.lpVtbl = &color_converter_vtbl;
     object->refcount = 1;

+    InitializeCriticalSection(&object->cs);
+    object->cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": color_converter_lock");
+
     *ret = &object->IMFTransform_iface;
     return S_OK;
 }

[PATCH 10/17] winegstreamer: Implement ::SetInputType for color conversion transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83073

Your paranoid android.

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

[PATCH 11/17] winegstreamer: Implement ::GetOutputAvailableType for color conversion transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/colorconvert.c | 48 +++++++++++++++++++++++++++++--
 1 file changed, 46 insertions(+), 2 deletions(-)

diff --git a/dlls/winegstreamer/colorconvert.c b/dlls/winegstreamer/colorconvert.c
index 5dd48188147..b80232e195b 100644
--- a/dlls/winegstreamer/colorconvert.c
+++ b/dlls/winegstreamer/colorconvert.c
@@ -217,12 +217,56 @@ static HRESULT WINAPI color_converter_GetInputAvailableType(IMFTransform *iface,
     return S_OK;
 }

+static void copy_attr(IMFMediaType *target, IMFMediaType *source, const GUID *key)
+{
+    PROPVARIANT val;
+
+    if (SUCCEEDED(IMFAttributes_GetItem((IMFAttributes *)source, key, &val)))
+    {
+        IMFAttributes_SetItem((IMFAttributes* )target, key, &val);
+    }
+}
+
 static HRESULT WINAPI color_converter_GetOutputAvailableType(IMFTransform *iface, DWORD id, DWORD index,
         IMFMediaType **type)
 {
-    FIXME("%p, %u, %u, %p.\n", iface, id, index, type);
+    IMFMediaType *output_type;
+    HRESULT hr;

-    return E_NOTIMPL;
+    struct color_converter *converter = impl_color_converter_from_IMFTransform(iface);
+
+    TRACE("%p, %u, %u, %p.\n", iface, id, index, type);
+
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    if (index >= ARRAY_SIZE(raw_types))
+        return MF_E_NO_MORE_TYPES;
+
+    if (FAILED(hr = MFCreateMediaType(&output_type)))
+        return hr;
+
+    EnterCriticalSection(&converter->cs);
+
+    if (!(converter->input_type))
+    {
+        LeaveCriticalSection(&converter->cs);
+        return MF_E_TRANSFORM_TYPE_NOT_SET;
+    }
+
+    IMFMediaType_CopyAllItems(converter->input_type, (IMFAttributes *)output_type);
+
+    LeaveCriticalSection(&converter->cs);
+
+    if (FAILED(hr = IMFMediaType_SetGUID(output_type, &MF_MT_SUBTYPE, raw_types[index])))
+    {
+        IMFMediaType_Release(output_type);
+        return hr;
+    }
+
+    *type = output_type;
+
+    return S_OK;
 }

static HRESULT WINAPI color_converter_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *type, DWORD flags)

[PATCH 11/17] winegstreamer: Implement ::GetOutputAvailableType for color conversion transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83074

Your paranoid android.

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

[PATCH 12/17] winegstreamer: Implement ::SetOutputType for color conversion transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/colorconvert.c | 70 ++++++++++++++++++++++++++++++-
 1 file changed, 68 insertions(+), 2 deletions(-)

diff --git a/dlls/winegstreamer/colorconvert.c b/dlls/winegstreamer/colorconvert.c
index b80232e195b..e7e84690738 100644
--- a/dlls/winegstreamer/colorconvert.c
+++ b/dlls/winegstreamer/colorconvert.c
@@ -53,6 +53,7 @@ struct color_converter
     IMFTransform IMFTransform_iface;
     LONG refcount;
     IMFMediaType *input_type;
+    IMFMediaType *output_type;
     CRITICAL_SECTION cs;
 };

@@ -343,9 +344,74 @@ static HRESULT WINAPI color_converter_SetInputType(IMFTransform *iface, DWORD id

static HRESULT WINAPI color_converter_SetOutputType(IMFTransform *iface, DWORD id, IMFMediaType *type, DWORD flags)
 {
-    FIXME("%p, %u, %p, %#x.\n", iface, id, type, flags);
+    GstCaps *output_caps;
+    unsigned int i;
+    HRESULT hr;

-    return E_NOTIMPL;
+    struct color_converter *converter = impl_color_converter_from_IMFTransform(iface);
+
+    TRACE("%p, %u, %p, %#x.\n", iface, id, type, flags);
+
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    if (type)
+    {
+        GUID major_type, subtype;
+
+        if (FAILED(IMFMediaType_GetGUID(type, &MF_MT_MAJOR_TYPE, &major_type)))
+            return MF_E_INVALIDTYPE;
+        if (FAILED(IMFMediaType_GetGUID(type, &MF_MT_SUBTYPE, &subtype)))
+            return MF_E_INVALIDTYPE;
+
+        if (!(IsEqualGUID(&major_type, &MFMediaType_Video)))
+            return MF_E_INVALIDTYPE;
+
+        for (i = 0; i < ARRAY_SIZE(raw_types); i++)
+        {
+            if (IsEqualGUID(&subtype, raw_types[i]))
+                break;
+        }
+
+        if (i == ARRAY_SIZE(raw_types))
+            return MF_E_INVALIDTYPE;
+
+        if (!(output_caps = caps_from_mf_media_type(type)))
+            return MF_E_INVALIDTYPE;
+
+        gst_caps_unref(output_caps);
+    }
+
+    if (flags & MFT_SET_TYPE_TEST_ONLY)
+        return S_OK;
+
+    EnterCriticalSection(&converter->cs);
+
+    hr = S_OK;
+
+    if (type)
+    {
+        if (!converter->output_type)
+            hr = MFCreateMediaType(&converter->output_type);
+
+        if (SUCCEEDED(hr))
+            hr = IMFMediaType_CopyAllItems(type, (IMFAttributes *) converter->output_type);
+
+        if (FAILED(hr))
+        {
+            IMFMediaType_Release(converter->output_type);
+            converter->output_type = NULL;
+        }
+    }
+    else
+    {
+        IMFMediaType_Release(converter->output_type);
+        converter->output_type = NULL;
+    }
+
+    LeaveCriticalSection(&converter->cs);
+
+    return hr;
 }

static HRESULT WINAPI color_converter_GetInputCurrentType(IMFTransform *iface, DWORD id, IMFMediaType **type)

[PATCH 12/17] winegstreamer: Implement ::SetOutputType for color conversion transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83075

Your paranoid android.

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

[PATCH 13/17] winegstreamer: Implement ::Process(Input/Output) for color conversion transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/colorconvert.c | 159 +++++++++++++++++++++++++++++-
 1 file changed, 154 insertions(+), 5 deletions(-)

diff --git a/dlls/winegstreamer/colorconvert.c b/dlls/winegstreamer/colorconvert.c
index e7e84690738..b77f3358c52 100644
--- a/dlls/winegstreamer/colorconvert.c
+++ b/dlls/winegstreamer/colorconvert.c
@@ -55,6 +55,8 @@ struct color_converter
     IMFMediaType *input_type;
     IMFMediaType *output_type;
     CRITICAL_SECTION cs;
+    BOOL inflight;
+    GstElement *container, *appsrc, *videoconvert, *appsink;
 };

static struct color_converter *impl_color_converter_from_IMFTransform(IMFTransform *iface)
@@ -100,6 +102,7 @@ static ULONG WINAPI color_converter_Release(IMFTransform *iface)
     {
         transform->cs.DebugInfo->Spare[0] = 0;
         DeleteCriticalSection(&transform->cs);
+        gst_object_unref(transform->container);
         heap_free(transform);
     }

@@ -307,7 +310,8 @@ static HRESULT WINAPI color_converter_SetInputType(IMFTransform *iface, DWORD id
         if (!(input_caps = caps_from_mf_media_type(type)))
             return MF_E_INVALIDTYPE;

-        gst_caps_unref(input_caps);
+        if (flags & MFT_SET_TYPE_TEST_ONLY)
+            gst_caps_unref(input_caps);
     }

if (flags & MFT_SET_TYPE_TEST_ONLY)
@@ -316,6 +320,7 @@ static HRESULT WINAPI color_converter_SetInputType(IMFTransform *iface, DWORD id
     EnterCriticalSection(&converter->cs);

hr = S_OK;
+    gst_element_set_state(converter->container, GST_STATE_READY);

if (type)
     {
@@ -325,6 +330,9 @@ static HRESULT WINAPI color_converter_SetInputType(IMFTransform *iface, DWORD id
         if (SUCCEEDED(hr))
             hr = IMFMediaType_CopyAllItems(type, (IMFAttributes *) converter->input_type);

+        g_object_set(converter->appsrc, "caps", input_caps, NULL);
+        gst_caps_unref(input_caps);
+
         if (FAILED(hr))
         {
             IMFMediaType_Release(converter->input_type);
@@ -337,6 +345,9 @@ static HRESULT WINAPI color_converter_SetInputType(IMFTransform *iface, DWORD id
         converter->input_type = NULL;
     }

+    if (converter->input_type && converter->output_type)
+        gst_element_set_state(converter->container, GST_STATE_PLAYING);
+
     LeaveCriticalSection(&converter->cs);

return hr;
@@ -379,7 +390,8 @@ static HRESULT WINAPI color_converter_SetOutputType(IMFTransform *iface, DWORD i
         if (!(output_caps = caps_from_mf_media_type(type)))
             return MF_E_INVALIDTYPE;

-        gst_caps_unref(output_caps);
+        if (flags & MFT_SET_TYPE_TEST_ONLY)
+            gst_caps_unref(output_caps);
     }

if (flags & MFT_SET_TYPE_TEST_ONLY)
@@ -388,6 +400,7 @@ static HRESULT WINAPI color_converter_SetOutputType(IMFTransform *iface, DWORD i
     EnterCriticalSection(&converter->cs);

hr = S_OK;
+    gst_element_set_state(converter->container, GST_STATE_READY);

if (type)
     {
@@ -397,6 +410,9 @@ static HRESULT WINAPI color_converter_SetOutputType(IMFTransform *iface, DWORD i
         if (SUCCEEDED(hr))
             hr = IMFMediaType_CopyAllItems(type, (IMFAttributes *) converter->output_type);

+        g_object_set(converter->appsink, "caps", output_caps, NULL);
+        gst_caps_unref(output_caps);
+
         if (FAILED(hr))
         {
             IMFMediaType_Release(converter->output_type);
@@ -409,6 +425,9 @@ static HRESULT WINAPI color_converter_SetOutputType(IMFTransform *iface, DWORD i
         converter->output_type = NULL;
     }

+    if (converter->input_type && converter->output_type)
+        gst_element_set_state(converter->container, GST_STATE_PLAYING);
+
     LeaveCriticalSection(&converter->cs);

return hr;
@@ -465,15 +484,102 @@ static HRESULT WINAPI color_converter_ProcessMessage(IMFTransform *iface, MFT_ME

static HRESULT WINAPI color_converter_ProcessInput(IMFTransform *iface, DWORD id, IMFSample *sample, DWORD flags)
 {
-    FIXME("%p, %u, %p, %#x.\n", iface, id, sample, flags);
+    GstBuffer *gst_buffer;
+    int ret;

-    return E_NOTIMPL;
+    struct color_converter *converter = impl_color_converter_from_IMFTransform(iface);
+
+    TRACE("%p, %u, %p, %#x.\n", iface, id, sample, flags);
+
+    if (flags)
+        WARN("Unsupported flags %#x\n", flags);
+
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    EnterCriticalSection(&converter->cs);
+
+    if (!converter->input_type || !converter->output_type)
+    {
+        LeaveCriticalSection(&converter->cs);
+        return MF_E_TRANSFORM_TYPE_NOT_SET;
+    }
+
+    if (converter->inflight)
+    {
+        LeaveCriticalSection(&converter->cs);
+        return MF_E_NOTACCEPTING;
+    }
+
+    if (!(gst_buffer = gst_buffer_from_mf_sample(sample)))
+    {
+        LeaveCriticalSection(&converter->cs);
+        return E_FAIL;
+    }
+
+    g_signal_emit_by_name(converter->appsrc, "push-buffer", gst_buffer, &ret);
+    gst_buffer_unref(gst_buffer);
+    if (ret != GST_FLOW_OK)
+    {
+        ERR("Couldn't push buffer ret = %d (%s)\n", ret, gst_flow_get_name(ret));
+        LeaveCriticalSection(&converter->cs);
+        return E_FAIL;
+    }
+
+    converter->inflight = TRUE;
+    LeaveCriticalSection(&converter->cs);
+
+    return S_OK;
 }

static HRESULT WINAPI color_converter_ProcessOutput(IMFTransform *iface, DWORD flags, DWORD count,
         MFT_OUTPUT_DATA_BUFFER *samples, DWORD *status)
 {
-    FIXME("%p, %#x, %u, %p, %p.\n", iface, flags, count, samples, status);
+    GstSample *sample;
+
+    struct color_converter *converter = impl_color_converter_from_IMFTransform(iface);
+
+    TRACE("%p, %#x, %u, %p, %p.\n", iface, flags, count, samples, status);
+
+    if (flags)
+        WARN("Unsupported flags %#x\n", flags);
+
+    if (!count)
+        return S_OK;
+
+    if (count != 1)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    if (samples[0].dwStreamID != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    EnterCriticalSection(&converter->cs);
+
+    if (!converter->input_type || !converter->output_type)
+    {
+        LeaveCriticalSection(&converter->cs);
+        return MF_E_TRANSFORM_TYPE_NOT_SET;
+    }
+
+    if (!converter->inflight)
+    {
+        LeaveCriticalSection(&converter->cs);
+        return MF_E_TRANSFORM_NEED_MORE_INPUT;
+    }
+
+    g_signal_emit_by_name(converter->appsink, "pull-sample", &sample);
+
+    converter->inflight =  FALSE;
+
+    samples[0].pSample = mf_sample_from_gst_buffer(gst_sample_get_buffer(sample));
+    gst_sample_unref(sample);
+    samples[0].dwStatus = S_OK;
+    samples[0].pEvents = NULL;
+    *status = 0;
+
+    LeaveCriticalSection(&converter->cs);
+
+    return S_OK;

return E_NOTIMPL;
 }
@@ -523,6 +629,49 @@ HRESULT color_converter_create(REFIID riid, void **ret)
     InitializeCriticalSection(&object->cs);
     object->cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": color_converter_lock");

+    object->container = gst_bin_new(NULL);
+
+    if (!(object->appsrc = gst_element_factory_make("appsrc", NULL)))
+    {
+        ERR("Failed to create appsrc, are %u-bit Gstreamer "base" plugins installed?\n",
+                8 * (int)sizeof(void *));
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return E_FAIL;
+    }
+    gst_bin_add(GST_BIN(object->container), object->appsrc);
+
+    if (!(object->videoconvert = gst_element_factory_make("videoconvert", NULL)))
+    {
+        ERR("Failed to create videoconvert, are %u-bit Gstreamer "base" plugins installed?\n",
+                8 * (int)sizeof(void *));
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return E_FAIL;
+    }
+    gst_bin_add(GST_BIN(object->container), object->videoconvert);
+
+    if (!(object->appsink = gst_element_factory_make("appsink", NULL)))
+    {
+        ERR("Failed to create appsink, are %u-bit Gstreamer "base" plugins installed?\n",
+                8 * (int)sizeof(void *));
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return E_FAIL;
+    }
+    gst_bin_add(GST_BIN(object->container), object->appsink);
+
+    if (!gst_element_link(object->appsrc, object->videoconvert))
+    {
+        ERR("Failed to link appsrc to videoconvert\n");
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return E_FAIL;
+    }
+
+    if (!gst_element_link(object->videoconvert, object->appsink))
+    {
+        ERR("Failed to link videoconvert to appsink\n");
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return E_FAIL;
+    }
+
     *ret = &object->IMFTransform_iface;
     return S_OK;
 }

[PATCH 13/17] winegstreamer: Implement ::Process(Input/Output) for color conversion transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83076

Your paranoid android.

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

[PATCH 14/17] winegstreamer: Implement ::ProcessMessage for color conversion MFT.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/colorconvert.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/dlls/winegstreamer/colorconvert.c b/dlls/winegstreamer/colorconvert.c
index b77f3358c52..c07ef22acc3 100644
--- a/dlls/winegstreamer/colorconvert.c
+++ b/dlls/winegstreamer/colorconvert.c
@@ -477,9 +477,16 @@ static HRESULT WINAPI color_converter_ProcessEvent(IMFTransform *iface, DWORD id

static HRESULT WINAPI color_converter_ProcessMessage(IMFTransform *iface, MFT_MESSAGE_TYPE message, ULONG_PTR param)
 {
-    FIXME("%p, %u %lu.\n", iface, message, param);
+    TRACE("%p, %u %lu.\n", iface, message, param);

-    return E_NOTIMPL;
+    switch(message)
+    {
+        case MFT_MESSAGE_NOTIFY_START_OF_STREAM:
+            return S_OK;
+        default:
+            FIXME("Unhandled message type %x.\n", message);
+            return E_NOTIMPL;
+    }
 }

static HRESULT WINAPI color_converter_ProcessInput(IMFTransform *iface, DWORD id, IMFSample *sample, DWORD flags)

[PATCH 14/17] winegstreamer: Implement ::ProcessMessage for color conversion MFT.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83077

Your paranoid android.

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

[PATCH 15/17] winegstreamer: Implement ::Get(Input/Output)StreamInfo for color conversion transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/colorconvert.c | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/dlls/winegstreamer/colorconvert.c b/dlls/winegstreamer/colorconvert.c
index c07ef22acc3..43b8dddeee7 100644
--- a/dlls/winegstreamer/colorconvert.c
+++ b/dlls/winegstreamer/colorconvert.c
@@ -138,16 +138,31 @@ static HRESULT WINAPI color_converter_GetStreamIDs(IMFTransform *iface, DWORD in

static HRESULT WINAPI color_converter_GetInputStreamInfo(IMFTransform *iface, DWORD id, MFT_INPUT_STREAM_INFO *info)
 {
-    FIXME("%p %u %p.\n", iface, id, info);
+    TRACE("%p %u %p.\n", iface, id, info);

-    return E_NOTIMPL;
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    info->dwFlags = MFT_INPUT_STREAM_WHOLE_SAMPLES | MFT_INPUT_STREAM_DOES_NOT_ADDREF;
+    info->cbMaxLookahead = 0;
+    info->cbAlignment = 0;
+    info->hnsMaxLatency = 0;
+
+    return S_OK;
 }

static HRESULT WINAPI color_converter_GetOutputStreamInfo(IMFTransform *iface, DWORD id, MFT_OUTPUT_STREAM_INFO *info)
 {
-    FIXME("%p %u %p.\n", iface, id, info);
+    TRACE("%p %u %p.\n", iface, id, info);

-    return E_NOTIMPL;
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    info->dwFlags = MFT_OUTPUT_STREAM_PROVIDES_SAMPLES;
+    info->cbSize = 0;
+    info->cbAlignment = 0;
+
+    return S_OK;
 }

static HRESULT WINAPI color_converter_GetAttributes(IMFTransform *iface, IMFAttributes **attributes)

[PATCH 15/17] winegstreamer: Implement ::Get(Input/Output)StreamInfo for color conversion transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83078

Your paranoid android.

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

[PATCH 16/17] winegstreamer: Implement Get*Attributes functions for color converter transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/colorconvert.c | 37 +++++++++++++++++++++++++++----
 1 file changed, 33 insertions(+), 4 deletions(-)

diff --git a/dlls/winegstreamer/colorconvert.c b/dlls/winegstreamer/colorconvert.c
index 43b8dddeee7..9e6ece796f3 100644
--- a/dlls/winegstreamer/colorconvert.c
+++ b/dlls/winegstreamer/colorconvert.c
@@ -52,6 +52,8 @@ struct color_converter
 {
     IMFTransform IMFTransform_iface;
     LONG refcount;
+    IMFAttributes *attributes;
+    IMFAttributes *output_attributes;
     IMFMediaType *input_type;
     IMFMediaType *output_type;
     CRITICAL_SECTION cs;
@@ -102,6 +104,10 @@ static ULONG WINAPI color_converter_Release(IMFTransform *iface)
     {
         transform->cs.DebugInfo->Spare[0] = 0;
         DeleteCriticalSection(&transform->cs);
+        if (transform->attributes)
+            IMFAttributes_Release(transform->attributes);
+        if (transform->output_attributes)
+            IMFAttributes_Release(transform->output_attributes);
         gst_object_unref(transform->container);
         heap_free(transform);
     }
@@ -167,9 +173,14 @@ static HRESULT WINAPI color_converter_GetOutputStreamInfo(IMFTransform *iface, D

static HRESULT WINAPI color_converter_GetAttributes(IMFTransform *iface, IMFAttributes **attributes)
 {
-    FIXME("%p, %p.\n", iface, attributes);
+    struct color_converter *converter = impl_color_converter_from_IMFTransform(iface);

-    return E_NOTIMPL;
+    TRACE("%p, %p.\n", iface, attributes);
+
+    *attributes = converter->attributes;
+    IMFAttributes_AddRef(*attributes);
+
+    return S_OK;
 }

static HRESULT WINAPI color_converter_GetInputStreamAttributes(IMFTransform *iface, DWORD id,
@@ -183,9 +194,14 @@ static HRESULT WINAPI color_converter_GetInputStreamAttributes(IMFTransform *ifa
 static HRESULT WINAPI color_converter_GetOutputStreamAttributes(IMFTransform *iface, DWORD id,
         IMFAttributes **attributes)
 {
-    FIXME("%p, %u, %p.\n", iface, id, attributes);
+    struct color_converter *converter = impl_color_converter_from_IMFTransform(iface);

-    return E_NOTIMPL;
+    TRACE("%p, %u, %p.\n", iface, id, attributes);
+
+    *attributes = converter->output_attributes;
+    IMFAttributes_AddRef(*attributes);
+
+    return S_OK;
 }

static HRESULT WINAPI color_converter_DeleteInputStream(IMFTransform *iface, DWORD id)
@@ -639,6 +655,7 @@ static const IMFTransformVtbl color_converter_vtbl =
 HRESULT color_converter_create(REFIID riid, void **ret)
 {
     struct color_converter *object;
+    HRESULT hr;

TRACE("%s %p\n", debugstr_guid(riid), ret);

@@ -651,6 +668,18 @@ HRESULT color_converter_create(REFIID riid, void **ret)
     InitializeCriticalSection(&object->cs);
     object->cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": color_converter_lock");

+    if (FAILED(hr = MFCreateAttributes(&object->attributes, 0)))
+    {
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return hr;
+    }
+
+    if (FAILED(hr = MFCreateAttributes(&object->output_attributes, 0)))
+    {
+        IMFTransform_Release(&object->IMFTransform_iface);
+        return hr;
+    }
+
     object->container = gst_bin_new(NULL);

if (!(object->appsrc = gst_element_factory_make("appsrc", NULL)))

[PATCH 16/17] winegstreamer: Implement Get*Attributes functions for color converter transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83079

Your paranoid android.

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

[PATCH 17/17] winegstreamer: Implement Get(Input/Output)CurrentType functions for color converter transform.

[Derek Lesho]

Signed-off-by: Derek Lesho 
---
 dlls/winegstreamer/colorconvert.c | 58 ++++++++++++++++++++++++++++---
 1 file changed, 54 insertions(+), 4 deletions(-)

diff --git a/dlls/winegstreamer/colorconvert.c b/dlls/winegstreamer/colorconvert.c
index 9e6ece796f3..c7b1fae393f 100644
--- a/dlls/winegstreamer/colorconvert.c
+++ b/dlls/winegstreamer/colorconvert.c
@@ -466,16 +466,66 @@ static HRESULT WINAPI color_converter_SetOutputType(IMFTransform *iface, DWORD i

static HRESULT WINAPI color_converter_GetInputCurrentType(IMFTransform *iface, DWORD id, IMFMediaType **type)
 {
-    FIXME("%p, %u, %p.\n", iface, id, type);
+    IMFMediaType *ret;
+    HRESULT hr;

-    return E_NOTIMPL;
+    struct color_converter *converter = impl_color_converter_from_IMFTransform(iface);
+
+    TRACE("%p, %u, %p.\n", converter, id, type);
+
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    if (FAILED(hr = MFCreateMediaType(&ret)))
+        return hr;
+
+    EnterCriticalSection(&converter->cs);
+
+    if (converter->input_type)
+        hr = IMFMediaType_CopyAllItems(converter->input_type, (IMFAttributes *)ret);
+    else
+        hr = MF_E_TRANSFORM_TYPE_NOT_SET;
+
+    LeaveCriticalSection(&converter->cs);
+
+    if (SUCCEEDED(hr))
+        *type = ret;
+    else
+        IMFMediaType_Release(ret);
+
+    return hr;
 }

static HRESULT WINAPI color_converter_GetOutputCurrentType(IMFTransform *iface, DWORD id, IMFMediaType **type)
 {
-    FIXME("%p, %u, %p.\n", iface, id, type);
+    IMFMediaType *ret;
+    HRESULT hr;

-    return E_NOTIMPL;
+    struct color_converter *converter = impl_color_converter_from_IMFTransform(iface);
+
+    TRACE("%p, %u, %p.\n", converter, id, type);
+
+    if (id != 0)
+        return MF_E_INVALIDSTREAMNUMBER;
+
+    if (FAILED(hr = MFCreateMediaType(&ret)))
+        return hr;
+
+    EnterCriticalSection(&converter->cs);
+
+    if (converter->output_type)
+        hr = IMFMediaType_CopyAllItems(converter->output_type, (IMFAttributes *)ret);
+    else
+        hr = MF_E_TRANSFORM_TYPE_NOT_SET;
+
+    LeaveCriticalSection(&converter->cs);
+
+    if (SUCCEEDED(hr))
+        *type = ret;
+    else
+        IMFMediaType_Release(ret);
+
+    return hr;
 }

static HRESULT WINAPI color_converter_GetInputStatus(IMFTransform *iface, DWORD id, DWORD *flags)

[PATCH 17/17] winegstreamer: Implement Get(Input/Output)CurrentType functions for color converter transform.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=83080

Your paranoid android.

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/winegstreamer/Makefile.in:7
error: patch failed: dlls/winegstreamer/gst_private.h:87
error: patch failed: dlls/winegstreamer/mfplat.c:407
error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:67
error: patch failed: dlls/winegstreamer/mfplat.c:455
Task: Patch failed to apply