Re: [PATCH v2 1/3] D3D10: Add d3dcompiler_43 PARENTSRC to d3d10

[Connor McAdams]

Ah, okay, didn't know about that. I'll change it and send a new patch.

On Thu, Oct 24, 2019 at 6:09 PM Alistair Leslie-Hughes
 wrote:
> I get that, why do you need both?  Wouldn't they compile to the same file utils.o?
>
> makedep is smart enough to use the correct file PARENTSRC\utils.c vs local utils.c.
> The basic logic is, the local file used first if exists, else use the one in the PARENTSRC directory.
>
> From: Connor McAdams 
> Sent: Friday, 25 October 2019 8:54 AM
> To: Alistair Leslie-Hughes 
> Subject: Re: [PATCH v2 1/3] D3D10: Add d3dcompiler_43 PARENTSRC to d3d10
>
> There's a utils.c within the dlls/d3d10/ directory. So, there's a
> utils.c file inside of both d3dcompiler_43 and d3d10.
>
> On Thu, Oct 24, 2019 at 5:50 PM Alistair Leslie-Hughes
>  wrote:
> > Hi Connor,
> > > C_SRCS = \
> > > -
> > >   asmparser.c \
> > > -
> > >   blob.c \
> > > -
> > >   bytecodewriter.c \
> > > -
> > >   compiler.c \
> > > -
> > >   preproc.c \
> > > -
> > >   reflection.c \
> > > -
> > >   ../d3dcompiler_43/utils.c \
> >
> > Since you have PARENTSRC set, have the path doesn't make sense.
> > >     d3d10_main.c \
> > >     effect.c \
> > >     shader.c \
> > >     stateblock.c \
> > >     utils.c
> >    ^^^^^^^^^^^^^^
> >
> > Is there a reason you are including two utils.c files?  Wouldn't they  compile to the same place?
> >
> > Regards
> > Alistair.

[PATCH v2 1/3] D3D10: Add d3dcompiler_43 PARENTSRC to d3d10

[Connor McAdams]

Okay, just tried your suggestion, and it doesn't compile... am I
missing something? Are you suggesting I only have one mention of
utils.c under C_SRC's?

On Thu, Oct 24, 2019 at 9:29 PM Connor McAdams  wrote:
> Ah, okay, didn't know about that. I'll change it and send a new patch.
>
> On Thu, Oct 24, 2019 at 6:09 PM Alistair Leslie-Hughes
>  wrote:
> > I get that, why do you need both?  Wouldn't they compile to the same file utils.o?
> >
> > makedep is smart enough to use the correct file PARENTSRC\utils.c vs local utils.c.
> > The basic logic is, the local file used first if exists, else use the one in the PARENTSRC directory.
> >
> > From: Connor McAdams 
> > Sent: Friday, 25 October 2019 8:54 AM
> > To: Alistair Leslie-Hughes 
> > Subject: Re: [PATCH v2 1/3] D3D10: Add d3dcompiler_43 PARENTSRC to d3d10
> >
> > There's a utils.c within the dlls/d3d10/ directory. So, there's a
> > utils.c file inside of both d3dcompiler_43 and d3d10.
> >
> > On Thu, Oct 24, 2019 at 5:50 PM Alistair Leslie-Hughes
> >  wrote:
> > > Hi Connor,
> > > > C_SRCS = \
> > > > -
> > > >   asmparser.c \
> > > > -
> > > >   blob.c \
> > > > -
> > > >   bytecodewriter.c \
> > > > -
> > > >   compiler.c \
> > > > -
> > > >   preproc.c \
> > > > -
> > > >   reflection.c \
> > > > -
> > > >   ../d3dcompiler_43/utils.c \
> > >
> > > Since you have PARENTSRC set, have the path doesn't make sense.
> > > >     d3d10_main.c \
> > > >     effect.c \
> > > >     shader.c \
> > > >     stateblock.c \
> > > >     utils.c
> > >    ^^^^^^^^^^^^^^
> > >
> > > Is there a reason you are including two utils.c files?  Wouldn't they  compile to the same place?
> > >
> > > Regards
> > > Alistair.

[PATCH v2 1/3] D3D10: Add d3dcompiler_43 PARENTSRC to d3d10

[Alistair Leslie-Hughes]

Hi Connor,
I've just had another look at the patch.

PARENTSRC is really for DLL's that are going to reuse ~95% of the code.  (d3dx9_*, d3dcompiler_* as example).

This isn't you case and I'm sorry I didn't pick it up first time around.

I guess patch 2 is showing the direction you want to head. I would start of with adding testcases and this
may lead to the correct solution.

Maybe Henri can give some more advise.

Regards
Alistair.