Re: Conformance test for bug #7286

[Dmitry Timoshkov]

"Misha Koshelev"  wrote:
> - /* Now create the notification thread */
> - events[1] = CreateThread(NULL, 0, NotificationThread, (LPVOID)events[0],
> -
>                          0, &threadId);
> - ok(events[1] != INVALID_HANDLE_VALUE, "CreateThread error: %d\n", GetLastError());

CreateThread returns NULL on error, not INVALID_HANDLE_VALUE.

Conformance test for bug #7286

[Koshelev, Misha Vladislavo]

I copied and pasted that code straight from the StartNotificationThread function in the same
file (well, minus the fact that I am waiting for two events, which is how the refcount problem
is brought about), that is dlls/kernel32/tests/change.c. I will change it in my patch, do I also 
need to change it in the existing StartNotificationThread function?

Misha

-----Original Message-----
From: Dmitry Timoshkov [mailto:[e-mail]]
Sent: Thu 2/1/2007 11:15 PM
To: Koshelev, Misha Vladislavo
Cc: [e-mail]
Subject: Re: Conformance test for bug #7286

"Misha Koshelev"  wrote:
> - /* Now create the notification thread */
> - events[1] = CreateThread(NULL, 0, NotificationThread, (LPVOID)events[0],
> -
>                          0, &threadId);
> - ok(events[1] != INVALID_HANDLE_VALUE, "CreateThread error: %d\n", GetLastError());

CreateThread returns NULL on error, not INVALID_HANDLE_VALUE.

Conformance test for bug #7286

[Dmitry Timoshkov]

"Koshelev, Misha Vladislavo"  wrote:
> I copied and pasted that code straight from the StartNotificationThread function in the same
> file (well, minus the fact that I am waiting for two events, which is how the refcount problem
> is brought about), that is dlls/kernel32/tests/change.c. I will change it in my patch,

Thanks.
> do I also 
> need to change it in the existing StartNotificationThread function?

If you do please send that fix as a separate patch.

Conformance test for bug #7286

[Misha Koshelev]

Sending new patch to wine-patches now. Also, the important thing I think
about this conformance test (although the checks of course are important
too) is that on the current git version this conformance test will
completely kill wineserver (which my other patch for this bug fixes).

Misha

On Fri, 2007-02-02 at 13:15 +0800, Dmitry Timoshkov wrote:
> "Misha Koshelev"  wrote:
> > - /* Now create the notification thread */
> > - events[1] = CreateThread(NULL, 0, NotificationThread, (LPVOID)events[0],
> > -
> >                          0, &threadId);
> > - ok(events[1] != INVALID_HANDLE_VALUE, "CreateThread error: %d\n", GetLastError());
>
> CreateThread returns NULL on error, not INVALID_HANDLE_VALUE.