Re: user32: Always enable owner window in EndDialog.

[Alexandre Julliard]

Jacek Caban  writes:
> @@ -12245,6 +12245,7 @@ static void test_EndDialog(void)
>      hactive = GetForegroundWindow();
>      ok(hdlg == hactive, "Wrong window has focus (%p != %p)\n", hdlg, hactive);
>      EndDialog(hdlg, 0);
> - ok(IsWindowEnabled(hparent), "parent is not enabled\n");
> hactive = GetForegroundWindow();
> ok(hparent == hactive, "Wrong window has focus (parent != active) (active: %p, parent: %p, dlg: %p, other: %p)\n", hactive, hparent, hdlg, hother);
> DestroyWindow(hdlg);

It would be interesting to test what happens if the dialog is not the
active window.

user32: Always enable owner window in EndDialog.

[Jacek Caban]

On 02/25/16 12:32, Alexandre Julliard wrote:
> Jacek Caban  writes:
> > @@ -12245,6 +12245,7 @@ static void test_EndDialog(void)
> >      hactive = GetForegroundWindow();
> >      ok(hdlg == hactive, "Wrong window has focus (%p != %p)\n", hdlg, hactive);
> >      EndDialog(hdlg, 0);
> > - ok(IsWindowEnabled(hparent), "parent is not enabled\n");
> > hactive = GetForegroundWindow();
> > ok(hparent == hactive, "Wrong window has focus (parent != active) (active: %p, parent: %p, dlg: %p, other: %p)\n", hactive, hparent, hdlg, hother);
> > DestroyWindow(hdlg);
>
> It would be interesting to test what happens if the dialog is not the
> active window.

It doesn't seem to matter. I sent a new patch with more tests.

Thanks,
Jacek