Re: gdi32/tests: Add a test to check for ERROR_NOACCESS when passing an invalid buffer to GetObject

[Jerome Leclanche]

On Sun, May 9, 2010 at 11:55 PM, Jerome Leclanche  wrote:
> Testcase for bug 18864.
>
> J. Leclanche

This patch reveals a crash in GetObject in wine which I'm unsure how
to fix. Someone proposed using IsBadWritePtr(), but from what I
understand, this is not a recommended solution. Any idea?

gdi32/tests: Add a test to check for ERROR_NOACCESS when passing an invalid buffer to GetObject

[Jerome Leclanche]

PS, please don't commit, the check is wrong. I'll resend it later.

J. Leclanche / Adys

On Mon, May 10, 2010 at 12:15 AM, Jerome Leclanche  wrote:
> On Sun, May 9, 2010 at 11:55 PM, Jerome Leclanche  wrote:
> > Testcase for bug 18864.
> >
> > J. Leclanche
>
> This patch reveals a crash in GetObject in wine which I'm unsure how
> to fix. Someone proposed using IsBadWritePtr(), but from what I
> understand, this is not a recommended solution. Any idea?

gdi32/tests: Add a test to check for ERROR_NOACCESS when passing an invalid buffer to GetObject

[Vitaliy Margolen]

On 05/09/2010 03:15 PM, Jerome Leclanche wrote:
> On Sun, May 9, 2010 at 11:55 PM, Jerome Leclanche  wrote:
> > Testcase for bug 18864.
>
> This patch reveals a crash in GetObject in wine which I'm unsure how
> to fix. Someone proposed using IsBadWritePtr(), but from what I
> understand, this is not a recommended solution. Any idea?

If it doesn't crash on windows and you have a program that depends on broken
behavior - wrap the entire function with exception handler block. For
example see lstrcatA & co.

Vitaliy.

gdi32/tests: Add a test to check for ERROR_NOACCESS when passing an invalid buffer to GetObject

[Jerome Leclanche]

I just tried messing around with it, but all I can get is a timeout
like this in the tests:
err:ntdll:RtlpWaitForCriticalSection section 0x688add20 "gdiobj.c:
gdi_section" wait timed out in thread 0024, blocked by 0023, retrying
(60 sec)

Or worse, a crash in the app:
err:gdi:GDI_CheckNotLock BUG: holding GDI lock
wine: Unhandled exception 0x80000003 at address 0x7edebb63 (thread
0009), starting debugger...
DebugBreak () at /home/adys/src/wine/dlls/kernel32/../../include/winternl.h:1957
0x7edebb63 DebugBreak+0x3
[/home/adys/src/wine/dlls/kernel32/../../include/winternl.h:1957] in
kernel32: int    $3
1957    static inline void WINAPI DbgBreakPoint(void) { __asm__
__volatile__("int3"); }

What am I missing?

J. Leclanche

On Mon, May 10, 2010 at 6:31 AM, Vitaliy Margolen
 wrote:
> On 05/09/2010 03:15 PM, Jerome Leclanche wrote:
> > On Sun, May 9, 2010 at 11:55 PM, Jerome Leclanche  wrote:
> > > Testcase for bug 18864.
> >
> > This patch reveals a crash in GetObject in wine which I'm unsure how
> > to fix. Someone proposed using IsBadWritePtr(), but from what I
> > understand, this is not a recommended solution. Any idea?
>
> If it doesn't crash on windows and you have a program that depends on broken
> behavior - wrap the entire function with exception handler block. For
> example see lstrcatA & co.
>
> Vitaliy.