Re: [PATCH] wined3d: mirror d3dresourcetype

[Stefan Dösinger]

Am Sonntag, 14. Juni 2009 14:26:53 schrieb Marcus Meissner:
> Hi,
>
> gcc 4.5trunk warned that we do not handle case 7 (D3DRTYPE_INDEXBUFFER),
> so add it here too.

There's a reason why this doesn't exist - WineD3D has index and vertex buffers 
merged, so there is no such thing as a specialized index buffer.

Where does this warning occur? The code that maps D3DRTYPE to WINED3DRTYPE or 
vice versa should be fixed to map INDEXBUFFER to BUFFER, and take care for 
the reverse conversion

[PATCH] wined3d: mirror d3dresourcetype

[Marcus Meissner]

On Sun, Jun 14, 2009 at 04:30:30PM +0200, Stefan Dösinger wrote:
> Am Sonntag, 14. Juni 2009 14:26:53 schrieb Marcus Meissner:
> > Hi,
> >
> > gcc 4.5trunk warned that we do not handle case 7 (D3DRTYPE_INDEXBUFFER),
> > so add it here too.
>
> There's a reason why this doesn't exist - WineD3D has index and vertex buffers 
> merged, so there is no such thing as a specialized index buffer.
>
> Where does this warning occur? The code that maps D3DRTYPE to WINED3DRTYPE or 
> vice versa should be fixed to map INDEXBUFFER to BUFFER, and take care for 
> the reverse conversion

Here:
/home/marcus/projects/wine/dlls/d3d9/device.c: In Funktion »reset_enum_callback«:
/home/marcus/projects/wine/dlls/d3d9/device.c:461:9: Warnung: case-Wert »7« nicht in Aufzählungstyp »WINED3DRESOURCETYPE«

Ciao, Marcus

[PATCH] wined3d: mirror d3dresourcetype

[Stefan Dösinger]

> Here:
> /home/marcus/projects/wine/dlls/d3d9/device.c: In
> Funktion »reset_enum_callback«:

Does the attached patch fix the issue?

[PATCH] wined3d: mirror d3dresourcetype

[Marcus Meissner]

On Sun, Jun 14, 2009 at 05:29:39PM +0200, Stefan Dösinger wrote:
> > Here:
> > /home/marcus/projects/wine/dlls/d3d9/device.c: In
> > Funktion »reset_enum_callback«:
>
> Does the attached patch fix the issue?

Yes it does.

Ciao, Marcus

[PATCH] wined3d: mirror d3dresourcetype

[Henri Verbeet]

2009/6/14 Stefan Dösinger :
> > Here:
> > /home/marcus/projects/wine/dlls/d3d9/device.c: In
> > Funktion »reset_enum_callback«:
>
> Does the attached patch fix the issue?

I have a patch touching that code, could you wait with sending it in a
bit? (I could also rebase it and send it in.)

[PATCH] wined3d: mirror d3dresourcetype

[Stefan Dösinger]

Am Sonntag, 14. Juni 2009 17:40:39 schrieb Henri Verbeet:
> 2009/6/14 Stefan Dösinger :
> > > Here:
> > > /home/marcus/projects/wine/dlls/d3d9/device.c: In
> > > Funktion »reset_enum_callback«:
> >
> > Does the attached patch fix the issue?
>
> I have a patch touching that code, could you wait with sending it in a
> bit? (I could also rebase it and send it in.)

Sure, no problem. It is number 30 in my send queue anyway.