Re: [PATCH] Enable X11DRV_DIB_GetImageBits_8 in all cases and optimize X11DRV_DIB_GetNearestIndex to fix bug 2666 and other strange behavior

[Frédéric Delanoy]

Please do not include bug number in commit message summary line.
Put something like 'fixes bug 123 in the commit header

See http://wiki.winehq.org/SubmittingPatches for more info (e.g.
"subject line" and "include a description" sections)

Frédéric

[PATCH] Enable X11DRV_DIB_GetImageBits_8 in all cases and optimize X11DRV_DIB_GetNearestIndex to fix bug 2666 and other strange behavior

[Alex Henrie]

2011/9/28 Frédéric Delanoy
> Please do not include bug number in commit message summary line.
> Put something like 'fixes bug 123 in the commit header
>
> See http://wiki.winehq.org/SubmittingPatches for more info (e.g.
> "subject line" and "include a description" sections)

Thanks for the info. I'll follow those guidelines more closely from now on.
Apologies for submitting the patch twice--the first time I sent it, it
didn't go through. I figured that it didn't work because I wasn't subscribed
to wine-devel, so I subscribed and submitted it again, and then both
attempts went through. In any case, I hope you find the patch helpful and
I'll do better about submitting patches properly in the future.

-Alex

[PATCH] Enable X11DRV_DIB_GetImageBits_8 in all cases and optimize X11DRV_DIB_GetNearestIndex to fix bug 2666 and other strange behavior

[Alex Henrie]

2011/9/28 Alex Henrie
> I figured that it didn't work because I wasn't subscribed to wine-devel

I meant to say, it didn't work because I wasn't subscribed to
wine-patches...

-Alex

[PATCH] Enable X11DRV_DIB_GetImageBits_8 in all cases and optimize X11DRV_DIB_GetNearestIndex to fix bug 2666 and other strange behavior

[Frédéric Delanoy]

2011/9/29 Alex Henrie :
> 2011/9/28 Frédéric Delanoy
> > Please do not include bug number in commit message summary line.
> > Put something like 'fixes bug 123 in the commit header
> >
> > See http://wiki.winehq.org/SubmittingPatches for more info (e.g.
> > "subject line" and "include a description" sections)
>
> Thanks for the info. I'll follow those guidelines more closely from now on.
> Apologies for submitting the patch twice--the first time I sent it, it
> didn't go through. I figured that it didn't work because I wasn't subscribed
> to wine-devel, so I subscribed and submitted it again, and then both
> attempts went through. In any case, I hope you find the patch helpful and
> I'll do better about submitting patches properly in the future.

BTW http://source.winehq.org/patches/ show the current patch list.
Note however that patches won't be committed (if accepted) until next
week since there's wineconf this week-end

Frédéric