You have a few places where variable declaration has moved from the top of the function to under your block. That should be fixed.
It is hard to read through the whitespace changes for me. I though general convention was that you did not change whitespace (i seems to remember a small war over that)
other than that things look ok. Have you tested this by setting your locale to ja_JP or zh_CN or ko_KR to make sure the fixme come back and such?
thanks -aric
Ivan Leo Puoti wrote:
We have 2 space, 4 space and 5 space indentation in ime.c, so fix that. Also behave like windows if we're on a locale that doesn't support, by returning 0 after setting last error to 120.
Ivan.
I'm trying to compile some C++ code, but hit a basic problem with some of the headers. Example, even just the single include:
#include <iostream>
yields
wineg++ -c -mno-cygwin -I. -o cxx_iostream.o cxx_iostream.cpp In file included from /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/i386-redhat-linux/bits/c++locale.h:42, from /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/iosfwd:46, from /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/ios:44, from /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/ostream:45, from /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/iostream:45, from cxx_iostream.cpp:1: /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/cstdio:167: error: `::snprintf' has not been declared /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/cstdio:168: error: `::vfscanf' has not been declared /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/cstdio:169: error: `::vscanf' has not been declared /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/cstdio:171: error: `::vsscanf' has not been declared ....
The error list goes on for a few pages. This is with Winelib 20041019 on FC2 (gcc 3.4).
Do I need some #defines to correct this? I tried scanning the gcc headers with that in mind, but couldn't find any which solved this.
Are the GCC C++ includes incompatible with the winelib headers?
Geoff
On Sat, Dec 11, 2004 at 10:17:38AM -0600, Geoff Hart wrote:
I'm trying to compile some C++ code, but hit a basic problem with some of the headers. Example, even just the single include:
#include <iostream>
yields
wineg++ -c -mno-cygwin -I. -o cxx_iostream.o cxx_iostream.cpp In file included from error: `::vscanf' has not been declared /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/cstdio:171:
Are the GCC C++ includes incompatible with the winelib headers?
Yes, the msvcrt headers (invoked via -mno-cygwin) are. You need to use the glibc headers (try to get rid of -mno-cygwin).