On December 18, 2002 07:10 pm, Tony Lambregts wrote:
In an effort to start a flame war <g> I decided to add a few notes about style to patches.sgml and while I was at it I added a note about being able to submit non cvs patches.
+ Patches should be attached so that they can be read inline. This + may mean some more work for you. However it allows others to review + your patch easily and increase the chances of it not being + overlooked or forgotten.
This should read "Patches should be inlined (if you can configure your email client to not wrap lines), or attached as text/plain attachements...."
On Thu, Dec 19, 2002 at 01:10:52AM -0500, Dimitrie O. Paun wrote:
This should read "Patches should be inlined (if you can configure your email client to not wrap lines), or attached as text/plain attachements...."
Maybe you should include a step by step instruction for outlook users how to do that. It seems that outlook is the leading misattachment generator, so instead of just telling people what NOT to do, maybe you can tell people how to do it right.
Ciao Jörg
-- Joerg Mayer jmayer@loplof.de I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.
Joerg Mayer wrote:
On Thu, Dec 19, 2002 at 01:10:52AM -0500, Dimitrie O. Paun wrote:
This should read "Patches should be inlined (if you can configure your email client to not wrap lines), or attached as text/plain attachements...."
Maybe you should include a step by step instruction for outlook users how to do that. It seems that outlook is the leading misattachment generator, so instead of just telling people what NOT to do, maybe you can tell people how to do it right.
Well I suppose I could if I had those instructions. However it seems out of scope for a style section. AFAIK just giving the patch a .txt extention and attaching will solve the problem for most mailers including outlook.
On Thu, Dec 19, 2002 at 10:36:14AM -0700, Tony Lambregts wrote:
Joerg Mayer wrote:
Maybe you should include a step by step instruction for outlook users how to do that. It seems that outlook is the leading misattachment generator, so instead of just telling people what NOT to do, maybe you can tell people how to do it right.
Well I suppose I could if I had those instructions.
I jsut dug out the following mail:
---------------- Message-ID: 01f801c27fc4$3060c100$c4823bd5@dmitry From: "Dmitry Timoshkov" dmitry@baikal.ru To: "Patrik Stridvall" ps@leissner.se Cc: wine-devel@winehq.com References: 9B72374533931944B8501EFE41A391E5A50CE2@knasen.leissner.se Subject: Re: winapi update X-Spam-Level:
"Patrik Stridvall" ps@leissner.se wrote:
On October 29, 2002 11:27 am, Patrik Stridvall wrote:
Anyway, I can't inline my patches the because Microsoft
Outlook wraps
the lines and I sure a lot of other people that use attachments have similar problems.
And can't be turned off?!? Hmmm, anyway, just attach them as text/plain.
I have no idea how or if it is possible to do either.
This is a part of my mail sent to Guy in order to help him to send patches using Outlook Express. I hope that it will be helpful for Outlook users too.
<QUOTE>
Since I was using OE to send patches, I have found a way to send diffs as attachments and without \n vs. \r\n problem.
You need following two things to make it work.
1. Make sure that .diff files have \r\n line ends, because if OE detects that there is no \r\n line endings it switches to quoted-printable format attachments.
2. Using regedit add key "Content Type" with value "text/plain" to the .diff extension under HKEY_CLASSES_ROOT (same as for .txt extension). This tells OE to use Content-Type: text/plain instead of application/octet-stream.
</QUOTE>
Item #1 is important. After you hit "Send" button, go to "Outbox" and using "Properties" verify the message source to make sure that the mail has correct format. You might want to send several test e-mails to yourself too.