Re: [cryptui] Show the select store text when browsing stores

[Aurimas Fišeras]

On 07/05/2009 04:08 PM, Paul Vriens wrote:
> Hi,
>
> We at least see the text now. Selecting is possible but doesn't work
> (regression?).
>
> Changelog
>   Show the select store text when browsing stores
> -
>        selectInfo.pwszText = LoadStringW(hInstance, IDC_STORE_TEXT,
> -
>         storeText, sizeof(storeText) / sizeof(storeText[0]));

LoadStringW returns int, not string!

LoadStringW(hInstance, IDC_STORE_TEXT, storeText, sizeof(storeText) /
sizeof(storeText[0]));
selectInfo.pwszText = storeText;

[cryptui] Show the select store text when browsing stores

[Paul Vriens]

Aurimas Fišeras wrote:
> On 07/05/2009 04:08 PM, Paul Vriens wrote:
> > Hi,
> >
> > We at least see the text now. Selecting is possible but doesn't work
> > (regression?).
> >
> > Changelog
> >   Show the select store text when browsing stores
> > -
> >        selectInfo.pwszText = LoadStringW(hInstance, IDC_STORE_TEXT,
> > -
> >         storeText, sizeof(storeText) / sizeof(storeText[0]));
>
> LoadStringW returns int, not string!
>
> LoadStringW(hInstance, IDC_STORE_TEXT, storeText, sizeof(storeText) /
> sizeof(storeText[0]));
> selectInfo.pwszText = storeText;

Yep, your right. The strange thing is that it works though.

Even setting selectInfo.pwszText to anything but NULL (not a string 
though) makes the text show up?

Any idea? Is that SendMessage behaviour?

I will resend but was just curious.

[cryptui] Show the select store text when browsing stores

[Paul Vriens]

Paul Vriens wrote:
> Aurimas Fišeras wrote:
> > On 07/05/2009 04:08 PM, Paul Vriens wrote:
> > > Hi,
> > >
> > > We at least see the text now. Selecting is possible but doesn't work
> > > (regression?).
> > >
> > > Changelog
> > >   Show the select store text when browsing stores
> > > -
> > >        selectInfo.pwszText = LoadStringW(hInstance, 
> > >
> > > IDC_STORE_TEXT,
> > > -
> > >         storeText, sizeof(storeText) / sizeof(storeText[0]));
> >
> > LoadStringW returns int, not string!
> >
> > LoadStringW(hInstance, IDC_STORE_TEXT, storeText, sizeof(storeText) /
> > sizeof(storeText[0]));
> > selectInfo.pwszText = storeText;
>
> Yep, your right. The strange thing is that it works though.
>
> Even setting selectInfo.pwszText to anything but NULL (not a string 
> though) makes the text show up?
>
> Any idea? Is that SendMessage behaviour?
>
> I will resend but was just curious.

This doesn't work !!

IDC_STORE_TEXT is not defined as a resource so LoadStringW obviously 
doesn't work. I guess we have to 'activate' IDC_STORE_TEXT in some way 
but I'm still reading the docs ;)

I'm not sure how to tackle this one.

[cryptui] Show the select store text when browsing stores

[Paul Vriens]

Paul Vriens wrote:
> Paul Vriens wrote:
> > Aurimas Fišeras wrote:
> > > On 07/05/2009 04:08 PM, Paul Vriens wrote:
> > > > Hi,
> > > >
> > > > We at least see the text now. Selecting is possible but doesn't work
> > > > (regression?).
> > > >
> > > > Changelog
> > > >   Show the select store text when browsing stores
> > > > -
> > > >        selectInfo.pwszText = LoadStringW(hInstance, 
> > > >
> > > > IDC_STORE_TEXT,
> > > > -
> > > >         storeText, sizeof(storeText) / sizeof(storeText[0]));
> > >
> > > LoadStringW returns int, not string!
> > >
> > > LoadStringW(hInstance, IDC_STORE_TEXT, storeText, sizeof(storeText) /
> > > sizeof(storeText[0]));
> > > selectInfo.pwszText = storeText;
> >
> > Yep, your right. The strange thing is that it works though.
> >
> > Even setting selectInfo.pwszText to anything but NULL (not a string 
> > though) makes the text show up?
> >
> > Any idea? Is that SendMessage behaviour?
> >
> > I will resend but was just curious.
>
> This doesn't work !!
>
> IDC_STORE_TEXT is not defined as a resource so LoadStringW obviously 
> doesn't work. I guess we have to 'activate' IDC_STORE_TEXT in some way 
> but I'm still reading the docs ;)
>
> I'm not sure how to tackle this one.

Sent a patch. It was an initialization issue. I guess pwszText contained 
rubbish here so the text was set (to rubbish). Explicitly setting it to 
NULL fixed that issue.