Re: x11drv: Allow WM to manage more windows.

[Dmitry Timoshkov]

"Vitaliy Margolen"  wrote:
> @@ -67,6 +67,8 @@ static const char visual_id_prop[]    = 
>  inline static BOOL is_window_managed( HWND hwnd )
>  {
>      DWORD style, ex_style;
> - char class_name[7];
> - static const char menu_class[] = "#32768";
> - /* menu windows are not managed */
> - if (GetClassNameA(hwnd, class_name, sizeof(class_name)) &&
> -
>    !memcmp(class_name, menu_class, sizeof(menu_class)))
> -
>    return FALSE;

This won't work for subclassed or custom (OfficeXP like) menus.

x11drv: Allow WM to manage more windows.

[Vitaliy Margolen]

Saturday, January 14, 2006, 6:37:28 AM, Dmitry Timoshkov wrote:
> "Vitaliy Margolen"  wrote:
> > @@ -67,6 +67,8 @@ static const char visual_id_prop[]    = 
> >  inline static BOOL is_window_managed( HWND hwnd )
> >  {
> >      DWORD style, ex_style;
> > - char class_name[7];
> > - static const char menu_class[] = "#32768";
> > - /* menu windows are not managed */
> > - if (GetClassNameA(hwnd, class_name, sizeof(class_name)) &&
> > -
> >    !memcmp(class_name, menu_class, sizeof(menu_class)))
> > -
> >    return FALSE;
> This won't work for subclassed or custom (OfficeXP like) menus.

Yeah you are correct. And it looks like it's redundant anyway. I forgot
that all menus are WS_POPUP without WS_SYSMENU. And I already have a case
for this.

New patch sent.

Vitaliy