Re: [1/7] cmd: Fix FOR tab handling (try 3)

[Octavian Voicu]

2011/8/25 Frédéric Delanoy :
> - const WCHAR inW[] = {'i','n'};
> - const WCHAR doW[] = {'d','o'};

...

Hello,

After these patches get in, it might be a good idea to make all these
strings static. Even if they are const, the compiler still needs to
generate code to initialize the arrays on the stack each time the
function is called, element by element -- larger code size and slower.

Octavian

[1/7] cmd: Fix FOR tab handling (try 3)

[Frédéric Delanoy]

On Thu, Aug 25, 2011 at 01:06, Octavian Voicu  wrote:
> 2011/8/25 Frédéric Delanoy :
> > - const WCHAR inW[] = {'i','n'};
> > - const WCHAR doW[] = {'d','o'};
>
> ...
>
> Hello,
>
> After these patches get in, it might be a good idea to make all these
> strings static. Even if they are const, the compiler still needs to
> generate code to initialize the arrays on the stack each time the
> function is called, element by element -- larger code size and slower.

Actually some of those (with slight differences) were used in multiple
functions/files.
I'll send a patch "rationalizing" that later.

Frédéric