Re: Valgrind support for our unit tests

[Robert Shearman]

Dan Kegel wrote:
> +{
> - todo_suppress_exception_addr4
> - Memcheck:Addr4
> - fun:__wine_call_from_32_regs
> - obj:/home/dank/wine-git/dlls/ntdll/ntdll.dll.so
> - obj:/home/dank/wine-git/dlls/ntdll/ntdll.dll.so
> - fun:raise_exception

I'm not sure this will work for other people unless they log on as dank :-)

However, I don't think maintaining the valgrind suppressions file in 
tree is viable since most of the warnings come from system libraries 
which means that it is very dependent on user's distribution.

It might be best to set up an external git tree for this, which would 
allow for people to submit patches for any bogus warnings in the runs 
that you publish on your website.

Valgrind support for our unit tests

[Dan Kegel]

On Dec 8, 2007 9:13 AM, Robert Shearman  wrote:
> Dan Kegel wrote:
> > - obj:/home/dank/wine-git/dlls/ntdll/ntdll.dll.so
>
> I'm not sure this will work for other people unless they log on as dank :-)

Whoops!
> However, I don't think maintaining the valgrind suppressions file in
> tree is viable since most of the warnings come from system libraries
> which means that it is very dependent on user's distribution.

Right, but we can add suppressions for them all as needed,
it's not that hard to get all the popular libc etc. versions.
> It might be best to set up an external git tree for this, which would
> allow for people to submit patches for any bogus warnings

I'd rather that be maintained in the main tree.  I'm trying
to reduce my typing...
and really, I'd like to see more than just one person running
valgrind with wine.
- Dan

Valgrind support for our unit tests

[James McKenzie]

Dan Kegel wrote:
> On Dec 8, 2007 9:13 AM, Robert Shearman  wrote:
> > Dan Kegel wrote:
> > > - obj:/home/dank/wine-git/dlls/ntdll/ntdll.dll.so
> >
> > I'm not sure this will work for other people unless they log on as dank :-)
>
> Whoops!

Since I am a Mac user, does valgrind exist for this platform and if so,
where can it get/build it?

I feel that reports from Mac users would be useful as well as from the
Linux community.

Thank you.

James

Valgrind support for our unit tests

[Zac Brown]

James McKenzie wrote:
> Dan Kegel wrote:
> > On Dec 8, 2007 9:13 AM, Robert Shearman  wrote:
> > > Dan Kegel wrote:
> > > > - obj:/home/dank/wine-git/dlls/ntdll/ntdll.dll.so
> > >
> > > I'm not sure this will work for other people unless they log on as dank :-)
> >
> > Whoops!
>
> Since I am a Mac user, does valgrind exist for this platform and if so,
> where can it get/build it?
>
> I feel that reports from Mac users would be useful as well as from the
> Linux community.
>
> Thank you.
>
> James

There is no valgrind port for Mac OS X yet but it looks to me that the
likelihood of there being one is pretty good.

See this link: http://valgrind.org/info/platforms.html

It mentions that Darwin support for x86 will be high, but would that
be that helpful in Leopard? If I recall correctly, Leopard is
fully 64-bit now. <-- Someone correct me if I'm wrong on that.

-Zac

Valgrind support for our unit tests

[Dan Kegel]

On Dec 8, 2007 12:42 PM, James McKenzie  wrote:
> I feel that reports from Mac users would be useful as well as from the
> Linux community.

Yes, it'd be nice to have MacOSX support for
Valgrind sometime.  It would probably take significant
effort; hopefully Apple or some very motivated grad
student will do it someday.

But most of the useful errors Valgrind picks up are
probably platform independent, so Wine on Mac
will still benefit from the Valgrinding going on under Linux.
- Dan