Sorry, meant reply-to-all
---------- Weitergeleitete Nachricht ----------
Subject: Re: CommandLineToArgvW fix Date: Mon, 8 Oct 2001 20:23:57 +0200 From: Malte Starostik malte@kde.org To: eric pouech eric.pouech@wanadoo.fr
Am Monday 08 October 2001 20:08 schrieben Sie:
You're definately right, I mixed up argv with argv[i] there.
wouldn't the (completly untested but) attached patch work better ?
Didn't test it either, will do so somewhen later, looks right to me. -- Malte Starostik PGP: 1024D/D2F3C787 [C138 2121 FAF3 410A 1C2A 27CD 5431 7745 D2F3 C787]
-------------------------------------------------------
On Mon, 8 Oct 2001, Malte Starostik wrote:
Here's my take on this. I believe it's a slightly better patch. I tested this in NT4 and there is indeed a single alloc done for the array and the strings. Also, the array does not contain a terminating NULL pointer like I thought. And the lpCmdLine="" case is handled the same way so this patch changes that too. I did not test the patch... yet (recompiling). If I find something wrong I'll send an updated version.
-- Francois Gouget fgouget@free.fr http://fgouget.free.fr/ Any sufficiently advanced Operating System is indistinguishable from Linux