Re: editline count CRLF

[Eric Pouech]

Jonathan Ernst wrote:
> Again an old patch that was lost in bugzilla...
>
> Fixes Bug 2509 (http://bugs.winehq.org/show_bug.cgi?id=2509)
>
> Changelog:
> Joshua Davies  :
>
> It looks like windows is returning the length of the string, plus the CRLF
> delimiters, whereas wineconsole is returning one less.
>
> The attached patch seems to correct the problem; apply this patch to the latest
> version of dlls/kernel/editline.c.
>
> --- dlls/kernel/editline.bak	2004-10-12 17:04:17.000000000 -0500
> +++ dlls/kernel/editline.c	2004-10-12 17:04:25.000000000 -0500
> @@ -376,7 +376,8 @@
>  {
>      WCHAR       nl = '\n';
>      if (!WCEL_Grow(ctx, 1)) return;
> - ctx->line[ctx->len++] = '\n';
> - ctx->line[ctx->len++] = 0x0d;
> - ctx->line[ctx->len++] = 0x0a;

please use '\r' and '\n' instead of their numeric values
A+

editline count CRLF

[Eric Pouech]

> please use '\r' and '\n' instead of their numeric values
> A+

and grow the buffer of a count of 2 as you're adding two chars
A+