Re: [PATCH 4/4] d3d9/tests: Windows 10 15.07 doesn't detect external mode changes.

[Henri Verbeet]

On 19 October 2017 at 10:09, Stefan Dösinger [email protected] wrote:
> This fixes this test failure:
> http://test.winehq.org/data/9787af34b1c23deb67902fc7dbf2c8421b987048/win10_n...
>
> What I have tried to debug or try to work around this issue:
> *) Checked that the resolution is actually changed. It is changed from
> 640x480 to 800x600.
> *) IDirect3DSwapchain9Ex::GetDisplayModeEx sees the new mode. Calling
> this method does not make Present see it though.
> *) Replace Present with PresentEx.
> *) Call flush_events before calling Present.
>
> I'm happy to try more ideas, but I think this is just broken in this
> Windows build. It is working OK in my 17.03 VM, and I believe it was
> working on 16.07 too, but I don't have 16.07 around anymore because it
> auto updated to 17.03...

Should we update the Windows 10 VMs at some point? Do we want to keep
the old versions around?

[PATCH 4/4] d3d9/tests: Windows 10 15.07 doesn't detect external mode changes.

[Stefan Dösinger]

Am 2017-10-19 um 13:25 schrieb Henri Verbeet:
> Should we update the Windows 10 VMs at some point? Do we want to keep
> the old versions around?

I am absolutely in favor of upgrading them, and I've argued for this in
February, in particular because newer Windows versions fix some test
problems we have.

At the time Francois said that it breaks many other tests, so there was
resistance against this change. In the meantime I'm doing my part and
making sure that the d3d tests work on the newer versions...

[PATCH 4/4] d3d9/tests: Windows 10 15.07 doesn't detect external mode changes.

[Francois Gouget]

On Thu, 19 Oct 2017, Stefan Dösinger wrote:
[...]
> At the time Francois said that it breaks many other tests, so there was
> resistance against this change. In the meantime I'm doing my part and
> making sure that the d3d tests work on the newer versions...

Actually, I think the remark I made at the time was more general, i.e. 
that usually when I upgrade a TestBot VM we get new failures which 
somehow makes Wine developers unhappy. So I've refrained from 
unsolicited upgrades a bit.

Also they are a bit of a hassle, though a bit less now that they won't 
require a restart of the TestBot server.

But I'm not specifically against upgrading the Windows 10 VM. So I'll
schedule it some time soon.