On 09/02/2009 12:27 PM, Jacek Caban wrote:
dlls/mshtml/tests/htmldoc.c | 270 +++++++++++++++++++++++++++++-------------- 1 files changed, 182 insertions(+), 88 deletions(-)
Hi Jacek,
Looks like this one introduced 2 test failures on some boxes, I couldn't find a common denominator though.
The failures happen on IE6, IE7 and IE8 on different platforms (NT4 and higher). There are however also IE8 boxes without failures.
The failures seem to be triggered by the "test_download(FALSE, FALSE, FALSE);" on line 4026.
Could you have a look?
(Some other failures happen on ME and lower but I'll investigate those).
Hi Paul,
Paul Vriens wrote:
On 09/02/2009 12:27 PM, Jacek Caban wrote:
dlls/mshtml/tests/htmldoc.c | 270 +++++++++++++++++++++++++++++-------------- 1 files changed, 182 insertions(+), 88 deletions(-)
Hi Jacek,
Looks like this one introduced 2 test failures on some boxes, I couldn't find a common denominator though.
The failures happen on IE6, IE7 and IE8 on different platforms (NT4 and higher). There are however also IE8 boxes without failures.
The failures seem to be triggered by the "test_download(FALSE, FALSE, FALSE);" on line 4026.
Could you have a look?
(Some other failures happen on ME and lower but I'll investigate those).
I'm sorry for late response. I have problems with reproducing it. It works differently on my IE8 on XP. I sometimes get failures that I haven't seen on test results, but I can't reproduce these failures. I don't have an access to my other VMs ATM. Could you please send me output of running tests with attached patch?
Thanks, Jacek
diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c index 15aeca4..bd2cf2b 100644 --- a/dlls/mshtml/tests/htmldoc.c +++ b/dlls/mshtml/tests/htmldoc.c @@ -53,6 +53,7 @@ DEFINE_OLEGUID(CGID_DocHostCmdPriv, 0x000214D4L, 0, 0);
#define CHECK_EXPECT2(func) \ do { \ + trace(#func "\n"); \ ok(expect_ ##func, "unexpected call " #func "\n"); \ called_ ## func = TRUE; \ }while(0)