The job details page knows which property it is accessing so there is no need to go through the generic GetDisplayValue(). This makes the code more readable.
Signed-off-by: Francois Gouget fgouget@codeweavers.com --- testbot/web/JobDetails.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/testbot/web/JobDetails.pl b/testbot/web/JobDetails.pl index 5e538f884..da4ad7e96 100644 --- a/testbot/web/JobDetails.pl +++ b/testbot/web/JobDetails.pl @@ -88,7 +88,7 @@ sub GenerateDataCell($$$$) if ($PropertyName eq "VM") { print "<td><a href='#k", $self->escapeHTML($StepTask->GetKey()), "'>"; - print $self->escapeHTML($self->GetDisplayValue($StepTask, $PropertyDescriptor)); + print $self->escapeHTML($StepTask->VM->Name); print "</a></td>\n"; } elsif ($PropertyName eq "FileName") @@ -100,7 +100,7 @@ sub GenerateDataCell($$$$) my $URI = "/GetFile.pl?JobKey=" . uri_escape($JobId) . "&StepKey=" . uri_escape($StepTask->StepNo); print "<td><a href='" . $self->escapeHTML($URI) . "'>"; - print $self->escapeHTML($self->GetDisplayValue($StepTask, $PropertyDescriptor)); + print $self->escapeHTML($StepTask->FileName); print "</a></td>\n"; } else